All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/1] Add rtc PCF2131 support
@ 2024-04-10  7:01 ` Joy Zou
  0 siblings, 0 replies; 8+ messages in thread
From: Joy Zou @ 2024-04-10  7:01 UTC (permalink / raw)
  To: ping.bai, robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer
  Cc: kernel, festevam, linux-imx, devicetree, imx, linux-arm-kernel,
	linux-kernel

The patchset supports RTC PCF2131 on board dts.
For the details, please check the patch commit log.

Joy Zou (1):
  arm64: dts: imx93-11x11-evk: add rtc PCF2131 support

 .../boot/dts/freescale/imx93-11x11-evk.dts    | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

-- 
2.37.1


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH v3 0/1] Add rtc PCF2131 support
@ 2024-04-10  7:01 ` Joy Zou
  0 siblings, 0 replies; 8+ messages in thread
From: Joy Zou @ 2024-04-10  7:01 UTC (permalink / raw)
  To: ping.bai, robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer
  Cc: kernel, festevam, linux-imx, devicetree, imx, linux-arm-kernel,
	linux-kernel

The patchset supports RTC PCF2131 on board dts.
For the details, please check the patch commit log.

Joy Zou (1):
  arm64: dts: imx93-11x11-evk: add rtc PCF2131 support

 .../boot/dts/freescale/imx93-11x11-evk.dts    | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

-- 
2.37.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support
  2024-04-10  7:01 ` Joy Zou
@ 2024-04-10  7:01   ` Joy Zou
  -1 siblings, 0 replies; 8+ messages in thread
From: Joy Zou @ 2024-04-10  7:01 UTC (permalink / raw)
  To: ping.bai, robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer
  Cc: kernel, festevam, linux-imx, devicetree, imx, linux-arm-kernel,
	linux-kernel

Support rtc PCF2131 on imx93-11x11-evk.

Signed-off-by: Joy Zou <joy.zou@nxp.com>
---
Changes in v3:
1.adjust the indentation.

Changes in v2:
1. remove unnecessary status property.
---
 .../boot/dts/freescale/imx93-11x11-evk.dts    | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
index 07e85a30a25f..73e0bca36b81 100644
--- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
@@ -281,6 +281,23 @@ ldo5: LDO5 {
 	};
 };
 
+&lpi2c3 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	clock-frequency = <400000>;
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&pinctrl_lpi2c3>;
+	pinctrl-1 = <&pinctrl_lpi2c3>;
+	status = "okay";
+
+	pcf2131: rtc@53 {
+		compatible = "nxp,pcf2131";
+		reg = <0x53>;
+		interrupt-parent = <&pcal6524>;
+		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
+	};
+};
+
 &iomuxc {
 	pinctrl_eqos: eqosgrp {
 		fsl,pins = <
@@ -343,6 +360,13 @@ MX93_PAD_I2C2_SDA__LPI2C2_SDA			0x40000b9e
 		>;
 	};
 
+	pinctrl_lpi2c3: lpi2c3grp {
+		fsl,pins = <
+			MX93_PAD_GPIO_IO28__LPI2C3_SDA			0x40000b9e
+			MX93_PAD_GPIO_IO29__LPI2C3_SCL			0x40000b9e
+		>;
+	};
+
 	pinctrl_pcal6524: pcal6524grp {
 		fsl,pins = <
 			MX93_PAD_CCM_CLKO2__GPIO3_IO27			0x31e
-- 
2.37.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support
@ 2024-04-10  7:01   ` Joy Zou
  0 siblings, 0 replies; 8+ messages in thread
From: Joy Zou @ 2024-04-10  7:01 UTC (permalink / raw)
  To: ping.bai, robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer
  Cc: kernel, festevam, linux-imx, devicetree, imx, linux-arm-kernel,
	linux-kernel

Support rtc PCF2131 on imx93-11x11-evk.

Signed-off-by: Joy Zou <joy.zou@nxp.com>
---
Changes in v3:
1.adjust the indentation.

Changes in v2:
1. remove unnecessary status property.
---
 .../boot/dts/freescale/imx93-11x11-evk.dts    | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
index 07e85a30a25f..73e0bca36b81 100644
--- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
@@ -281,6 +281,23 @@ ldo5: LDO5 {
 	};
 };
 
+&lpi2c3 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	clock-frequency = <400000>;
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&pinctrl_lpi2c3>;
+	pinctrl-1 = <&pinctrl_lpi2c3>;
+	status = "okay";
+
+	pcf2131: rtc@53 {
+		compatible = "nxp,pcf2131";
+		reg = <0x53>;
+		interrupt-parent = <&pcal6524>;
+		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
+	};
+};
+
 &iomuxc {
 	pinctrl_eqos: eqosgrp {
 		fsl,pins = <
@@ -343,6 +360,13 @@ MX93_PAD_I2C2_SDA__LPI2C2_SDA			0x40000b9e
 		>;
 	};
 
+	pinctrl_lpi2c3: lpi2c3grp {
+		fsl,pins = <
+			MX93_PAD_GPIO_IO28__LPI2C3_SDA			0x40000b9e
+			MX93_PAD_GPIO_IO29__LPI2C3_SCL			0x40000b9e
+		>;
+	};
+
 	pinctrl_pcal6524: pcal6524grp {
 		fsl,pins = <
 			MX93_PAD_CCM_CLKO2__GPIO3_IO27			0x31e
-- 
2.37.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support
  2024-04-10  7:01   ` Joy Zou
@ 2024-04-10  7:40     ` Marco Felsch
  -1 siblings, 0 replies; 8+ messages in thread
From: Marco Felsch @ 2024-04-10  7:40 UTC (permalink / raw)
  To: Joy Zou
  Cc: ping.bai, robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo,
	s.hauer, devicetree, imx, linux-kernel, linux-imx, kernel,
	festevam, linux-arm-kernel

On 24-04-10, Joy Zou wrote:
> Support rtc PCF2131 on imx93-11x11-evk.
> 
> Signed-off-by: Joy Zou <joy.zou@nxp.com>
> ---
> Changes in v3:
> 1.adjust the indentation.
> 
> Changes in v2:
> 1. remove unnecessary status property.
> ---
>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> index 07e85a30a25f..73e0bca36b81 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> @@ -281,6 +281,23 @@ ldo5: LDO5 {
>  	};
>  };
>  
> +&lpi2c3 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	clock-frequency = <400000>;
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&pinctrl_lpi2c3>;
> +	pinctrl-1 = <&pinctrl_lpi2c3>;

Are both "default" and "sleep" pinctrl's required? It doesn't make any
sense to provde a sleep state which uses the same pinctrl state.

Regards,
  Marco

> +	status = "okay";
> +
> +	pcf2131: rtc@53 {
> +		compatible = "nxp,pcf2131";
> +		reg = <0x53>;
> +		interrupt-parent = <&pcal6524>;
> +		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> +	};
> +};
> +
>  &iomuxc {
>  	pinctrl_eqos: eqosgrp {
>  		fsl,pins = <
> @@ -343,6 +360,13 @@ MX93_PAD_I2C2_SDA__LPI2C2_SDA			0x40000b9e
>  		>;
>  	};
>  
> +	pinctrl_lpi2c3: lpi2c3grp {
> +		fsl,pins = <
> +			MX93_PAD_GPIO_IO28__LPI2C3_SDA			0x40000b9e
> +			MX93_PAD_GPIO_IO29__LPI2C3_SCL			0x40000b9e
> +		>;
> +	};
> +
>  	pinctrl_pcal6524: pcal6524grp {
>  		fsl,pins = <
>  			MX93_PAD_CCM_CLKO2__GPIO3_IO27			0x31e
> -- 
> 2.37.1
> 
> 
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support
@ 2024-04-10  7:40     ` Marco Felsch
  0 siblings, 0 replies; 8+ messages in thread
From: Marco Felsch @ 2024-04-10  7:40 UTC (permalink / raw)
  To: Joy Zou
  Cc: ping.bai, robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo,
	s.hauer, devicetree, imx, linux-kernel, linux-imx, kernel,
	festevam, linux-arm-kernel

On 24-04-10, Joy Zou wrote:
> Support rtc PCF2131 on imx93-11x11-evk.
> 
> Signed-off-by: Joy Zou <joy.zou@nxp.com>
> ---
> Changes in v3:
> 1.adjust the indentation.
> 
> Changes in v2:
> 1. remove unnecessary status property.
> ---
>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> index 07e85a30a25f..73e0bca36b81 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> @@ -281,6 +281,23 @@ ldo5: LDO5 {
>  	};
>  };
>  
> +&lpi2c3 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	clock-frequency = <400000>;
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&pinctrl_lpi2c3>;
> +	pinctrl-1 = <&pinctrl_lpi2c3>;

Are both "default" and "sleep" pinctrl's required? It doesn't make any
sense to provde a sleep state which uses the same pinctrl state.

Regards,
  Marco

> +	status = "okay";
> +
> +	pcf2131: rtc@53 {
> +		compatible = "nxp,pcf2131";
> +		reg = <0x53>;
> +		interrupt-parent = <&pcal6524>;
> +		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
> +	};
> +};
> +
>  &iomuxc {
>  	pinctrl_eqos: eqosgrp {
>  		fsl,pins = <
> @@ -343,6 +360,13 @@ MX93_PAD_I2C2_SDA__LPI2C2_SDA			0x40000b9e
>  		>;
>  	};
>  
> +	pinctrl_lpi2c3: lpi2c3grp {
> +		fsl,pins = <
> +			MX93_PAD_GPIO_IO28__LPI2C3_SDA			0x40000b9e
> +			MX93_PAD_GPIO_IO29__LPI2C3_SCL			0x40000b9e
> +		>;
> +	};
> +
>  	pinctrl_pcal6524: pcal6524grp {
>  		fsl,pins = <
>  			MX93_PAD_CCM_CLKO2__GPIO3_IO27			0x31e
> -- 
> 2.37.1
> 
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* RE: [EXT] Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support
  2024-04-10  7:40     ` Marco Felsch
@ 2024-04-11  6:37       ` Joy Zou
  -1 siblings, 0 replies; 8+ messages in thread
From: Joy Zou @ 2024-04-11  6:37 UTC (permalink / raw)
  To: Marco Felsch
  Cc: Jacky Bai, Frank Li, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, devicetree, imx, linux-kernel, dl-linux-imx,
	kernel, festevam, linux-arm-kernel


> -----Original Message-----
> From: Marco Felsch <m.felsch@pengutronix.de>
> Sent: 2024年4月10日 15:40
> To: Joy Zou <joy.zou@nxp.com>
> Cc: Jacky Bai <ping.bai@nxp.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; devicetree@vger.kernel.org;
> imx@lists.linux.dev; linux-kernel@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; kernel@pengutronix.de; festevam@gmail.com;
> linux-arm-kernel@lists.infradead.org
> Subject: [EXT] Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc
> PCF2131 support
> On 24-04-10, Joy Zou wrote:
> > Support rtc PCF2131 on imx93-11x11-evk.
> >
> > Signed-off-by: Joy Zou <joy.zou@nxp.com>
> > ---
> > Changes in v3:
> > 1.adjust the indentation.
> >
> > Changes in v2:
> > 1. remove unnecessary status property.
> > ---
> >  .../boot/dts/freescale/imx93-11x11-evk.dts    | 24
> +++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > index 07e85a30a25f..73e0bca36b81 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > @@ -281,6 +281,23 @@ ldo5: LDO5 {
> >       };
> >  };
> >
> > +&lpi2c3 {
> > +     #address-cells = <1>;
> > +     #size-cells = <0>;
> > +     clock-frequency = <400000>;
> > +     pinctrl-names = "default", "sleep";
> > +     pinctrl-0 = <&pinctrl_lpi2c3>;
> > +     pinctrl-1 = <&pinctrl_lpi2c3>;
> 
> Are both "default" and "sleep" pinctrl's required? It doesn't make any sense
> to provde a sleep state which uses the same pinctrl state.
Thanks for your comments!
Currently, We only use default. Yeah, It's confused that a sleep state which uses the same pinctrl state.
So will remove the sleep.
BR
Joy Zou
> 
> Regards,
>   Marco
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* RE: [EXT] Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support
@ 2024-04-11  6:37       ` Joy Zou
  0 siblings, 0 replies; 8+ messages in thread
From: Joy Zou @ 2024-04-11  6:37 UTC (permalink / raw)
  To: Marco Felsch
  Cc: Jacky Bai, Frank Li, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	shawnguo, s.hauer, devicetree, imx, linux-kernel, dl-linux-imx,
	kernel, festevam, linux-arm-kernel


> -----Original Message-----
> From: Marco Felsch <m.felsch@pengutronix.de>
> Sent: 2024年4月10日 15:40
> To: Joy Zou <joy.zou@nxp.com>
> Cc: Jacky Bai <ping.bai@nxp.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; devicetree@vger.kernel.org;
> imx@lists.linux.dev; linux-kernel@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; kernel@pengutronix.de; festevam@gmail.com;
> linux-arm-kernel@lists.infradead.org
> Subject: [EXT] Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc
> PCF2131 support
> On 24-04-10, Joy Zou wrote:
> > Support rtc PCF2131 on imx93-11x11-evk.
> >
> > Signed-off-by: Joy Zou <joy.zou@nxp.com>
> > ---
> > Changes in v3:
> > 1.adjust the indentation.
> >
> > Changes in v2:
> > 1. remove unnecessary status property.
> > ---
> >  .../boot/dts/freescale/imx93-11x11-evk.dts    | 24
> +++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > index 07e85a30a25f..73e0bca36b81 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > @@ -281,6 +281,23 @@ ldo5: LDO5 {
> >       };
> >  };
> >
> > +&lpi2c3 {
> > +     #address-cells = <1>;
> > +     #size-cells = <0>;
> > +     clock-frequency = <400000>;
> > +     pinctrl-names = "default", "sleep";
> > +     pinctrl-0 = <&pinctrl_lpi2c3>;
> > +     pinctrl-1 = <&pinctrl_lpi2c3>;
> 
> Are both "default" and "sleep" pinctrl's required? It doesn't make any sense
> to provde a sleep state which uses the same pinctrl state.
Thanks for your comments!
Currently, We only use default. Yeah, It's confused that a sleep state which uses the same pinctrl state.
So will remove the sleep.
BR
Joy Zou
> 
> Regards,
>   Marco
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-04-11  6:38 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-10  7:01 [PATCH v3 0/1] Add rtc PCF2131 support Joy Zou
2024-04-10  7:01 ` Joy Zou
2024-04-10  7:01 ` [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add " Joy Zou
2024-04-10  7:01   ` Joy Zou
2024-04-10  7:40   ` Marco Felsch
2024-04-10  7:40     ` Marco Felsch
2024-04-11  6:37     ` [EXT] " Joy Zou
2024-04-11  6:37       ` Joy Zou

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.