[Buildroot] [PATCH v2 0/3] Add support for the MCF5441x Coldfire

[Buildroot] [PATCH v2 0/3] Add support for the MCF5441x Coldfire

[Jean-Michel Hautbois]

Hi !

I have a custom board which uses a MCF54418 and I want it to use an
upstream buildroot (for all the good reasons ;-)).
From what I can tell the only Coldfire processor currently supported is
the MCF5208 which does not have a MMU.

While trying to add the processor support, I faced an issue during the
host-gcc build when the MMU configuration is selected, because it makes
it compile the multilib part.

Sadly, a commit [1] removed the GCC ARCH configuration which was used to
determine if the architecture is "m68k" or "cf". I have re-introduced
this configuration here, only for the MCF5441x case for now.

Changes in v2:
- Use a more global family than only mcf54418 (as in Linux)
- Add glibc support
- Tested as an external toolchain so far so good

[1]: eda11417be m68k: remove BR2_GCC_TARGET_ARCH

Jean-Michel Hautbois (3):
  arch: add support for mcf5441x Colfdire
  board: add the qemu board support for mcf54418
  package/glibc: enable for coldfire with MMU

 arch/Config.in.m68k                   | 10 ++++++++++
 board/qemu/m68k-mcf54418/linux.config | 23 +++++++++++++++++++++++
 configs/qemu_m68k_mcf5441x_defconfig  | 19 +++++++++++++++++++
 package/glibc/Config.in               |  1 +
 toolchain/Config.in                   |  1 +
 5 files changed, 54 insertions(+)
 create mode 100644 board/qemu/m68k-mcf54418/linux.config
 create mode 100644 configs/qemu_m68k_mcf5441x_defconfig

-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 1/3] arch: add support for mcf5441x Colfdire

[Jean-Michel Hautbois]

The m68k family ony has one Coldfire variant, namely the 5208. Add the
support for the MCF5441x CPU family in the configuration file.
This covers MCF54410, MCF54415, MCF54416, MCF54417 and MCF54418.

Commit [1] removed the GCC ARCH configuration which was used to
determine if the architecture is "m68k" or "cf". I have re-introduced
this configuration here, only for the MCF5441x case. It has been tested
as an external toolchain too.

[1]: eda11417be m68k: remove BR2_GCC_TARGET_ARCH

Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org>
---
 arch/Config.in.m68k | 10 ++++++++++
 toolchain/Config.in |  1 +
 2 files changed, 11 insertions(+)

diff --git a/arch/Config.in.m68k b/arch/Config.in.m68k
index 9fd22aaf1e..c707276e9c 100644
--- a/arch/Config.in.m68k
+++ b/arch/Config.in.m68k
@@ -33,11 +33,21 @@ config BR2_m68k_cf5208
 	select BR2_m68k_cf
 	select BR2_SOFT_FLOAT
 
+config BR2_m68k_cf5441x
+	bool "5441x"
+	select BR2_m68k_cf
+	select BR2_USE_MMU
+	select BR2_SOFT_FLOAT
+
 endchoice
 
 config BR2_GCC_TARGET_CPU
 	default "68040"		if BR2_m68k_68040
 	default "5208"		if BR2_m68k_cf5208
+	default "54455"		if BR2_m68k_cf5441x
+
+config BR2_GCC_TARGET_ARCH
+	default "cf"            if BR2_m68k_cf5441x
 
 config BR2_READELF_ARCH_NAME
 	default "MC68000"
diff --git a/toolchain/Config.in b/toolchain/Config.in
index e8b3db64fb..782b9944d5 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -100,6 +100,7 @@ config BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
 	depends on !BR2_ARM_CPU_ARMV5
 	depends on !BR2_sparc_v8
 	depends on !BR2_m68k_cf5208
+	depends on !BR2_m68k_cf5441x
 
 # GCC uses thunk functions to adjust the 'this' pointer when calling
 # C++ member functions in classes derived with multiple inheritance.
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 2/3] board: add the qemu board support for mcf54418

[Jean-Michel Hautbois]

The Coldfire MCF54418 needs a board to give the proper linux defconfig
to buildroot. Add it based on a simplified Linux stmark2_defconfig file.
While at it, add a the needed config to run qemu, using a copy of the
qemu_m68k_mcf5208_defconfig as there is not so much difference to expect
except the CPU value.

Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org>
---
 board/qemu/m68k-mcf54418/linux.config | 23 +++++++++++++++++++++++
 configs/qemu_m68k_mcf5441x_defconfig  | 19 +++++++++++++++++++
 2 files changed, 42 insertions(+)
 create mode 100644 board/qemu/m68k-mcf54418/linux.config
 create mode 100644 configs/qemu_m68k_mcf5441x_defconfig

diff --git a/board/qemu/m68k-mcf54418/linux.config b/board/qemu/m68k-mcf54418/linux.config
new file mode 100644
index 0000000000..e950052061
--- /dev/null
+++ b/board/qemu/m68k-mcf54418/linux.config
@@ -0,0 +1,23 @@
+CONFIG_COLDFIRE=y
+CONFIG_M5441x=y
+CONFIG_CLOCK_FREQ=240000000
+CONFIG_STMARK2=y
+CONFIG_UBOOT=y
+CONFIG_RAMBASE=0x40000000
+CONFIG_RAMSIZE=0x8000000
+CONFIG_VECTORBASE=0x40000000
+CONFIG_KERNELBASE=0x40001000
+# CONFIG_BLK_DEV_BSG is not set
+CONFIG_BINFMT_FLAT=y
+CONFIG_SERIAL_MCF=y
+CONFIG_SERIAL_MCF_BAUDRATE=115200
+CONFIG_SERIAL_MCF_CONSOLE=y
+CONFIG_BOOTPARAM=y
+CONFIG_BOOTPARAM_STRING="console=ttyS0,115200"
+CONFIG_NET=y
+CONFIG_PACKET=y
+CONFIG_UNIX=y
+CONFIG_INET=y
+CONFIG_NETDEVICES=y
+CONFIG_NET_VENDOR_FREESCALE=y
+CONFIG_FEC=y
diff --git a/configs/qemu_m68k_mcf5441x_defconfig b/configs/qemu_m68k_mcf5441x_defconfig
new file mode 100644
index 0000000000..6b550feb8b
--- /dev/null
+++ b/configs/qemu_m68k_mcf5441x_defconfig
@@ -0,0 +1,19 @@
+BR2_m68k=y
+BR2_m68k_cf5441x=y
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
+BR2_PTHREADS=y
+BR2_STATIC_LIBS=y
+BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
+BR2_SYSTEM_DHCP="eth0"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qemu/post-image.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="$(BR2_DEFCONFIG)"
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1.26"
+BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
+BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/m68k-mcf54418/linux.config"
+BR2_PACKAGE_BUSYBOX_CONFIG="package/busybox/busybox-minimal.config"
+BR2_TARGET_ROOTFS_INITRAMFS=y
+# BR2_TARGET_ROOTFS_TAR is not set
+BR2_PACKAGE_HOST_QEMU=y
+BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE=y
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 3/3] package/glibc: enable for coldfire with MMU

[Jean-Michel Hautbois]

The coldfire m5441x is able to use MMU and we may want to use glibc.
Enable the configuration.

Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org>
---
 package/glibc/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/glibc/Config.in b/package/glibc/Config.in
index 81c64083f4..dec6295716 100644
--- a/package/glibc/Config.in
+++ b/package/glibc/Config.in
@@ -6,6 +6,7 @@ config BR2_PACKAGE_GLIBC_ARCH_SUPPORTS
 	default y if BR2_aarch64_be
 	default y if BR2_i386
 	default y if BR2_m68k_m68k
+	default y if BR2_m68k_cf5441x
 	default y if BR2_mips
 	default y if BR2_mipsel
 	default y if BR2_mips64
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] arch: add support for mcf5441x Colfdire

[Thomas Petazzoni via buildroot]

Hello,

On Wed, 10 Apr 2024 19:12:09 +0200
Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org> wrote:

> The m68k family ony has one Coldfire variant, namely the 5208. Add the
> support for the MCF5441x CPU family in the configuration file.
> This covers MCF54410, MCF54415, MCF54416, MCF54417 and MCF54418.

Interesting. I always thought that Coldfire meant "no MMU" and 68k
meant "MMU", but I was wrong. The family of 68k and coldfire is quite
messy, difficult to find clear and reliable sources of information.

> +config BR2_GCC_TARGET_ARCH
> +	default "cf"            if BR2_m68k_cf5441x

The problem with this is that "cf" is not a valid value for gcc -march=
option. Look at the documentation at:
https://gcc.gnu.org/onlinedocs/gcc-13.2.0/gcc/M680x0-Options.html

The valid values of -march are:

  Permissible values of arch for M680x0 architectures are: ‘68000’,
  ‘68010’, ‘68020’, ‘68030’, ‘68040’, ‘68060’ and ‘cpu32’. ColdFire
  architectures are selected according to Freescale’s ISA classification
  and the permissible values are: ‘isaa’, ‘isaaplus’, ‘isab’ and
  ‘isac’. 

What happens when you don't specify -march? Do you know which of isaa,
isaaplus, isab and isac the MCF5441x corresponds to?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] arch: add support for mcf5441x Colfdire

[Jean-Michel Hautbois]

Hi Thomas,

On 10/04/2024 21:56, Thomas Petazzoni via buildroot wrote:
> Hello,
> 
> On Wed, 10 Apr 2024 19:12:09 +0200
> Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org> wrote:
> 
>> The m68k family ony has one Coldfire variant, namely the 5208. Add the
>> support for the MCF5441x CPU family in the configuration file.
>> This covers MCF54410, MCF54415, MCF54416, MCF54417 and MCF54418.
> 
> Interesting. I always thought that Coldfire meant "no MMU" and 68k
> meant "MMU", but I was wrong. The family of 68k and coldfire is quite
> messy, difficult to find clear and reliable sources of information.

Indeed, it *is* a mess :-).

> 
>> +config BR2_GCC_TARGET_ARCH
>> +	default "cf"            if BR2_m68k_cf5441x
> 
> The problem with this is that "cf" is not a valid value for gcc -march=
> option. Look at the documentation at:
> https://gcc.gnu.org/onlinedocs/gcc-13.2.0/gcc/M680x0-Options.html
> 
> The valid values of -march are:
> 
>    Permissible values of arch for M680x0 architectures are: ‘68000’,
>    ‘68010’, ‘68020’, ‘68030’, ‘68040’, ‘68060’ and ‘cpu32’. ColdFire
>    architectures are selected according to Freescale’s ISA classification
>    and the permissible values are: ‘isaa’, ‘isaaplus’, ‘isab’ and
>    ‘isac’.
> 
> What happens when you don't specify -march? Do you know which of isaa,
> isaaplus, isab and isac the MCF5441x corresponds to?

I did not check what happens, but based on the following file it is isac:
https://github.com/gcc-mirror/gcc/blob/master/gcc/config/m68k/m68k-devices.def#L168

JM

> 
> Best regards,
> 
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] arch: add support for mcf5441x Colfdire

[Thomas Petazzoni via buildroot]

On Wed, 10 Apr 2024 23:08:14 +0200
Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org> wrote:

> > What happens when you don't specify -march? Do you know which of isaa,
> > isaaplus, isab and isac the MCF5441x corresponds to?  
> 
> I did not check what happens, but based on the following file it is isac:
> https://github.com/gcc-mirror/gcc/blob/master/gcc/config/m68k/m68k-devices.def#L168

And if you specify -mcpu instead, does it work? What doesn't work if
you omit -march?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] arch: add support for mcf5441x Colfdire

[Jean-Michel Hautbois]

On 10/04/2024 23:17, Thomas Petazzoni via buildroot wrote:
> On Wed, 10 Apr 2024 23:08:14 +0200
> Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org> wrote:
> 
>>> What happens when you don't specify -march? Do you know which of isaa,
>>> isaaplus, isab and isac the MCF5441x corresponds to?
>>
>> I did not check what happens, but based on the following file it is isac:
>> https://github.com/gcc-mirror/gcc/blob/master/gcc/config/m68k/m68k-devices.def#L168
> 
> And if you specify -mcpu instead, does it work? What doesn't work if
> you omit -march?

If I change the line to pass isac, host-gcc-final doest not build at all:
<snip>
checking if mkdir takes one argument... no
Invalid --with-arch=isac
make[3]: *** [Makefile:4553: configure-gcc] Error 1
make[2]: *** [Makefile:1029: all] Error 2
make[1]: *** [package/pkg-generic.mk:283: 
/home/jm/Projects/wabtec/buildroot/output/build/host-gcc-final-12.3.0/.stamp_built] 
Error 2

As I am not as experimented as you with toolchains, I would certainly 
appreciate some guidance to debug if needed.

I can tell for sure that with "cf" and the 54455 family specified, it 
builds my applications ;-).

JM
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/3] arch: add support for mcf5441x Colfdire

[Jean-Michel Hautbois]

Hello,

On 11/04/2024 07:59, Jean-Michel Hautbois wrote:
> On 10/04/2024 23:17, Thomas Petazzoni via buildroot wrote:
>> On Wed, 10 Apr 2024 23:08:14 +0200
>> Jean-Michel Hautbois <jeanmichel.hautbois@yoseli.org> wrote:
>>
>>>> What happens when you don't specify -march? Do you know which of isaa,
>>>> isaaplus, isab and isac the MCF5441x corresponds to?
>>>
>>> I did not check what happens, but based on the following file it is 
>>> isac:
>>> https://github.com/gcc-mirror/gcc/blob/master/gcc/config/m68k/m68k-devices.def#L168
>>
>> And if you specify -mcpu instead, does it work? What doesn't work if
>> you omit -march?
> 
> If I change the line to pass isac, host-gcc-final doest not build at all:
> <snip>
> checking if mkdir takes one argument... no
> Invalid --with-arch=isac
> make[3]: *** [Makefile:4553: configure-gcc] Error 1
> make[2]: *** [Makefile:1029: all] Error 2
> make[1]: *** [package/pkg-generic.mk:283: 
> /home/jm/Projects/wabtec/buildroot/output/build/host-gcc-final-12.3.0/.stamp_built] Error 2
> 
> As I am not as experimented as you with toolchains, I would certainly 
> appreciate some guidance to debug if needed.
> 
> I can tell for sure that with "cf" and the 54455 family specified, it 
> builds my applications ;-).

Small update:
I have to add the following patch in package/gcc/12.3.0 to make it use 
the march="isac".

diff --git a/gcc/config.gcc b/gcc/config.gcc
index 5c378c698ff..a6fe9c2ad53 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -4522,7 +4522,7 @@ case "${target}" in
         fido-*-* | m68k*-*-*)
                 supported_defaults="arch cpu"
                 case "$with_arch" in
-               "" | "m68k"| "cf")
+               "" | "m68k"| "cf" | "isac")
                         m68k_arch_family="$with_arch"
                         ;;
                 *)

JM

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot