* [PATCH v4] Bluetooth: btusb: Add USB HWID to usb_device_id table for Acer NB
@ 2024-04-12 6:43 Jiande Lu
2024-04-12 7:32 ` Paul Menzel
2024-04-12 7:33 ` [v4] " bluez.test.bot
0 siblings, 2 replies; 3+ messages in thread
From: Jiande Lu @ 2024-04-12 6:43 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Luiz Von Dentz
Cc: Sean Wang, Chris Lu, Deren Wu, Aaron Hou, Steve Lee,
linux-bluetooth, linux-kernel, linux-mediatek, jiande.lu
From: "jiande.lu" <jiande.lu@mediatek.com>
This commit add HWID for wireless modules specific to Acer
notebook models to ensure proper recongnition and functionality
Https://acer.com/tw-zh/support/product-support/
SFE16-42/NX.KH5TA.0.01/downloads
Signed-off-by: jiande.lu <jiande.lu@mediatek.com>
---
v4: Update title
---
v3: Fix patch fail
---
v2: Update commit description and fix typo
---
---
drivers/bluetooth/btusb.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index c391e612b83b..b71efca2af73 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -616,6 +616,9 @@ static const struct usb_device_id quirks_table[] = {
{ USB_DEVICE(0x0e8d, 0x0608), .driver_info = BTUSB_MEDIATEK |
BTUSB_WIDEBAND_SPEECH |
BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x13d3, 0x3606), .driver_info = BTUSB_MEDIATEK |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
/* MediaTek MT7922 Bluetooth devices */
{ USB_DEVICE(0x13d3, 0x3585), .driver_info = BTUSB_MEDIATEK |
@@ -662,11 +665,32 @@ static const struct usb_device_id quirks_table[] = {
{ USB_DEVICE(0x35f5, 0x7922), .driver_info = BTUSB_MEDIATEK |
BTUSB_WIDEBAND_SPEECH |
BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x13d3, 0x3614), .driver_info = BTUSB_MEDIATEK |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x13d3, 0x3615), .driver_info = BTUSB_MEDIATEK |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x04ca, 0x38e4), .driver_info = BTUSB_MEDIATEK |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x13d3, 0x3605), .driver_info = BTUSB_MEDIATEK |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x13d3, 0x3607), .driver_info = BTUSB_MEDIATEK |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
/* Additional MediaTek MT7925 Bluetooth devices */
+ { USB_DEVICE(0x0489, 0xE113), .driver_info = BTUSB_MEDIATEK |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
{ USB_DEVICE(0x13d3, 0x3602), .driver_info = BTUSB_MEDIATEK |
BTUSB_WIDEBAND_SPEECH |
BTUSB_VALID_LE_STATES },
+ { USB_DEVICE(0x13d3, 0x3603), .driver_info = BTUSB_MEDIATEK |
+ BTUSB_WIDEBAND_SPEECH |
+ BTUSB_VALID_LE_STATES },
/* Additional Realtek 8723AE Bluetooth devices */
{ USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4] Bluetooth: btusb: Add USB HWID to usb_device_id table for Acer NB
2024-04-12 6:43 [PATCH v4] Bluetooth: btusb: Add USB HWID to usb_device_id table for Acer NB Jiande Lu
@ 2024-04-12 7:32 ` Paul Menzel
2024-04-12 7:33 ` [v4] " bluez.test.bot
1 sibling, 0 replies; 3+ messages in thread
From: Paul Menzel @ 2024-04-12 7:32 UTC (permalink / raw)
To: Jiande Lu
Cc: Marcel Holtmann, Johan Hedberg, Luiz Von Dentz, Sean Wang,
Chris Lu, Deren Wu, Aaron Hou, Steve Lee, linux-bluetooth,
linux-kernel, linux-mediatek
Dear Jiande,
Thank you for your patches. Some minor comments from side.
Am 12.04.24 um 08:43 schrieb Jiande Lu:
> From: "jiande.lu" <jiande.lu@mediatek.com>
I’d spell your name Jiande Lu:
$ git config --global user.name "Jiande Lu"
$ git commit --amend -s --author="Jiande Lu <jiande.lu@mediatek.com>"
For the commit message summary/title, I’d use:
Bluetooth: btusb: Add USB HW ids for MT7921/MT7922/MT7925
> This commit add HWID for wireless modules specific to Acer
This commit add*s* is redundant. Just use imperative mood: Add HW ids for …
> notebook models to ensure proper recongnition and functionality
recognition
>
> Https://acer.com/tw-zh/support/product-support/
> SFE16-42/NX.KH5TA.0.01/downloads
Please put it in one line and spell the schema https:// all lowercase.
It’d be great if you listed the models in the commit message too, and
mentioned, on what device you tested your change.
> Signed-off-by: jiande.lu <jiande.lu@mediatek.com>
> ---
> v4: Update title
> ---
> v3: Fix patch fail
> ---
> v2: Update commit description and fix typo
> ---
> ---
> drivers/bluetooth/btusb.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index c391e612b83b..b71efca2af73 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -616,6 +616,9 @@ static const struct usb_device_id quirks_table[] = {
> { USB_DEVICE(0x0e8d, 0x0608), .driver_info = BTUSB_MEDIATEK |
> BTUSB_WIDEBAND_SPEECH |
> BTUSB_VALID_LE_STATES },
> + { USB_DEVICE(0x13d3, 0x3606), .driver_info = BTUSB_MEDIATEK |
> + BTUSB_WIDEBAND_SPEECH |
> + BTUSB_VALID_LE_STATES },
Unfortunately, these entries are not sorted by the id. Can you please
send a follow-up patch to sort the ids in these sections?
> /* MediaTek MT7922 Bluetooth devices */
> { USB_DEVICE(0x13d3, 0x3585), .driver_info = BTUSB_MEDIATEK |
> @@ -662,11 +665,32 @@ static const struct usb_device_id quirks_table[] = {
> { USB_DEVICE(0x35f5, 0x7922), .driver_info = BTUSB_MEDIATEK |
> BTUSB_WIDEBAND_SPEECH |
> BTUSB_VALID_LE_STATES },
> + { USB_DEVICE(0x13d3, 0x3614), .driver_info = BTUSB_MEDIATEK |
> + BTUSB_WIDEBAND_SPEECH |
> + BTUSB_VALID_LE_STATES },
> + { USB_DEVICE(0x13d3, 0x3615), .driver_info = BTUSB_MEDIATEK |
> + BTUSB_WIDEBAND_SPEECH |
> + BTUSB_VALID_LE_STATES },
> + { USB_DEVICE(0x04ca, 0x38e4), .driver_info = BTUSB_MEDIATEK |
> + BTUSB_WIDEBAND_SPEECH |
> + BTUSB_VALID_LE_STATES },
> + { USB_DEVICE(0x13d3, 0x3605), .driver_info = BTUSB_MEDIATEK |
> + BTUSB_WIDEBAND_SPEECH |
> + BTUSB_VALID_LE_STATES },
> + { USB_DEVICE(0x13d3, 0x3607), .driver_info = BTUSB_MEDIATEK |
> + BTUSB_WIDEBAND_SPEECH |
> + BTUSB_VALID_LE_STATES },
Please sort the entries.
> /* Additional MediaTek MT7925 Bluetooth devices */
> + { USB_DEVICE(0x0489, 0xE113), .driver_info = BTUSB_MEDIATEK |
> + BTUSB_WIDEBAND_SPEECH |
> + BTUSB_VALID_LE_STATES },
Lowercase: 0xe113
> { USB_DEVICE(0x13d3, 0x3602), .driver_info = BTUSB_MEDIATEK |
> BTUSB_WIDEBAND_SPEECH |
> BTUSB_VALID_LE_STATES },
> + { USB_DEVICE(0x13d3, 0x3603), .driver_info = BTUSB_MEDIATEK |
> + BTUSB_WIDEBAND_SPEECH |
> + BTUSB_VALID_LE_STATES },
>
> /* Additional Realtek 8723AE Bluetooth devices */
> { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },
Kind regards,
Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [v4] Bluetooth: btusb: Add USB HWID to usb_device_id table for Acer NB
2024-04-12 6:43 [PATCH v4] Bluetooth: btusb: Add USB HWID to usb_device_id table for Acer NB Jiande Lu
2024-04-12 7:32 ` Paul Menzel
@ 2024-04-12 7:33 ` bluez.test.bot
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2024-04-12 7:33 UTC (permalink / raw)
To: linux-bluetooth, jiande.lu
[-- Attachment #1: Type: text/plain, Size: 2829 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=843875
---Test result---
Test Summary:
CheckPatch PASS 0.65 seconds
GitLint PASS 0.30 seconds
SubjectPrefix PASS 0.11 seconds
BuildKernel PASS 29.94 seconds
CheckAllWarning PASS 32.78 seconds
CheckSparse PASS 38.17 seconds
CheckSmatch FAIL 36.20 seconds
BuildKernel32 PASS 29.45 seconds
TestRunnerSetup PASS 524.89 seconds
TestRunner_l2cap-tester PASS 18.50 seconds
TestRunner_iso-tester PASS 31.04 seconds
TestRunner_bnep-tester PASS 4.83 seconds
TestRunner_mgmt-tester FAIL 112.29 seconds
TestRunner_rfcomm-tester PASS 7.47 seconds
TestRunner_sco-tester PASS 15.17 seconds
TestRunner_ioctl-tester PASS 7.82 seconds
TestRunner_mesh-tester PASS 5.94 seconds
TestRunner_smp-tester PASS 6.87 seconds
TestRunner_userchan-tester PASS 5.06 seconds
IncrementalBuild PASS 27.79 seconds
Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bpa10x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bpa10x.o'
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 488 (99.2%), Failed: 2, Not Run: 2
Failed Test Cases
Pairing Acceptor - SMP over BR/EDR 1 Timed out 2.486 seconds
LL Privacy - Start Discovery 2 (Disable RL) Failed 0.170 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-12 7:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-12 6:43 [PATCH v4] Bluetooth: btusb: Add USB HWID to usb_device_id table for Acer NB Jiande Lu
2024-04-12 7:32 ` Paul Menzel
2024-04-12 7:33 ` [v4] " bluez.test.bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.