[jfern:sched/dlserver.update_h_nr 1/1] kernel/sched/fair.c:5830:13: warning: conflicting types for 'update_h_nr_running'

[jfern:sched/dlserver.update_h_nr 1/1] kernel/sched/fair.c:5830:13: warning: conflicting types for 'update_h_nr_running'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git sched/dlserver.update_h_nr
head:   4e843586ff1b3b77e5244d0128facac6330490a4
commit: 4e843586ff1b3b77e5244d0128facac6330490a4 [1/1] Prototype: Update h_nr_running from single place to stop/start dl server
config: i386-buildonly-randconfig-002-20240419 (https://download.01.org/0day-ci/archive/20240419/202404191626.lIcJ0YDM-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240419/202404191626.lIcJ0YDM-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404191626.lIcJ0YDM-lkp@intel.com/

All warnings (new ones prefixed by >>):

   kernel/sched/fair.c: In function 'update_curr_se':
   kernel/sched/fair.c:845:28: warning: variable 'stats' set but not used [-Wunused-but-set-variable]
     845 |   struct sched_statistics *stats;
         |                            ^~~~~
   kernel/sched/fair.c: In function 'update_stats_wait_start':
   kernel/sched/fair.c:922:27: warning: variable 'stats' set but not used [-Wunused-but-set-variable]
     922 |  struct sched_statistics *stats;
         |                           ^~~~~
   kernel/sched/fair.c: In function 'update_stats_wait_end':
   kernel/sched/fair.c:942:27: warning: variable 'stats' set but not used [-Wunused-but-set-variable]
     942 |  struct sched_statistics *stats;
         |                           ^~~~~
   kernel/sched/fair.c: In function 'update_stats_enqueue_sleeper':
   kernel/sched/fair.c:986:27: warning: variable 'stats' set but not used [-Wunused-but-set-variable]
     986 |  struct sched_statistics *stats;
         |                           ^~~~~
   kernel/sched/fair.c: In function 'set_next_entity':
   kernel/sched/fair.c:4742:28: warning: variable 'stats' set but not used [-Wunused-but-set-variable]
    4742 |   struct sched_statistics *stats;
         |                            ^~~~~
   kernel/sched/fair.c: In function 'throttle_cfs_rq':
   kernel/sched/fair.c:5119:3: error: implicit declaration of function 'update_h_nr_running' [-Werror=implicit-function-declaration]
    5119 |   update_h_nr_running(qcfs_rq, -1 * task_delta);
         |   ^~~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c: At top level:
>> kernel/sched/fair.c:5830:13: warning: conflicting types for 'update_h_nr_running'
    5830 | static void update_h_nr_running(struct cfs_rq *cfs_rq, int delta)
         |             ^~~~~~~~~~~~~~~~~~~
   kernel/sched/fair.c:5830:13: error: static declaration of 'update_h_nr_running' follows non-static declaration
   kernel/sched/fair.c:5119:3: note: previous implicit declaration of 'update_h_nr_running' was here
    5119 |   update_h_nr_running(qcfs_rq, -1 * task_delta);
         |   ^~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/update_h_nr_running +5830 kernel/sched/fair.c

  5829	
> 5830	static void update_h_nr_running(struct cfs_rq *cfs_rq, int delta)
  5831	{
  5832		int old_h_nr_running, new_h_nr_running;
  5833		bool root = (&rq_of(cfs_rq)->cfs == cfs_rq);
  5834		
  5835		if (root) {
  5836			old_h_nr_running = cfs_rq->h_nr_running;
  5837		}
  5838	
  5839		new_h_nr_running = cfs_rq->h_nr_running + delta;
  5840		cfs_rq->h_nr_running = new_h_nr_running;
  5841		
  5842		if (root && !!old_h_nr_running != !!new_h_nr_running) {
  5843			if (new_h_nr_running) {
  5844				dl_server_start(&rq_of(cfs_rq)->fair_server);
  5845			} else {
  5846				dl_server_stop(&rq_of(cfs_rq)->fair_server);
  5847			}
  5848		}
  5849	}
  5850	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki