All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org
Subject: [PATCH v2 08/11] ntfs3: Remove calls to set/clear the error flag
Date: Mon, 22 Apr 2024 20:31:58 +0100	[thread overview]
Message-ID: <20240422193203.3534108-9-willy@infradead.org> (raw)
In-Reply-To: <20240422193203.3534108-1-willy@infradead.org>

Nobody checks the error flag on ntfs3 folios, so stop setting and
clearing it.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 fs/ntfs3/frecord.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
index 0008670939a4..04a7509c749a 100644
--- a/fs/ntfs3/frecord.c
+++ b/fs/ntfs3/frecord.c
@@ -2143,9 +2143,6 @@ int ni_readpage_cmpr(struct ntfs_inode *ni, struct page *page)
 	err = ni_read_frame(ni, frame_vbo, pages, pages_per_frame);
 
 out1:
-	if (err)
-		SetPageError(page);
-
 	for (i = 0; i < pages_per_frame; i++) {
 		pg = pages[i];
 		if (i == idx || !pg)
@@ -2718,7 +2715,6 @@ int ni_read_frame(struct ntfs_inode *ni, u64 frame_vbo, struct page **pages,
 	for (i = 0; i < pages_per_frame; i++) {
 		pg = pages[i];
 		kunmap(pg);
-		ClearPageError(pg);
 		SetPageUptodate(pg);
 	}
 
-- 
2.43.0


  parent reply	other threads:[~2024-04-22 19:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22 19:31 [PATCH v2 00/11] Convert (most of) ntfs3 to use folios Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 01/11] ntfs3: Convert ntfs_read_folio to use a folio Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 02/11] ntfs3: Convert ntfs_write_begin " Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 03/11] ntfs3: Convert attr_data_read_resident() to take " Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 04/11] ntfs3: Convert ntfs_write_end() to work on " Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 05/11] ntfs3: Convert attr_data_write_resident to use " Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 06/11] ntfs3: Convert attr_make_nonresident " Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 07/11] ntfs3: Convert inode_read_data() to use folios Matthew Wilcox (Oracle)
2024-04-22 19:31 ` Matthew Wilcox (Oracle) [this message]
2024-04-22 19:31 ` [PATCH v2 09/11] ntfs3: Convert attr_wof_frame_info() to use a folio Matthew Wilcox (Oracle)
2024-04-22 19:32 ` [PATCH v2 10/11] ntfs3: Convert ntfs_get_frame_pages() " Matthew Wilcox (Oracle)
2024-04-22 19:32 ` [PATCH v2 11/11] ntfs3: Convert ni_readpage_cmpr() to take " Matthew Wilcox (Oracle)
2024-04-23 14:51 ` [PATCH v2 00/11] Convert (most of) ntfs3 to use folios Konstantin Komarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240422193203.3534108-9-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.