All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: <ntfs3@lists.linux.dev>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2 00/11] Convert (most of) ntfs3 to use folios
Date: Tue, 23 Apr 2024 17:51:23 +0300	[thread overview]
Message-ID: <85317479-4f03-4896-a2e1-d16b912e8b91@paragon-software.com> (raw)
In-Reply-To: <20240422193203.3534108-1-willy@infradead.org>

On 22.04.2024 22:31, Matthew Wilcox (Oracle) wrote:
> I'm not making any attempt here to support large folios.  This is just
> to remove uses of the page-based APIs.  There are still a number of
> places in ntfs3 which use a struct page, but this is a good start on
> the conversions.
>
> v2:
>   - Rebase on next-20240422
>   - Drop "Convert reading $AttrDef to use folios", "Use a folio to read
>     UpCase", "Remove inode_write_data()" and "Remove ntfs_map_page and
>     ntfs_unmap_page" due to changes.
>   - Add "Convert inode_read_data() to use folios", "Remove calls to
>     set/clear the error flag", "Convert attr_wof_frame_info() to use a
>     folio", "Convert ntfs_get_frame_pages() to use a folio", "Convert
>     ni_readpage_cmpr() to take a folio"
>
> Matthew Wilcox (Oracle) (11):
>    ntfs3: Convert ntfs_read_folio to use a folio
>    ntfs3: Convert ntfs_write_begin to use a folio
>    ntfs3: Convert attr_data_read_resident() to take a folio
>    ntfs3: Convert ntfs_write_end() to work on a folio
>    ntfs3: Convert attr_data_write_resident to use a folio
>    ntfs3: Convert attr_make_nonresident to use a folio
>    ntfs3: Convert inode_read_data() to use folios
>    ntfs3: Remove calls to set/clear the error flag
>    ntfs3: Convert attr_wof_frame_info() to use a folio
>    ntfs3: Convert ntfs_get_frame_pages() to use a folio
>    ntfs3: Convert ni_readpage_cmpr() to take a folio
>
>   fs/ntfs3/attrib.c  | 94 ++++++++++++++++++++--------------------------
>   fs/ntfs3/file.c    | 17 +++++----
>   fs/ntfs3/frecord.c | 29 +++++++-------
>   fs/ntfs3/inode.c   | 73 ++++++++++++++++++-----------------
>   fs/ntfs3/ntfs_fs.h |  8 ++--
>   5 files changed, 102 insertions(+), 119 deletions(-)
>
Hi Matthew,

We have started testing the switch to folio as you proposed in v1.
Some of our tests went down.

After adapting I will add your patches with some minor changes.


      parent reply	other threads:[~2024-04-23 14:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22 19:31 [PATCH v2 00/11] Convert (most of) ntfs3 to use folios Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 01/11] ntfs3: Convert ntfs_read_folio to use a folio Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 02/11] ntfs3: Convert ntfs_write_begin " Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 03/11] ntfs3: Convert attr_data_read_resident() to take " Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 04/11] ntfs3: Convert ntfs_write_end() to work on " Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 05/11] ntfs3: Convert attr_data_write_resident to use " Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 06/11] ntfs3: Convert attr_make_nonresident " Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 07/11] ntfs3: Convert inode_read_data() to use folios Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 08/11] ntfs3: Remove calls to set/clear the error flag Matthew Wilcox (Oracle)
2024-04-22 19:31 ` [PATCH v2 09/11] ntfs3: Convert attr_wof_frame_info() to use a folio Matthew Wilcox (Oracle)
2024-04-22 19:32 ` [PATCH v2 10/11] ntfs3: Convert ntfs_get_frame_pages() " Matthew Wilcox (Oracle)
2024-04-22 19:32 ` [PATCH v2 11/11] ntfs3: Convert ni_readpage_cmpr() to take " Matthew Wilcox (Oracle)
2024-04-23 14:51 ` Konstantin Komarov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85317479-4f03-4896-a2e1-d16b912e8b91@paragon-software.com \
    --to=almaz.alexandrovich@paragon-software.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.