* [PATCH -next] cgroup/cpuset: Remove outdated comment in sched_partition_write()
@ 2024-04-25 9:30 Xiu Jianfeng
2024-04-25 12:24 ` Waiman Long
2024-04-25 17:17 ` Tejun Heo
0 siblings, 2 replies; 3+ messages in thread
From: Xiu Jianfeng @ 2024-04-25 9:30 UTC (permalink / raw)
To: longman, lizefan.x, tj, hannes; +Cc: cgroups, linux-kernel
The comment here is outdated and can cause confusion, from the code
perspective, there’s also no need for new comment, so just remove it.
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
kernel/cgroup/cpuset.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index f5443c039619..a10e4bd0c0c1 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -3774,9 +3774,6 @@ static ssize_t sched_partition_write(struct kernfs_open_file *of, char *buf,
buf = strstrip(buf);
- /*
- * Convert "root" to ENABLED, and convert "member" to DISABLED.
- */
if (!strcmp(buf, "root"))
val = PRS_ROOT;
else if (!strcmp(buf, "member"))
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] cgroup/cpuset: Remove outdated comment in sched_partition_write()
2024-04-25 9:30 [PATCH -next] cgroup/cpuset: Remove outdated comment in sched_partition_write() Xiu Jianfeng
@ 2024-04-25 12:24 ` Waiman Long
2024-04-25 17:17 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Waiman Long @ 2024-04-25 12:24 UTC (permalink / raw)
To: Xiu Jianfeng, lizefan.x, tj, hannes; +Cc: cgroups, linux-kernel
On 4/25/24 05:30, Xiu Jianfeng wrote:
> The comment here is outdated and can cause confusion, from the code
> perspective, there’s also no need for new comment, so just remove it.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
> kernel/cgroup/cpuset.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index f5443c039619..a10e4bd0c0c1 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -3774,9 +3774,6 @@ static ssize_t sched_partition_write(struct kernfs_open_file *of, char *buf,
>
> buf = strstrip(buf);
>
> - /*
> - * Convert "root" to ENABLED, and convert "member" to DISABLED.
> - */
> if (!strcmp(buf, "root"))
> val = PRS_ROOT;
> else if (!strcmp(buf, "member"))
Yes, that comment is now no longer relevant.
Acked-by: Waiman Long <longman@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] cgroup/cpuset: Remove outdated comment in sched_partition_write()
2024-04-25 9:30 [PATCH -next] cgroup/cpuset: Remove outdated comment in sched_partition_write() Xiu Jianfeng
2024-04-25 12:24 ` Waiman Long
@ 2024-04-25 17:17 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2024-04-25 17:17 UTC (permalink / raw)
To: Xiu Jianfeng; +Cc: longman, lizefan.x, hannes, cgroups, linux-kernel
On Thu, Apr 25, 2024 at 09:30:16AM +0000, Xiu Jianfeng wrote:
> The comment here is outdated and can cause confusion, from the code
> perspective, there’s also no need for new comment, so just remove it.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Applied to cgroup/for-6.10.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-25 17:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-25 9:30 [PATCH -next] cgroup/cpuset: Remove outdated comment in sched_partition_write() Xiu Jianfeng
2024-04-25 12:24 ` Waiman Long
2024-04-25 17:17 ` Tejun Heo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.