* [PATCH v2 0/1] stubs: Add missing qga stubs
@ 2024-04-26 12:13 Konstantin Kostiuk
2024-04-26 12:13 ` [PATCH v2 1/1] " Konstantin Kostiuk
0 siblings, 1 reply; 4+ messages in thread
From: Konstantin Kostiuk @ 2024-04-26 12:13 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé,
Paolo Bonzini, Alex Bennée, Thomas Huth
v1 -> v2:
- Added the link failure output
Konstantin Kostiuk (1):
stubs: Add missing qga stubs
stubs/meson.build | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
--
2.44.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/1] stubs: Add missing qga stubs
2024-04-26 12:13 [PATCH v2 0/1] stubs: Add missing qga stubs Konstantin Kostiuk
@ 2024-04-26 12:13 ` Konstantin Kostiuk
2024-04-29 10:09 ` Konstantin Kostiuk
0 siblings, 1 reply; 4+ messages in thread
From: Konstantin Kostiuk @ 2024-04-26 12:13 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé,
Paolo Bonzini, Alex Bennée, Thomas Huth
Compilation QGA without system and user fails
./configure --disable-system --disable-user --enable-guest-agent
Link failure:
/usr/bin/ld: libqemuutil.a.p/util_main-loop.c.o: in function
`os_host_main_loop_wait':
../util/main-loop.c:303: undefined reference to `replay_mutex_unlock'
/usr/bin/ld: ../util/main-loop.c:307: undefined reference to
`replay_mutex_lock'
/usr/bin/ld: libqemuutil.a.p/util_error-report.c.o: in function
`error_printf':
../util/error-report.c:38: undefined reference to `error_vprintf'
/usr/bin/ld: libqemuutil.a.p/util_error-report.c.o: in function
`vreport':
../util/error-report.c:225: undefined reference to `error_vprintf'
/usr/bin/ld: libqemuutil.a.p/util_qemu-timer.c.o: in function
`timerlist_run_timers':
../util/qemu-timer.c:562: undefined reference to `replay_checkpoint'
/usr/bin/ld: ../util/qemu-timer.c:530: undefined reference to
`replay_checkpoint'
/usr/bin/ld: ../util/qemu-timer.c:525: undefined reference to
`replay_checkpoint'
ninja: build stopped: subcommand failed.
Fixes: 3a15604900 ("stubs: include stubs only if needed")
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
---
stubs/meson.build | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/stubs/meson.build b/stubs/meson.build
index 8ee1fd5753..3b9d42023c 100644
--- a/stubs/meson.build
+++ b/stubs/meson.build
@@ -21,12 +21,12 @@ if have_block
stub_ss.add(files('migr-blocker.c'))
stub_ss.add(files('physmem.c'))
stub_ss.add(files('ram-block.c'))
- stub_ss.add(files('replay-tools.c'))
stub_ss.add(files('runstate-check.c'))
stub_ss.add(files('uuid.c'))
endif
if have_block or have_ga
+ stub_ss.add(files('replay-tools.c'))
# stubs for hooks in util/main-loop.c, util/async.c etc.
stub_ss.add(files('cpus-get-virtual-clock.c'))
stub_ss.add(files('icount.c'))
@@ -45,6 +45,10 @@ if have_block or have_ga
stub_ss.add(files('qmp-quit.c'))
endif
+if have_ga
+ stub_ss.add(files('error-printf.c'))
+endif
+
if have_block or have_user
stub_ss.add(files('qtest.c'))
stub_ss.add(files('vm-stop.c'))
--
2.44.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] stubs: Add missing qga stubs
2024-04-26 12:13 ` [PATCH v2 1/1] " Konstantin Kostiuk
@ 2024-04-29 10:09 ` Konstantin Kostiuk
2024-04-29 10:37 ` Thomas Huth
0 siblings, 1 reply; 4+ messages in thread
From: Konstantin Kostiuk @ 2024-04-29 10:09 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Philippe Mathieu-Daudé, Alex Bennée, qemu-devel, Thomas Huth
[-- Attachment #1: Type: text/plain, Size: 2672 bytes --]
Hi Paolo,
Are you ok if I merge this patch with other QGA patches?
Or don't you agree with this version of the patch?
Best Regards,
Konstantin Kostiuk.
On Fri, Apr 26, 2024 at 3:15 PM Konstantin Kostiuk <kkostiuk@redhat.com>
wrote:
> Compilation QGA without system and user fails
> ./configure --disable-system --disable-user --enable-guest-agent
>
> Link failure:
> /usr/bin/ld: libqemuutil.a.p/util_main-loop.c.o: in function
> `os_host_main_loop_wait':
> ../util/main-loop.c:303: undefined reference to `replay_mutex_unlock'
> /usr/bin/ld: ../util/main-loop.c:307: undefined reference to
> `replay_mutex_lock'
> /usr/bin/ld: libqemuutil.a.p/util_error-report.c.o: in function
> `error_printf':
> ../util/error-report.c:38: undefined reference to `error_vprintf'
> /usr/bin/ld: libqemuutil.a.p/util_error-report.c.o: in function
> `vreport':
> ../util/error-report.c:225: undefined reference to `error_vprintf'
> /usr/bin/ld: libqemuutil.a.p/util_qemu-timer.c.o: in function
> `timerlist_run_timers':
> ../util/qemu-timer.c:562: undefined reference to `replay_checkpoint'
> /usr/bin/ld: ../util/qemu-timer.c:530: undefined reference to
> `replay_checkpoint'
> /usr/bin/ld: ../util/qemu-timer.c:525: undefined reference to
> `replay_checkpoint'
> ninja: build stopped: subcommand failed.
>
> Fixes: 3a15604900 ("stubs: include stubs only if needed")
>
> Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> ---
> stubs/meson.build | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/stubs/meson.build b/stubs/meson.build
> index 8ee1fd5753..3b9d42023c 100644
> --- a/stubs/meson.build
> +++ b/stubs/meson.build
> @@ -21,12 +21,12 @@ if have_block
> stub_ss.add(files('migr-blocker.c'))
> stub_ss.add(files('physmem.c'))
> stub_ss.add(files('ram-block.c'))
> - stub_ss.add(files('replay-tools.c'))
> stub_ss.add(files('runstate-check.c'))
> stub_ss.add(files('uuid.c'))
> endif
>
> if have_block or have_ga
> + stub_ss.add(files('replay-tools.c'))
> # stubs for hooks in util/main-loop.c, util/async.c etc.
> stub_ss.add(files('cpus-get-virtual-clock.c'))
> stub_ss.add(files('icount.c'))
> @@ -45,6 +45,10 @@ if have_block or have_ga
> stub_ss.add(files('qmp-quit.c'))
> endif
>
> +if have_ga
> + stub_ss.add(files('error-printf.c'))
> +endif
> +
> if have_block or have_user
> stub_ss.add(files('qtest.c'))
> stub_ss.add(files('vm-stop.c'))
> --
> 2.44.0
>
>
>
[-- Attachment #2: Type: text/html, Size: 3682 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/1] stubs: Add missing qga stubs
2024-04-29 10:09 ` Konstantin Kostiuk
@ 2024-04-29 10:37 ` Thomas Huth
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2024-04-29 10:37 UTC (permalink / raw)
To: Konstantin Kostiuk, Paolo Bonzini
Cc: Philippe Mathieu-Daudé, Alex Bennée, qemu-devel
On 29/04/2024 12.09, Konstantin Kostiuk wrote:
> Hi Paolo,
>
> Are you ok if I merge this patch with other QGA patches?
> Or don't you agree with this version of the patch?
Phil asked me in IRC to pick this patch up, so I'll include it in my next
pull request.
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-29 10:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-26 12:13 [PATCH v2 0/1] stubs: Add missing qga stubs Konstantin Kostiuk
2024-04-26 12:13 ` [PATCH v2 1/1] " Konstantin Kostiuk
2024-04-29 10:09 ` Konstantin Kostiuk
2024-04-29 10:37 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.