From: Jason Gunthorpe <jgg@nvidia.com> To: Mostafa Saleh <smostafa@google.com> Cc: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>, linux-arm-kernel@lists.infradead.org, Robin Murphy <robin.murphy@arm.com>, Will Deacon <will@kernel.org>, Eric Auger <eric.auger@redhat.com>, Moritz Fischer <mdf@kernel.org>, Moritz Fischer <moritzf@google.com>, Michael Shavit <mshavit@google.com>, Nicolin Chen <nicolinc@nvidia.com>, patches@lists.linux.dev, Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> Subject: Re: [PATCH v7 5/9] iommu/arm-smmu-v3: Make arm_smmu_alloc_cd_ptr() Date: Mon, 29 Apr 2024 11:01:37 -0300 [thread overview] Message-ID: <20240429140137.GE941030@nvidia.com> (raw) In-Reply-To: <Zi15-dcNj6E0k4jK@google.com> On Sat, Apr 27, 2024 at 10:19:37PM +0000, Mostafa Saleh wrote: > > I'm not sure what you are asking? We have two versions. One is called > > alloc and one is called get. That have different locking requirements > > on the caller so they have different names. I would not call them both > > get? > > > > My point is that arm_smmu_alloc_cd_ptr() doesn’t only allocate the leaf, > but also the L1 through arm_smmu_alloc_cd_tables() Sure, it is called alloc, it allocs everything to make the CD table entry usable. > IMO, arm_smmu_alloc_cd_ptr() should only allocate leafs. And inside > arm_smmu_attach_dev() it calls arm_smmu_alloc_cd_tables(). > This makes it clear which path is expected to allocate the L1 table. The PASID path sometimes has to allocate the L1 table too, why duplicate the allocation code? What is different about the L1 vs L2 that it should be open coded? Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com> To: Mostafa Saleh <smostafa@google.com> Cc: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>, linux-arm-kernel@lists.infradead.org, Robin Murphy <robin.murphy@arm.com>, Will Deacon <will@kernel.org>, Eric Auger <eric.auger@redhat.com>, Moritz Fischer <mdf@kernel.org>, Moritz Fischer <moritzf@google.com>, Michael Shavit <mshavit@google.com>, Nicolin Chen <nicolinc@nvidia.com>, patches@lists.linux.dev, Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> Subject: Re: [PATCH v7 5/9] iommu/arm-smmu-v3: Make arm_smmu_alloc_cd_ptr() Date: Mon, 29 Apr 2024 11:01:37 -0300 [thread overview] Message-ID: <20240429140137.GE941030@nvidia.com> (raw) In-Reply-To: <Zi15-dcNj6E0k4jK@google.com> On Sat, Apr 27, 2024 at 10:19:37PM +0000, Mostafa Saleh wrote: > > I'm not sure what you are asking? We have two versions. One is called > > alloc and one is called get. That have different locking requirements > > on the caller so they have different names. I would not call them both > > get? > > > > My point is that arm_smmu_alloc_cd_ptr() doesn’t only allocate the leaf, > but also the L1 through arm_smmu_alloc_cd_tables() Sure, it is called alloc, it allocs everything to make the CD table entry usable. > IMO, arm_smmu_alloc_cd_ptr() should only allocate leafs. And inside > arm_smmu_attach_dev() it calls arm_smmu_alloc_cd_tables(). > This makes it clear which path is expected to allocate the L1 table. The PASID path sometimes has to allocate the L1 table too, why duplicate the allocation code? What is different about the L1 vs L2 that it should be open coded? Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-29 14:01 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-16 19:28 [PATCH v7 0/9] Make the SMMUv3 CD logic match the new STE design (part 2a/3) Jason Gunthorpe 2024-04-16 19:28 ` Jason Gunthorpe 2024-04-16 19:28 ` [PATCH v7 1/9] iommu/arm-smmu-v3: Add an ops indirection to the STE code Jason Gunthorpe 2024-04-16 19:28 ` Jason Gunthorpe 2024-04-16 20:18 ` Nicolin Chen 2024-04-16 20:18 ` Nicolin Chen 2024-04-19 21:02 ` Mostafa Saleh 2024-04-19 21:02 ` Mostafa Saleh 2024-04-22 13:09 ` Jason Gunthorpe 2024-04-22 13:09 ` Jason Gunthorpe 2024-04-16 19:28 ` [PATCH v7 2/9] iommu/arm-smmu-v3: Make CD programming use arm_smmu_write_entry() Jason Gunthorpe 2024-04-16 19:28 ` Jason Gunthorpe 2024-04-16 20:48 ` Nicolin Chen 2024-04-16 20:48 ` Nicolin Chen 2024-04-18 13:01 ` Robin Murphy 2024-04-18 13:01 ` Robin Murphy 2024-04-18 16:08 ` Jason Gunthorpe 2024-04-18 16:08 ` Jason Gunthorpe 2024-04-19 21:07 ` Mostafa Saleh 2024-04-19 21:07 ` Mostafa Saleh 2024-04-22 13:29 ` Jason Gunthorpe 2024-04-22 13:29 ` Jason Gunthorpe 2024-04-27 22:08 ` Mostafa Saleh 2024-04-27 22:08 ` Mostafa Saleh 2024-04-29 14:29 ` Jason Gunthorpe 2024-04-29 14:29 ` Jason Gunthorpe 2024-04-29 15:30 ` Mostafa Saleh 2024-04-29 15:30 ` Mostafa Saleh 2024-04-16 19:28 ` [PATCH v7 3/9] iommu/arm-smmu-v3: Move the CD generation for S1 domains into a function Jason Gunthorpe 2024-04-16 19:28 ` Jason Gunthorpe 2024-04-16 21:22 ` Nicolin Chen 2024-04-16 21:22 ` Nicolin Chen 2024-04-19 21:10 ` Mostafa Saleh 2024-04-19 21:10 ` Mostafa Saleh 2024-04-22 13:52 ` Jason Gunthorpe 2024-04-22 13:52 ` Jason Gunthorpe 2024-04-16 19:28 ` [PATCH v7 4/9] iommu/arm-smmu-v3: Consolidate clearing a CD table entry Jason Gunthorpe 2024-04-16 19:28 ` Jason Gunthorpe 2024-04-16 19:28 ` [PATCH v7 5/9] iommu/arm-smmu-v3: Make arm_smmu_alloc_cd_ptr() Jason Gunthorpe 2024-04-16 19:28 ` Jason Gunthorpe 2024-04-16 22:19 ` Nicolin Chen 2024-04-16 22:19 ` Nicolin Chen 2024-04-19 21:14 ` Mostafa Saleh 2024-04-19 21:14 ` Mostafa Saleh 2024-04-22 14:20 ` Jason Gunthorpe 2024-04-22 14:20 ` Jason Gunthorpe 2024-04-27 22:19 ` Mostafa Saleh 2024-04-27 22:19 ` Mostafa Saleh 2024-04-29 14:01 ` Jason Gunthorpe [this message] 2024-04-29 14:01 ` Jason Gunthorpe 2024-04-29 14:47 ` Mostafa Saleh 2024-04-29 14:47 ` Mostafa Saleh 2024-04-29 14:55 ` Jason Gunthorpe 2024-04-29 14:55 ` Jason Gunthorpe 2024-04-16 19:28 ` [PATCH v7 6/9] iommu/arm-smmu-v3: Allocate the CD table entry in advance Jason Gunthorpe 2024-04-16 19:28 ` Jason Gunthorpe 2024-04-16 19:28 ` [PATCH v7 7/9] iommu/arm-smmu-v3: Move the CD generation for SVA into a function Jason Gunthorpe 2024-04-16 19:28 ` Jason Gunthorpe 2024-04-17 7:37 ` Nicolin Chen 2024-04-17 7:37 ` Nicolin Chen 2024-04-17 13:17 ` Jason Gunthorpe 2024-04-17 13:17 ` Jason Gunthorpe 2024-04-17 16:25 ` Nicolin Chen 2024-04-17 16:25 ` Nicolin Chen 2024-04-17 16:26 ` Nicolin Chen 2024-04-17 16:26 ` Nicolin Chen 2024-04-18 4:40 ` Michael Shavit 2024-04-18 4:40 ` Michael Shavit 2024-04-18 14:28 ` Jason Gunthorpe 2024-04-18 14:28 ` Jason Gunthorpe 2024-04-16 19:28 ` [PATCH v7 8/9] iommu/arm-smmu-v3: Build the whole CD in arm_smmu_make_s1_cd() Jason Gunthorpe 2024-04-16 19:28 ` Jason Gunthorpe 2024-04-17 7:43 ` Nicolin Chen 2024-04-17 7:43 ` Nicolin Chen 2024-04-16 19:28 ` [PATCH v7 9/9] iommu/arm-smmu-v3: Add unit tests for arm_smmu_write_entry Jason Gunthorpe 2024-04-16 19:28 ` Jason Gunthorpe 2024-04-17 8:09 ` Nicolin Chen 2024-04-17 8:09 ` Nicolin Chen 2024-04-17 14:16 ` Jason Gunthorpe 2024-04-17 14:16 ` Jason Gunthorpe 2024-04-17 16:13 ` Nicolin Chen 2024-04-17 16:13 ` Nicolin Chen 2024-04-18 4:39 ` Michael Shavit 2024-04-18 4:39 ` Michael Shavit 2024-04-18 12:48 ` Jason Gunthorpe 2024-04-18 12:48 ` Jason Gunthorpe 2024-04-18 14:34 ` Michael Shavit 2024-04-18 14:34 ` Michael Shavit 2024-04-19 21:24 ` Mostafa Saleh 2024-04-19 21:24 ` Mostafa Saleh 2024-04-22 14:24 ` Jason Gunthorpe 2024-04-22 14:24 ` Jason Gunthorpe 2024-04-27 22:33 ` Mostafa Saleh 2024-04-27 22:33 ` Mostafa Saleh 2024-04-16 19:40 ` [PATCH v7 0/9] Make the SMMUv3 CD logic match the new STE design (part 2a/3) Nicolin Chen 2024-04-16 19:40 ` Nicolin Chen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240429140137.GE941030@nvidia.com \ --to=jgg@nvidia.com \ --cc=eric.auger@redhat.com \ --cc=iommu@lists.linux.dev \ --cc=joro@8bytes.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=mdf@kernel.org \ --cc=moritzf@google.com \ --cc=mshavit@google.com \ --cc=nicolinc@nvidia.com \ --cc=patches@lists.linux.dev \ --cc=robin.murphy@arm.com \ --cc=shameerali.kolothum.thodi@huawei.com \ --cc=smostafa@google.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.