All of lore.kernel.org
 help / color / mirror / Atom feed
From: Edward Liaw <edliaw@google.com>
To: shuah@kernel.org, "Mickaël Salaün" <mic@digikod.net>,
	"Günther Noack" <gnoack@google.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Richard Cochran" <richardcochran@gmail.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Jesper Dangaard Brouer" <hawk@kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	 kernel-team@android.com, Edward Liaw <edliaw@google.com>,
	 linux-security-module@vger.kernel.org, netdev@vger.kernel.org,
	 linux-riscv@lists.infradead.org, bpf@vger.kernel.org,
	 John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v4 01/66] selftests: Compile with -D_GNU_SOURCE when including lib.mk
Date: Fri, 10 May 2024 00:06:18 +0000	[thread overview]
Message-ID: <20240510000842.410729-2-edliaw@google.com> (raw)
In-Reply-To: <20240510000842.410729-1-edliaw@google.com>

lib.mk will add -D_GNU_SOURCE to CFLAGS by default.  This will make it
unnecessary to add #define _GNU_SOURCE in the source code.

Suggested-by: John Hubbard <jhubbard@nvidia.com>
Signed-off-by: Edward Liaw <edliaw@google.com>
---
 tools/testing/selftests/Makefile | 4 ++--
 tools/testing/selftests/lib.mk   | 5 ++++-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index f0431e6cb67e..9039f3709aff 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -170,11 +170,11 @@ ifneq ($(KBUILD_OUTPUT),)
   # $(realpath ...) resolves symlinks
   abs_objtree := $(realpath $(abs_objtree))
   BUILD := $(abs_objtree)/kselftest
-  KHDR_INCLUDES := -D_GNU_SOURCE -isystem ${abs_objtree}/usr/include
+  KHDR_INCLUDES := -isystem ${abs_objtree}/usr/include
 else
   BUILD := $(CURDIR)
   abs_srctree := $(shell cd $(top_srcdir) && pwd)
-  KHDR_INCLUDES := -D_GNU_SOURCE -isystem ${abs_srctree}/usr/include
+  KHDR_INCLUDES := -isystem ${abs_srctree}/usr/include
   DEFAULT_INSTALL_HDR_PATH := 1
 endif

diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index 3023e0e2f58f..e782f4c96aee 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -67,7 +67,7 @@ MAKEFLAGS += --no-print-directory
 endif

 ifeq ($(KHDR_INCLUDES),)
-KHDR_INCLUDES := -D_GNU_SOURCE -isystem $(top_srcdir)/usr/include
+KHDR_INCLUDES := -isystem $(top_srcdir)/usr/include
 endif

 # In order to use newer items that haven't yet been added to the user's system
@@ -188,6 +188,9 @@ endef
 clean: $(if $(TEST_GEN_MODS_DIR),clean_mods_dir)
 	$(CLEAN)

+# Build with _GNU_SOURCE by default
+CFLAGS += -D_GNU_SOURCE
+
 # Enables to extend CFLAGS and LDFLAGS from command line, e.g.
 # make USERCFLAGS=-Werror USERLDFLAGS=-static
 CFLAGS += $(USERCFLAGS)
--
2.45.0.118.g7fe29c98d7-goog


WARNING: multiple messages have this Message-ID (diff)
From: Edward Liaw <edliaw@google.com>
To: shuah@kernel.org, "Mickaël Salaün" <mic@digikod.net>,
	"Günther Noack" <gnoack@google.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Richard Cochran" <richardcochran@gmail.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Jesper Dangaard Brouer" <hawk@kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	 kernel-team@android.com, Edward Liaw <edliaw@google.com>,
	 linux-security-module@vger.kernel.org, netdev@vger.kernel.org,
	 linux-riscv@lists.infradead.org, bpf@vger.kernel.org,
	 John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v4 01/66] selftests: Compile with -D_GNU_SOURCE when including lib.mk
Date: Fri, 10 May 2024 00:06:18 +0000	[thread overview]
Message-ID: <20240510000842.410729-2-edliaw@google.com> (raw)
In-Reply-To: <20240510000842.410729-1-edliaw@google.com>

lib.mk will add -D_GNU_SOURCE to CFLAGS by default.  This will make it
unnecessary to add #define _GNU_SOURCE in the source code.

Suggested-by: John Hubbard <jhubbard@nvidia.com>
Signed-off-by: Edward Liaw <edliaw@google.com>
---
 tools/testing/selftests/Makefile | 4 ++--
 tools/testing/selftests/lib.mk   | 5 ++++-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index f0431e6cb67e..9039f3709aff 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -170,11 +170,11 @@ ifneq ($(KBUILD_OUTPUT),)
   # $(realpath ...) resolves symlinks
   abs_objtree := $(realpath $(abs_objtree))
   BUILD := $(abs_objtree)/kselftest
-  KHDR_INCLUDES := -D_GNU_SOURCE -isystem ${abs_objtree}/usr/include
+  KHDR_INCLUDES := -isystem ${abs_objtree}/usr/include
 else
   BUILD := $(CURDIR)
   abs_srctree := $(shell cd $(top_srcdir) && pwd)
-  KHDR_INCLUDES := -D_GNU_SOURCE -isystem ${abs_srctree}/usr/include
+  KHDR_INCLUDES := -isystem ${abs_srctree}/usr/include
   DEFAULT_INSTALL_HDR_PATH := 1
 endif

diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index 3023e0e2f58f..e782f4c96aee 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -67,7 +67,7 @@ MAKEFLAGS += --no-print-directory
 endif

 ifeq ($(KHDR_INCLUDES),)
-KHDR_INCLUDES := -D_GNU_SOURCE -isystem $(top_srcdir)/usr/include
+KHDR_INCLUDES := -isystem $(top_srcdir)/usr/include
 endif

 # In order to use newer items that haven't yet been added to the user's system
@@ -188,6 +188,9 @@ endef
 clean: $(if $(TEST_GEN_MODS_DIR),clean_mods_dir)
 	$(CLEAN)

+# Build with _GNU_SOURCE by default
+CFLAGS += -D_GNU_SOURCE
+
 # Enables to extend CFLAGS and LDFLAGS from command line, e.g.
 # make USERCFLAGS=-Werror USERLDFLAGS=-static
 CFLAGS += $(USERCFLAGS)
--
2.45.0.118.g7fe29c98d7-goog


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2024-05-10  0:09 UTC|newest]

Thread overview: 162+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10  0:06 [PATCH v4 00/66] Define _GNU_SOURCE for sources using Edward Liaw
2024-05-10  0:06 ` Edward Liaw
2024-05-10  0:06 ` Edward Liaw [this message]
2024-05-10  0:06   ` [PATCH v4 01/66] selftests: Compile with -D_GNU_SOURCE when including lib.mk Edward Liaw
2024-05-10  0:06 ` [PATCH v4 02/66] selftests/arm64: Drop define _GNU_SOURCE Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 03/66] selftests/arm64: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 04/66] selftests/bpf: Drop define _GNU_SOURCE Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 05/66] selftests/breakpoints: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 06/66] selftests/cachestat: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 07/66] selftests/capabilities: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 08/66] selftests/cgroup: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-13 17:02   ` Tejun Heo
2024-05-13 17:02     ` Tejun Heo
2024-05-16 15:50     ` Shuah Khan
2024-05-16 15:50       ` Shuah Khan
2024-05-16 16:21       ` Tejun Heo
2024-05-16 16:21         ` Tejun Heo
2024-05-16 16:31         ` Shuah Khan
2024-05-16 16:31           ` Shuah Khan
2024-05-16 17:45           ` Tejun Heo
2024-05-16 17:45             ` Tejun Heo
2024-05-16 18:05             ` Shuah Khan
2024-05-16 18:05               ` Shuah Khan
2024-05-17  3:47               ` Shuah Khan
2024-05-17  3:47                 ` Shuah Khan
2024-05-10  0:06 ` [PATCH v4 09/66] selftests/clone3: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 10/66] selftests/core: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 11/66] selftests/damon: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 12/66] selftests/drivers: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 13/66] selftests/exec: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10 17:44   ` Kees Cook
2024-05-10 17:44     ` Kees Cook
2024-05-10  0:06 ` [PATCH v4 14/66] selftests/fchmodat2: Drop define _GNU_SOURCE Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 15/66] selftests/filelock: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 16/66] selftests/filesystems: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 17/66] selftests/firmware: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 18/66] selftests/fpu: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 19/66] selftests/futex: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 20/66] selftests/futex: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 21/66] selftests/intel_pstate: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 22/66] selftests/iommu: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 23/66] selftests/ipc: Drop define _GNU_SOURCE Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 24/66] selftests/kcmp: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 25/66] selftests/landlock: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 26/66] selftests/lsm: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 27/66] selftests/membarrier: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 28/66] selftests/memfd: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 29/66] selftests/mincore: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 30/66] selftests/mm: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 31/66] selftests/mount: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 32/66] selftests/mount_setattr: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 33/66] selftests/move_mount_set_group: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 34/66] selftests/mqueue: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 35/66] selftests/net: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 36/66] selftests/net: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 37/66] selftests/nolibc: Drop define _GNU_SOURCE Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  6:58   ` Thomas Weißschuh
2024-05-10  6:58     ` Thomas Weißschuh
2024-05-10  0:06 ` [PATCH v4 38/66] selftests/nsfs: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 39/66] selftests/openat2: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 40/66] selftests/perf_events: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 41/66] selftests/pid_namespace: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:06 ` [PATCH v4 42/66] selftests/pidfd: " Edward Liaw
2024-05-10  0:06   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 43/66] selftests/ptrace: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 44/66] selftests/powerpc: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 45/66] selftests/proc: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 46/66] selftests/proc: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 47/66] selftests/ptp: Drop define _GNU_SOURCE Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 48/66] selftests/resctrl: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 49/66] selftests/riscv: Drop define _GNU_SOURCE Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 50/66] selftests/riscv: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 51/66] selftests/rlimits: Drop define _GNU_SOURCE Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 52/66] selftests/rseq: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 53/66] selftests/safesetid: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 54/66] selftests/sched: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 55/66] selftests/seccomp: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10 17:45   ` Kees Cook
2024-05-10 17:45     ` Kees Cook
2024-05-10  0:07 ` [PATCH v4 56/66] selftests/sigaltstack: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 57/66] selftests/splice: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 58/66] selftests/syscall_user_dispatch: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 59/66] selftests/thermal: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 60/66] selftests/timens: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 61/66] selftests/tmpfs: Drop duplicate -D_GNU_SOURCE Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 62/66] selftests/uevent: Drop define _GNU_SOURCE Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 63/66] selftests/user_events: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 64/66] selftests/vDSO: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-10  0:07 ` [PATCH v4 65/66] selftests/wireguard: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-17 14:48   ` Jason A. Donenfeld
2024-05-17 14:48     ` Jason A. Donenfeld
2024-05-10  0:07 ` [PATCH v4 66/66] selftests/x86: " Edward Liaw
2024-05-10  0:07   ` Edward Liaw
2024-05-16 15:55 ` [PATCH v4 00/66] Define _GNU_SOURCE for sources using Shuah Khan
2024-05-16 15:55   ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240510000842.410729-2-edliaw@google.com \
    --to=edliaw@google.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=gnoack@google.com \
    --cc=hawk@kernel.org \
    --cc=jhubbard@nvidia.com \
    --cc=john.fastabend@gmail.com \
    --cc=kernel-team@android.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mic@digikod.net \
    --cc=netdev@vger.kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=richardcochran@gmail.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.