All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Harvey <tharvey@gateworks.com>
To: Tom Rini <trini@konsulko.com>, Tim Harvey <tharvey@gateworks.com>,
	Simon Glass <sjg@chromium.org>, Marek Vasut <marex@denx.de>,
	Fabio Estevam <festevam@gmail.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	u-boot@lists.denx.de, Dragan Simic <dsimic@manjaro.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Avri Altman <avri.altman@wdc.com>
Subject: [PATCH 0/3 v4] provide names for emmc hardware partitions
Date: Mon, 13 May 2024 16:29:04 -0700	[thread overview]
Message-ID: <20240513232907.2738959-1-tharvey@gateworks.com> (raw)

Modern eMMC v4+ devices have multiple hardware partitions per the JEDEC
specification described as:
 Boot Area Partition 1
 Boot Area Partition 2
 RPMB Partition
 General Purpose Partition 1
 General Purpose Partition 2
 General Purpose Partition 3
 General Purpose Partition 4
 User Data Area

These are referenced by fields in the PARTITION_CONFIG register
(Extended CSD Register 179) which is defined as:
bit 7: reserved
bit 6: BOOT_ACK
  0x0: No boot acknowledge sent (default
  0x1: Boot acknowledge sent during boot operation Bit
bit 5:3: BOOT_PARTITION_ENABLE
  0x0: Device not boot enabled (default)
  0x1: Boot Area partition 1 enabled for boot
  0x2: Boot Area partition 2 enabled for boot
  0x3-0x6: Reserved
  0x7: User area enabled for boot
bit 2:0 PARTITION_ACCESS
  0x0: No access to boot partition (default)
  0x1: Boot Area partition 1
  0x2: Boot Area partition 2
  0x3: Replay Protected Memory Block (RPMB)
  0x4: Access to General Purpose partition 1
  0x5: Access to General Purpose partition 2
  0x6: Access to General Purpose partition 3
  0x7: Access to General Purpose partition 4

Note that setting PARTITION_ACCESS to 0x0 results in selecting the User
Data Area partition.

You can see above that the two fields BOOT_PARTITION_ENABLE and
PARTITION_ACCESS do not use the same enumerated values.

U-Boot uses a set of macros to access fields of the PARTITION_CONFIG
register:
#define EXT_CSD_BOOT_ACK_ENABLE                 (1 << 6)
#define EXT_CSD_BOOT_PARTITION_ENABLE           (1 << 3)
#define EXT_CSD_PARTITION_ACCESS_ENABLE         (1 << 0)
#define EXT_CSD_PARTITION_ACCESS_DISABLE        (0 << 0)

#define EXT_CSD_BOOT_ACK(x)             (x << 6)
#define EXT_CSD_BOOT_PART_NUM(x)        (x << 3)
#define EXT_CSD_PARTITION_ACCESS(x)     (x << 0)

#define EXT_CSD_EXTRACT_BOOT_ACK(x) (((x) >> 6) & 0x1)
#define EXT_CSD_EXTRACT_BOOT_PART(x) (((x) >> 3) & 0x7)
#define EXT_CSD_EXTRACT_PARTITION_ACCESS(x) ((x) & 0x7)

There are various places in U-Boot where the BOOT_PARTITION_ENABLE field
is accessed via EXT_CSD_EXTRACT_PARTITION_ACCESS and converted to a
hardware partition consistent with the definition of the
PARTITION_ACCESS field used by the various mmc_switch incarnations.

To add some sanity to the distinction between BOOT_PARTITION_ENABLE
(used to specify the active device on power-cycle) and PARTITION_ACCESS
(used to switch between hardware partitions) create two enumerated types
and use them wherever struct mmc * part_config is used or the above
macros are used.

Additionally provide arrays of the field names and allow those to be
used in the 'mmc partconf' command and in board support files.

The first patch adds enumerated types and makes use of them which
represents no compiled code change.

The 2nd patch adds the array of names and uses them in the 'mmc
partconf' command.

The 3rd patch uses the array of hardware partition names in a board
support file to show what emmc hardware partition U-Boot is being loaded
from.

I'm sending this as a series this time around as previously it was
repsented as two different patches.

Tim Harvey (3):
  mmc: use an enumerated type to represent PARTITION_CONFIG fields
  mmc: allow use of hardware partition names for mmc partconf
  venice: show emmc boot hardware partition

 arch/arm/mach-imx/image-container.c | 10 ++++-----
 arch/arm/mach-sunxi/board.c         |  2 +-
 board/gateworks/venice/spl.c        | 20 ++++++++++++-----
 board/gateworks/venice/venice.c     | 22 +++++++++---------
 board/purism/librem5/librem5.c      |  4 ++--
 board/storopack/smegw01/smegw01.c   |  4 ++--
 cmd/mmc.c                           | 27 ++++++++++++++++++----
 cmd/mvebu/bubt.c                    |  4 ++--
 common/spl/spl_mmc.c                |  4 ++--
 drivers/mmc/mmc.c                   | 35 +++++++++++++++++++++++++++++
 include/mmc.h                       | 26 +++++++++++++++++++++
 11 files changed, 123 insertions(+), 35 deletions(-)

-- 
2.25.1


             reply	other threads:[~2024-05-13 23:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-13 23:29 Tim Harvey [this message]
2024-05-13 23:29 ` [PATCH 1/3 v4] mmc: use an enumerated type to represent PARTITION_CONFIG fields Tim Harvey
2024-05-13 23:29 ` [PATCH 2/3 v4] mmc: allow use of hardware partition names for mmc partconf Tim Harvey
2024-05-13 23:29 ` [PATCH 3/3 v4] venice: show emmc boot hardware partition Tim Harvey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240513232907.2738959-1-tharvey@gateworks.com \
    --to=tharvey@gateworks.com \
    --cc=avri.altman@wdc.com \
    --cc=dsimic@manjaro.org \
    --cc=festevam@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=marex@denx.de \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.