From: Mugunthan V N <mugunthanvnm@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>, Sekhar Nori <nsekhar@ti.com>
Subject: Re: [PATCH v2 2/4] net: phy: dp83867: add support for MAC impedance configuration
Date: Wed, 5 Oct 2016 08:58:27 +0530 [thread overview]
Message-ID: <20264692-6a13-58c0-c262-f631af8f355e@ti.com> (raw)
In-Reply-To: <20161004131032.GL11677@lunn.ch>
On Tuesday 04 October 2016 06:40 PM, Andrew Lunn wrote:
>> + if (of_property_read_bool(of_node, "ti,max-output-imepdance"))
>> + dp83867->io_impedance = DP83867_IO_MUX_CFG_IO_IMPEDANCE_MAX;
>> + else if (of_property_read_bool(of_node, "ti,min-output-imepdance"))
>
> Did you really test this? Or did you make the same typos in your device
> tree file?
>
I have tested this and attached the log in cover letter. Since there is
a typo error on both dts and driver it worked as expected. Will send a
v3 ASAP.
Regards
Mugunthan V N
WARNING: multiple messages have this Message-ID (diff)
From: Mugunthan V N <mugunthanvnm@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>, Sekhar Nori <nsekhar@ti.com>
Subject: Re: [PATCH v2 2/4] net: phy: dp83867: add support for MAC impedance configuration
Date: Wed, 5 Oct 2016 08:58:27 +0530 [thread overview]
Message-ID: <20264692-6a13-58c0-c262-f631af8f355e@ti.com> (raw)
In-Reply-To: <20161004131032.GL11677@lunn.ch>
On Tuesday 04 October 2016 06:40 PM, Andrew Lunn wrote:
>> + if (of_property_read_bool(of_node, "ti,max-output-imepdance"))
>> + dp83867->io_impedance = DP83867_IO_MUX_CFG_IO_IMPEDANCE_MAX;
>> + else if (of_property_read_bool(of_node, "ti,min-output-imepdance"))
>
> Did you really test this? Or did you make the same typos in your device
> tree file?
>
I have tested this and attached the log in cover letter. Since there is
a typo error on both dts and driver it worked as expected. Will send a
v3 ASAP.
Regards
Mugunthan V N
WARNING: multiple messages have this Message-ID (diff)
From: mugunthanvnm@ti.com (Mugunthan V N)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] net: phy: dp83867: add support for MAC impedance configuration
Date: Wed, 5 Oct 2016 08:58:27 +0530 [thread overview]
Message-ID: <20264692-6a13-58c0-c262-f631af8f355e@ti.com> (raw)
In-Reply-To: <20161004131032.GL11677@lunn.ch>
On Tuesday 04 October 2016 06:40 PM, Andrew Lunn wrote:
>> + if (of_property_read_bool(of_node, "ti,max-output-imepdance"))
>> + dp83867->io_impedance = DP83867_IO_MUX_CFG_IO_IMPEDANCE_MAX;
>> + else if (of_property_read_bool(of_node, "ti,min-output-imepdance"))
>
> Did you really test this? Or did you make the same typos in your device
> tree file?
>
I have tested this and attached the log in cover letter. Since there is
a typo error on both dts and driver it worked as expected. Will send a
v3 ASAP.
Regards
Mugunthan V N
next prev parent reply other threads:[~2016-10-05 3:29 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 12:56 [PATCH v2 0/4] add support for impedance control for TI dp83867 phy and fix 2nd ethernet on dra72 rev C evm Mugunthan V N
2016-10-04 12:56 ` Mugunthan V N
2016-10-04 12:56 ` Mugunthan V N
2016-10-04 12:56 ` Mugunthan V N
2016-10-04 12:56 ` [PATCH v2 1/4] net: phy: dp83867: Add documentation for optional impedance control Mugunthan V N
2016-10-04 12:56 ` Mugunthan V N
2016-10-04 12:56 ` Mugunthan V N
2016-10-04 12:56 ` Mugunthan V N
2016-10-04 12:56 ` [PATCH v2 2/4] net: phy: dp83867: add support for MAC impedance configuration Mugunthan V N
2016-10-04 12:56 ` Mugunthan V N
2016-10-04 12:56 ` Mugunthan V N
2016-10-04 13:10 ` Lokesh Vutla
2016-10-04 13:10 ` Lokesh Vutla
2016-10-04 13:10 ` Lokesh Vutla
2016-10-04 13:10 ` Andrew Lunn
2016-10-04 13:10 ` Andrew Lunn
2016-10-05 3:28 ` Mugunthan V N [this message]
2016-10-05 3:28 ` Mugunthan V N
2016-10-05 3:28 ` Mugunthan V N
2016-10-04 12:56 ` [PATCH v2 3/4] ARM: dts: dra72-evm-revc: fix correct phy delay and impedance settings Mugunthan V N
2016-10-04 12:56 ` Mugunthan V N
2016-10-04 12:56 ` Mugunthan V N
2016-10-04 13:11 ` Lokesh Vutla
2016-10-04 13:11 ` Lokesh Vutla
2016-10-04 13:11 ` Lokesh Vutla
2016-10-04 13:11 ` Lokesh Vutla
2016-10-05 3:29 ` Mugunthan V N
2016-10-05 3:29 ` Mugunthan V N
2016-10-05 3:29 ` Mugunthan V N
2016-10-04 13:11 ` Andrew Lunn
2016-10-04 13:11 ` Andrew Lunn
2016-10-04 12:56 ` [PATCH v2 4/4] ARM: dts: dra72-evm-revc: fix correct phy delay Mugunthan V N
2016-10-04 12:56 ` Mugunthan V N
2016-10-04 12:56 ` Mugunthan V N
2016-10-04 13:14 ` Andrew Lunn
2016-10-04 13:14 ` Andrew Lunn
2016-10-04 13:14 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20264692-6a13-58c0-c262-f631af8f355e@ti.com \
--to=mugunthanvnm@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.