From: David Howells <dhowells@redhat.com>
To: Valdis Kl=?utf-8?Q?=c4=93?=tnieks <valdis.kletnieks@vt.edu>
Cc: dhowells@redhat.com, David Woodhouse <dwmw2@infradead.org>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 'make O=' indigestion with module signing
Date: Fri, 12 Mar 2021 09:01:36 +0000 [thread overview]
Message-ID: <2026575.1615539696@warthog.procyon.org.uk> (raw)
In-Reply-To: <134696.1615510534@turing-police>
Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
> So the root cause was: 'make mrproper doesn't clean certs/' out enough,
> and this chunk of certs/Makefile
> ...
> I admit not being sure how (or if) this should be fixed
It's tricky because CONFIG_MODULE_SIG_KEY may not point to a file, let alone a
file that was autogenerated - it can be given a PKCS#11 URI, for instance. I
had to put in the autogeneration based on a magic config string value to stop
randconfig blowing up - but it only does the autogeneration if you don't put
in your own file there before building.
Possibly I can add something like:
clean-files := signing_key.pem x509.genkey
inside the
ifeq ($(CONFIG_MODULE_SIG_KEY),"certs/signing_key.pem")
...
endif
section.
David
next prev parent reply other threads:[~2021-03-12 9:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 6:32 'make O=' indigestion with module signing Valdis Klētnieks
2021-03-11 9:34 ` David Howells
2021-03-11 9:51 ` Valdis Klētnieks
2021-03-11 10:49 ` David Howells
2021-03-11 11:44 ` Valdis Klētnieks
2021-03-11 12:04 ` David Howells
2021-03-12 0:55 ` Valdis Klētnieks
2021-03-12 9:01 ` David Howells [this message]
2021-03-12 9:06 ` Valdis Klētnieks
2021-03-12 11:19 ` [PATCH] certs: Clean up signing_key.pem and x509.genkey on make mrproper David Howells
2021-05-09 15:11 ` 'make O=' indigestion with module signing Ingo Molnar
2021-05-09 15:15 ` Ingo Molnar
2021-05-09 16:19 ` Ingo Molnar
2021-05-10 12:41 ` Ingo Molnar
2021-03-11 13:31 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026575.1615539696@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.