All of lore.kernel.org
 help / color / mirror / Atom feed
* [xen-unstable test] 11905: regressions - FAIL
@ 2012-02-10  1:23 xen.org
  2012-02-10  9:31 ` Ian Campbell
  0 siblings, 1 reply; 4+ messages in thread
From: xen.org @ 2012-02-10  1:23 UTC (permalink / raw)
  To: xen-devel; +Cc: ian.jackson

flight 11905 xen-unstable real [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/11905/

Regressions :-(

Tests which did not succeed and are blocking,
including tests which could not be run:
 test-amd64-amd64-win          7 windows-install           fail REGR. vs. 11904
 test-amd64-i386-win-vcpus1    7 windows-install           fail REGR. vs. 11904
 test-amd64-i386-win           7 windows-install           fail REGR. vs. 11904
 test-amd64-i386-xend-winxpsp3  7 windows-install          fail REGR. vs. 11904
 test-i386-i386-win            7 windows-install           fail REGR. vs. 11904

Tests which did not succeed, but are not blocking:
 test-i386-i386-xl-qemuu-winxpsp3  7 windows-install            fail never pass
 test-amd64-amd64-xl-qemuu-winxpsp3  7 windows-install          fail never pass
 test-amd64-amd64-xl-qemuu-win7-amd64  7 windows-install        fail never pass
 test-amd64-i386-qemuu-rhel6hvm-intel  7 redhat-install         fail never pass
 test-amd64-amd64-xl-pcipt-intel  9 guest-start                 fail never pass
 test-amd64-i386-qemuu-rhel6hvm-amd  7 redhat-install           fail never pass
 test-amd64-amd64-xl-winxpsp3 13 guest-stop                   fail   never pass
 test-amd64-i386-rhel6hvm-intel 11 leak-check/check             fail never pass
 test-amd64-i386-rhel6hvm-amd 11 leak-check/check             fail   never pass
 test-i386-i386-xl-winxpsp3   13 guest-stop                   fail   never pass
 test-amd64-amd64-xl-win7-amd64 13 guest-stop                   fail never pass
 test-amd64-i386-xl-winxpsp3-vcpus1 13 guest-stop               fail never pass
 test-i386-i386-xl-win        13 guest-stop                   fail   never pass
 test-amd64-amd64-xl-win      13 guest-stop                   fail   never pass
 test-amd64-i386-xl-win7-amd64 13 guest-stop                   fail  never pass
 test-amd64-i386-xl-win-vcpus1 13 guest-stop                   fail  never pass

version targeted for testing:
 xen                  730f6ed72d70
baseline version:
 xen                  9fc810bb8145

------------------------------------------------------------
People who touched revisions under test:
  Alex Zeffertt <alex.zeffertt@eu.citrix.com>
  Daniel De Graaf <dgdegra@tycho.nsa.gov>
  Diego Ongaro <diego.ongaro@citrix.com>
  hongkaixing <hongkaixing@huawei.com>
  Ian Campbell <ian.campbell@citrix.com>
  Ian Jackson <ian.jackson@eu.citrix.com>
  Jan Beulich <jbeulich@suse.com>
  John McDermott <john.mcdermott@nrl.navy.mil>
  Keir Fraser <keir@xen.org>
  Olaf Hering <olaf@aepfle.de>
  Samuel Thibault <samuel.thibault@ens-lyon.org>
  shizhen <bicky.shi@huawei.com>
  Shriram Rajagopalan <rshriram@cs.ubc.ca>
  Stefano Stabellini <stefano.stabellini@eu.citrix.com>
  Wei Liu <wei.liu2@citrix.com>
  Yongjie Ren <yongjie.ren@intel.com>
  Zhigang Wang <zhigang.x.wang@oracle.com>
------------------------------------------------------------

jobs:
 build-amd64                                                  pass    
 build-i386                                                   pass    
 build-amd64-oldkern                                          pass    
 build-i386-oldkern                                           pass    
 build-amd64-pvops                                            pass    
 build-i386-pvops                                             pass    
 test-amd64-amd64-xl                                          pass    
 test-amd64-i386-xl                                           pass    
 test-i386-i386-xl                                            pass    
 test-amd64-i386-rhel6hvm-amd                                 fail    
 test-amd64-i386-qemuu-rhel6hvm-amd                           fail    
 test-amd64-amd64-xl-qemuu-win7-amd64                         fail    
 test-amd64-amd64-xl-win7-amd64                               fail    
 test-amd64-i386-xl-win7-amd64                                fail    
 test-amd64-i386-xl-credit2                                   pass    
 test-amd64-amd64-xl-pcipt-intel                              fail    
 test-amd64-i386-rhel6hvm-intel                               fail    
 test-amd64-i386-qemuu-rhel6hvm-intel                         fail    
 test-amd64-i386-xl-multivcpu                                 pass    
 test-amd64-amd64-pair                                        pass    
 test-amd64-i386-pair                                         pass    
 test-i386-i386-pair                                          pass    
 test-amd64-amd64-xl-sedf-pin                                 pass    
 test-amd64-amd64-pv                                          pass    
 test-amd64-i386-pv                                           pass    
 test-i386-i386-pv                                            pass    
 test-amd64-amd64-xl-sedf                                     pass    
 test-amd64-i386-win-vcpus1                                   fail    
 test-amd64-i386-xl-win-vcpus1                                fail    
 test-amd64-i386-xl-winxpsp3-vcpus1                           fail    
 test-amd64-amd64-win                                         fail    
 test-amd64-i386-win                                          fail    
 test-i386-i386-win                                           fail    
 test-amd64-amd64-xl-win                                      fail    
 test-i386-i386-xl-win                                        fail    
 test-amd64-amd64-xl-qemuu-winxpsp3                           fail    
 test-i386-i386-xl-qemuu-winxpsp3                             fail    
 test-amd64-i386-xend-winxpsp3                                fail    
 test-amd64-amd64-xl-winxpsp3                                 fail    
 test-i386-i386-xl-winxpsp3                                   fail    


------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images

Logs, config files, etc. are available at
    http://www.chiark.greenend.org.uk/~xensrcts/logs

Test harness code can be found at
    http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary


Not pushing.

(No revision log; it would be 501 lines long.)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [xen-unstable test] 11905: regressions - FAIL
  2012-02-10  1:23 [xen-unstable test] 11905: regressions - FAIL xen.org
@ 2012-02-10  9:31 ` Ian Campbell
  2012-02-10 12:07   ` Ian Campbell
  0 siblings, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2012-02-10  9:31 UTC (permalink / raw)
  To: xen.org, Daniel De Graaf; +Cc: xen-devel

On Fri, 2012-02-10 at 01:23 +0000, xen.org wrote:
> flight 11905 xen-unstable real [real]
> http://www.chiark.greenend.org.uk/~xensrcts/logs/11905/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  test-amd64-amd64-win          7 windows-install           fail REGR. vs. 11904
>  test-amd64-i386-win-vcpus1    7 windows-install           fail REGR. vs. 11904
>  test-amd64-i386-win           7 windows-install           fail REGR. vs. 11904
>  test-amd64-i386-xend-winxpsp3  7 windows-install          fail REGR. vs. 11904
>  test-i386-i386-win            7 windows-install           fail REGR. vs. 11904

http://www.chiark.greenend.org.uk/~xensrcts/logs/11905/test-amd64-i386-win-vcpus1/gall-mite---var-log-xen-xend.log contains:
        [2012-02-09 22:34:26 2310] ERROR (XendDomainInfo:488) VM start failed
        Traceback (most recent call last):
          File "/usr/local/lib/python2.6/dist-packages/xen/xend/XendDomainInfo.py", line 474, in start
            XendTask.log_progress(31, 60, self._initDomain)
          File "/usr/local/lib/python2.6/dist-packages/xen/xend/XendTask.py", line 209, in log_progress
            retval = func(*args, **kwds)
          File "/usr/local/lib/python2.6/dist-packages/xen/xend/XendDomainInfo.py", line 2914, in _initDomain
            self._introduceDomain()
          File "/usr/local/lib/python2.6/dist-packages/xen/xend/XendDomainInfo.py", line 2685, in _introduceDomain
            raise XendError(str(exn))
        XendError: (22, 'Invalid argument')
        
This try block contains only a single call to
xen.xend.xenstore.xsutil.IntroduceDomain which ultimately turns into a C
call to xs_introduce_domain.

Daniel, I'm afraid I suspect the XS stubdom series for this one. My
suspicion is a missing call to seed_grant_table from xend (or from a
libxc function which xend uses) which prevents xenstored from mapping
the guest's ring, which results in an error from map_interface() in
xenstored.

Ian.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [xen-unstable test] 11905: regressions - FAIL
  2012-02-10  9:31 ` Ian Campbell
@ 2012-02-10 12:07   ` Ian Campbell
  2012-02-10 17:25     ` Ian Jackson
  0 siblings, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2012-02-10 12:07 UTC (permalink / raw)
  To: Ian Jackson; +Cc: Daniel De Graaf, xen-devel

On Fri, 2012-02-10 at 09:31 +0000, Ian Campbell wrote:
> On Fri, 2012-02-10 at 01:23 +0000, xen.org wrote:
> > flight 11905 xen-unstable real [real]
> > http://www.chiark.greenend.org.uk/~xensrcts/logs/11905/
> > 
> > Regressions :-(
> > 
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> >  test-amd64-amd64-win          7 windows-install           fail REGR. vs. 11904
> >  test-amd64-i386-win-vcpus1    7 windows-install           fail REGR. vs. 11904
> >  test-amd64-i386-win           7 windows-install           fail REGR. vs. 11904
> >  test-amd64-i386-xend-winxpsp3  7 windows-install          fail REGR. vs. 11904
> >  test-i386-i386-win            7 windows-install           fail REGR. vs. 11904
> 
> http://www.chiark.greenend.org.uk/~xensrcts/logs/11905/test-amd64-i386-win-vcpus1/gall-mite---var-log-xen-xend.log contains:
>         [2012-02-09 22:34:26 2310] ERROR (XendDomainInfo:488) VM start failed
>         Traceback (most recent call last):
>           File "/usr/local/lib/python2.6/dist-packages/xen/xend/XendDomainInfo.py", line 474, in start
>             XendTask.log_progress(31, 60, self._initDomain)
>           File "/usr/local/lib/python2.6/dist-packages/xen/xend/XendTask.py", line 209, in log_progress
>             retval = func(*args, **kwds)
>           File "/usr/local/lib/python2.6/dist-packages/xen/xend/XendDomainInfo.py", line 2914, in _initDomain
>             self._introduceDomain()
>           File "/usr/local/lib/python2.6/dist-packages/xen/xend/XendDomainInfo.py", line 2685, in _introduceDomain
>             raise XendError(str(exn))
>         XendError: (22, 'Invalid argument')
>         
> This try block contains only a single call to
> xen.xend.xenstore.xsutil.IntroduceDomain which ultimately turns into a C
> call to xs_introduce_domain.
> 
> Daniel, I'm afraid I suspect the XS stubdom series for this one. My
> suspicion is a missing call to seed_grant_table from xend (or from a
> libxc function which xend uses) which prevents xenstored from mapping
> the guest's ring, which results in an error from map_interface() in
> xenstored.

The following seems to fix it for me. I also tested an HVM migration
with xm since that seemed like something which might also suffer. It
seemed ok.

8<------------------------------------------------------------


# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1328875524 0
# Node ID 866498ce4469b6bbdbc338c516f39ac21e6aa7e7
# Parent  abc689ef19c2ab2bf86efee9f1e5107eb76c7ff7
xend: populate HVM guest grant table on boot

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

diff -r abc689ef19c2 -r 866498ce4469 tools/python/xen/lowlevel/xc/xc.c
--- a/tools/python/xen/lowlevel/xc/xc.c	Fri Feb 10 11:27:30 2012 +0000
+++ b/tools/python/xen/lowlevel/xc/xc.c	Fri Feb 10 12:05:24 2012 +0000
@@ -1008,6 +1008,30 @@ static PyObject *pyxc_hvm_build(XcObject
     return Py_BuildValue("{}");
 }
 
+static PyObject *pyxc_gnttab_hvm_seed(XcObject *self,
+				      PyObject *args,
+				      PyObject *kwds)
+{
+    uint32_t dom, console_domid, xenstore_domid;
+    unsigned long xenstore_gmfn = 0;
+    unsigned long console_gmfn = 0;
+    static char *kwd_list[] = { "domid",
+				"console_gmfn", "xenstore_gmfn",
+				"console_domid", "xenstore_domid", NULL };
+    if ( !PyArg_ParseTupleAndKeywords(args, kwds, "iiiii", kwd_list,
+                                      &dom,
+				      &console_gmfn, &xenstore_gmfn,
+				      &console_domid, &xenstore_domid) )
+        return NULL;
+
+    if ( xc_dom_gnttab_hvm_seed(self->xc_handle, dom,
+				console_gmfn, xenstore_gmfn,
+				console_domid, xenstore_domid) != 0 )
+        return pyxc_error_to_exception(self->xc_handle);
+
+    return Py_None;
+}
+
 static PyObject *pyxc_evtchn_alloc_unbound(XcObject *self,
                                            PyObject *args,
                                            PyObject *kwds)
@@ -2439,6 +2463,17 @@ static PyMethodDef pyxc_methods[] = {
       " vcpu_avail [long, 1]: Which Virtual CPUS available.\n\n"
       "Returns: [int] 0 on success; -1 on error.\n" },
 
+    { "gnttab_hvm_seed",
+      (PyCFunction)pyxc_gnttab_hvm_seed,
+      METH_KEYWORDS, "\n"
+      "Initialise HVM guest grant table.\n"
+      " dom     [int]:      Identifier of domain to build into.\n"
+      " console_gmfn [int]: \n"
+      " xenstore_gmfn [int]: \n"
+      " console_domid [int]: \n"
+      " xenstore_domid [int]: \n"
+      "Returns: None on sucess. Raises exception on error.\n" },
+
     { "hvm_get_param", 
       (PyCFunction)pyxc_get_hvm_param, 
       METH_VARARGS | METH_KEYWORDS, "\n"
diff -r abc689ef19c2 -r 866498ce4469 tools/python/xen/xend/XendConstants.py
--- a/tools/python/xen/xend/XendConstants.py	Fri Feb 10 11:27:30 2012 +0000
+++ b/tools/python/xen/xend/XendConstants.py	Fri Feb 10 12:05:24 2012 +0000
@@ -52,6 +52,7 @@ HVM_PARAM_TIMER_MODE   = 10
 HVM_PARAM_HPET_ENABLED = 11
 HVM_PARAM_ACPI_S_STATE = 14
 HVM_PARAM_VPT_ALIGN    = 16
+HVM_PARAM_CONSOLE_PFN  = 17
 HVM_PARAM_NESTEDHVM    = 24 # x86
 
 restart_modes = [
diff -r abc689ef19c2 -r 866498ce4469 tools/python/xen/xend/image.py
--- a/tools/python/xen/xend/image.py	Fri Feb 10 11:27:30 2012 +0000
+++ b/tools/python/xen/xend/image.py	Fri Feb 10 12:05:24 2012 +0000
@@ -971,6 +971,13 @@ class HVMImageHandler(ImageHandler):
         xc.hvm_set_param(self.vm.getDomid(), HVM_PARAM_STORE_EVTCHN,
                          store_evtchn)
 
+        console_mfn = xc.hvm_get_param(self.vm.getDomid(), HVM_PARAM_CONSOLE_PFN)
+        xc.gnttab_hvm_seed(domid = self.vm.getDomid(),
+                           console_gmfn = console_mfn,
+                           xenstore_gmfn = rc['store_mfn'],
+                           console_domid = 0,
+                           xenstore_domid = 0)
+
         return rc

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [xen-unstable test] 11905: regressions - FAIL
  2012-02-10 12:07   ` Ian Campbell
@ 2012-02-10 17:25     ` Ian Jackson
  0 siblings, 0 replies; 4+ messages in thread
From: Ian Jackson @ 2012-02-10 17:25 UTC (permalink / raw)
  To: Ian Campbell; +Cc: Daniel De Graaf, xen-devel

Ian Campbell writes ("Re: [Xen-devel] [xen-unstable test] 11905: regressions - FAIL"):
> On Fri, 2012-02-10 at 09:31 +0000, Ian Campbell wrote:
> > Daniel, I'm afraid I suspect the XS stubdom series for this one. My
> > suspicion is a missing call to seed_grant_table from xend (or from a
> > libxc function which xend uses) which prevents xenstored from mapping
> > the guest's ring, which results in an error from map_interface() in
> > xenstored.
> 
> The following seems to fix it for me. I also tested an HVM migration
> with xm since that seemed like something which might also suffer. It
> seemed ok.

Thanks for debugging this, Ian.  I have applied your patch.

Ian.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-02-10 17:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-10  1:23 [xen-unstable test] 11905: regressions - FAIL xen.org
2012-02-10  9:31 ` Ian Campbell
2012-02-10 12:07   ` Ian Campbell
2012-02-10 17:25     ` Ian Jackson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.