All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: marvell: mcbin: set SFP power limit
@ 2019-05-19  9:21 Baruch Siach
  2019-05-19  9:21 ` [PATCH 2/2] arm64: dts: marvell: clearfog-gt-8k: " Baruch Siach
  0 siblings, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2019-05-19  9:21 UTC (permalink / raw)
  To: Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth
  Cc: Baruch Siach, Russell King, linux-arm-kernel

The Macchitobin board is capable of supplying power up to 2A to SFP
modules. Make that explicit in the device-tree. Without this property
current kernel does not allow SFP modules that require more than 1A.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
index 329f8ceeebea..70b495175c8e 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi
@@ -76,6 +76,7 @@
 		tx-fault-gpio  = <&cp1_gpio1 26 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&cp1_sfpp0_pins>;
+		maximum-power-milliwatt = <2000>;
 	};
 
 	sfp_eth1: sfp-eth1 {
@@ -88,6 +89,7 @@
 		tx-fault-gpio = <&cp0_gpio2 30 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&cp1_sfpp1_pins &cp0_sfpp1_pins>;
+		maximum-power-milliwatt = <2000>;
 	};
 
 	sfp_eth3: sfp-eth3 {
@@ -100,6 +102,7 @@
 		tx-fault-gpio = <&cp0_gpio2 19 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&cp0_sfp_1g_pins &cp1_sfp_1g_pins>;
+		maximum-power-milliwatt = <2000>;
 	};
 };
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 2/2] arm64: dts: marvell: clearfog-gt-8k: set SFP power limit
  2019-05-19  9:21 [PATCH 1/2] arm64: dts: marvell: mcbin: set SFP power limit Baruch Siach
@ 2019-05-19  9:21 ` Baruch Siach
  2019-05-19 18:20   ` Russell King - ARM Linux admin
  0 siblings, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2019-05-19  9:21 UTC (permalink / raw)
  To: Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth
  Cc: Baruch Siach, Russell King, linux-arm-kernel

The Clearfog GT-8K board is capable of supplying power up to 2A to SFP
modules. Make that explicit in the device-tree. Without this property
current kernel does not allow SFP modules that require more than 1A.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
index 9143aa13ceb1..f275d9420d5b 100644
--- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
+++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
@@ -63,6 +63,7 @@
 		tx-disable-gpio = <&cp1_gpio1 29 GPIO_ACTIVE_HIGH>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&cp0_sfp_present_pins &cp1_sfp_tx_disable_pins>;
+		maximum-power-milliwatt = <2000>;
 	};
 
 	leds {
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] arm64: dts: marvell: clearfog-gt-8k: set SFP power limit
  2019-05-19  9:21 ` [PATCH 2/2] arm64: dts: marvell: clearfog-gt-8k: " Baruch Siach
@ 2019-05-19 18:20   ` Russell King - ARM Linux admin
  2019-05-19 18:25     ` Baruch Siach
  0 siblings, 1 reply; 4+ messages in thread
From: Russell King - ARM Linux admin @ 2019-05-19 18:20 UTC (permalink / raw)
  To: Baruch Siach
  Cc: Andrew Lunn, Gregory Clement, Jason Cooper, linux-arm-kernel,
	Sebastian Hesselbarth

On Sun, May 19, 2019 at 12:21:06PM +0300, Baruch Siach wrote:
> The Clearfog GT-8K board is capable of supplying power up to 2A to SFP
> modules. Make that explicit in the device-tree. Without this property
> current kernel does not allow SFP modules that require more than 1A.

I do hope you're aware that current is not the same thing as power!
You say above "2A" which is a current, but the maximum power figure
below is "2W".  Given that modules are supplied with 3.3V, and
Power = Voltage x Current, this really doesn't work out!

Please can you correct both of your patches for accuracy in this
regard, thanks.

> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> index 9143aa13ceb1..f275d9420d5b 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> @@ -63,6 +63,7 @@
>  		tx-disable-gpio = <&cp1_gpio1 29 GPIO_ACTIVE_HIGH>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&cp0_sfp_present_pins &cp1_sfp_tx_disable_pins>;
> +		maximum-power-milliwatt = <2000>;
>  	};
>  
>  	leds {
> -- 
> 2.20.1
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] arm64: dts: marvell: clearfog-gt-8k: set SFP power limit
  2019-05-19 18:20   ` Russell King - ARM Linux admin
@ 2019-05-19 18:25     ` Baruch Siach
  0 siblings, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2019-05-19 18:25 UTC (permalink / raw)
  To: Russell King - ARM Linux admin
  Cc: Andrew Lunn, Gregory Clement, Jason Cooper, linux-arm-kernel,
	Sebastian Hesselbarth

Hi Russell,

On Sun, May 19 2019, Russell King wrote:
> On Sun, May 19, 2019 at 12:21:06PM +0300, Baruch Siach wrote:
>> The Clearfog GT-8K board is capable of supplying power up to 2A to SFP
>> modules. Make that explicit in the device-tree. Without this property
>> current kernel does not allow SFP modules that require more than 1A.
>
> I do hope you're aware that current is not the same thing as power!
> You say above "2A" which is a current, but the maximum power figure
> below is "2W".  Given that modules are supplied with 3.3V, and
> Power = Voltage x Current, this really doesn't work out!
>
> Please can you correct both of your patches for accuracy in this
> regard, thanks.

My bad. I'll fix and resend.

Thanks for reviewing.

baruch

>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>>  arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
>> index 9143aa13ceb1..f275d9420d5b 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
>> +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
>> @@ -63,6 +63,7 @@
>>  		tx-disable-gpio = <&cp1_gpio1 29 GPIO_ACTIVE_HIGH>;
>>  		pinctrl-names = "default";
>>  		pinctrl-0 = <&cp0_sfp_present_pins &cp1_sfp_tx_disable_pins>;
>> +		maximum-power-milliwatt = <2000>;
>>  	};
>>  
>>  	leds {

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-19 18:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-19  9:21 [PATCH 1/2] arm64: dts: marvell: mcbin: set SFP power limit Baruch Siach
2019-05-19  9:21 ` [PATCH 2/2] arm64: dts: marvell: clearfog-gt-8k: " Baruch Siach
2019-05-19 18:20   ` Russell King - ARM Linux admin
2019-05-19 18:25     ` Baruch Siach

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.