All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH mptcp-next] mptcp: fix a DSS option writting error
@ 2022-01-05  9:10 Geliang Tang
  0 siblings, 0 replies; only message in thread
From: Geliang Tang @ 2022-01-05  9:10 UTC (permalink / raw)
  To: mptcp; +Cc: Geliang Tang

'ptr += 1;' was omitted in the orignal code since DSS is the last option.
But now DSS is not the last one, we need to add it.

Fixes: 1bff1e43a30e ("mptcp: optimize out option generation")
Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
 net/mptcp/options.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/mptcp/options.c b/net/mptcp/options.c
index c6726e8389ec..fd6c19b809f8 100644
--- a/net/mptcp/options.c
+++ b/net/mptcp/options.c
@@ -1327,6 +1327,7 @@ void mptcp_write_options(__be32 *ptr, const struct tcp_sock *tp,
 				put_unaligned_be32(mpext->data_len << 16 |
 						   TCPOPT_NOP << 8 | TCPOPT_NOP, ptr);
 			}
+			ptr += 1;
 		}
 	} else if (OPTIONS_MPTCP_MPC & opts->suboptions) {
 		u8 len, flag = MPTCP_CAP_HMAC_SHA256;
-- 
2.31.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-01-05  9:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-05  9:10 [PATCH mptcp-next] mptcp: fix a DSS option writting error Geliang Tang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.