[PATCH] mk: fix extra options when linking lib through compiler

[PATCH] mk: fix extra options when linking lib through compiler

[Thomas Monjalon]

When using a linker option not known by the compiler like -rpath,
the library linkage was failing.
It is fixed by prefixing the option with -Wl, as it is done in other
makefiles.

Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 mk/rte.lib.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
index fcc8e20..06a1519 100644
--- a/mk/rte.lib.mk
+++ b/mk/rte.lib.mk
@@ -68,6 +68,7 @@ ifeq ($(LINK_USING_CC),1)
 # Override the definition of LD here, since we're linking with CC
 LD := $(CC) $(CPU_CFLAGS)
 _CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))
+override EXTRA_LDFLAGS := $(call linkerprefix,$(EXTRA_LDFLAGS))
 else
 _CPU_LDFLAGS := $(CPU_LDFLAGS)
 endif
-- 
2.5.2

Re: [PATCH] mk: fix extra options when linking lib through compiler

[Olivier MATZ]

Hi,

On 11/20/2015 03:02 PM, Thomas Monjalon wrote:
> When using a linker option not known by the compiler like -rpath,
> the library linkage was failing.
> It is fixed by prefixing the option with -Wl, as it is done in other
> makefiles.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  mk/rte.lib.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
> index fcc8e20..06a1519 100644
> --- a/mk/rte.lib.mk
> +++ b/mk/rte.lib.mk
> @@ -68,6 +68,7 @@ ifeq ($(LINK_USING_CC),1)
>  # Override the definition of LD here, since we're linking with CC
>  LD := $(CC) $(CPU_CFLAGS)
>  _CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS))
> +override EXTRA_LDFLAGS := $(call linkerprefix,$(EXTRA_LDFLAGS))
>  else
>  _CPU_LDFLAGS := $(CPU_LDFLAGS)
>  endif
> 

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Re: [PATCH] mk: fix extra options when linking lib through compiler

[Thomas Monjalon]

2015-11-20 16:40, Olivier MATZ:
> On 11/20/2015 03:02 PM, Thomas Monjalon wrote:
> > When using a linker option not known by the compiler like -rpath,
> > the library linkage was failing.
> > It is fixed by prefixing the option with -Wl, as it is done in other
> > makefiles.
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied