All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] scsi: ufs: ufshpb: Remove unused parameters
       [not found] <CGME20210901005350epcas1p10781b465ef299afd8b2f69e78b39cf5c@epcas1p1.samsung.com>
@ 2021-09-01  0:46 ` Chanwoo Lee
       [not found]   ` <CGME20210901005350epcas1p10781b465ef299afd8b2f69e78b39cf5c@epcms2p3>
  0 siblings, 1 reply; 2+ messages in thread
From: Chanwoo Lee @ 2021-09-01  0:46 UTC (permalink / raw)
  To: alim.akhtar, avri.altman, jejb, martin.petersen, daejun7.park,
	beanhuo, stanley.chu, keosung.park, linux-scsi, linux-kernel
  Cc: grant.jung, jt77.jang, dh0421.hwang, sh043.lee, ChanWoo Lee

From: ChanWoo Lee <cw9316.lee@samsung.com>

The following parameters are not used in the function.
So, remove unused parameters.

*func(): ufshpb_set_hpb_read_to_upiu
 -> struct ufshpb_lu *hpb
 -> u32 lpn

Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>

---
v1->v2:
 * edit description.
---
 drivers/scsi/ufs/ufshpb.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index 02fb51ae8b25..589af5f6b940 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -333,9 +333,8 @@ ufshpb_get_pos_from_lpn(struct ufshpb_lu *hpb, unsigned long lpn, int *rgn_idx,
 }
 
 static void
-ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshpb_lu *hpb,
-			    struct ufshcd_lrb *lrbp, u32 lpn, __be64 ppn,
-			    u8 transfer_len, int read_id)
+ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp,
+			    __be64 ppn, u8 transfer_len, int read_id)
 {
 	unsigned char *cdb = lrbp->cmd->cmnd;
 	__be64 ppn_tmp = ppn;
@@ -703,8 +702,7 @@ int ufshpb_prep(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
 		}
 	}
 
-	ufshpb_set_hpb_read_to_upiu(hba, hpb, lrbp, lpn, ppn, transfer_len,
-				    read_id);
+	ufshpb_set_hpb_read_to_upiu(hba, lrbp, ppn, transfer_len, read_id);
 
 	hpb->stats.hit_cnt++;
 	return 0;
-- 
2.29.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH v2] scsi: ufs: ufshpb: Remove unused parameters
       [not found]   ` <CGME20210901005350epcas1p10781b465ef299afd8b2f69e78b39cf5c@epcms2p3>
@ 2021-09-01  2:02     ` Daejun Park
  0 siblings, 0 replies; 2+ messages in thread
From: Daejun Park @ 2021-09-01  2:02 UTC (permalink / raw)
  To: ChanWoo Lee, ALIM AKHTAR, avri.altman, jejb, martin.petersen,
	beanhuo, stanley.chu, Keoseong Park, linux-scsi, linux-kernel
  Cc: wonsuk Jung, Jin-Tae Jang, Doo-Hyun Hwang, Seunghui Lee

Hi ChanWoo Lee,

>From: ChanWoo Lee <cw9316.lee@samsung.com>
> 
>The following parameters are not used in the function.
>So, remove unused parameters.
> 
>*func(): ufshpb_set_hpb_read_to_upiu
> -> struct ufshpb_lu *hpb
> -> u32 lpn
> 
>Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>

Please add Bart's tag above your signed-off tag.

Reviewed-by: Daejun Park <daejun7.park@samsung.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-01  2:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20210901005350epcas1p10781b465ef299afd8b2f69e78b39cf5c@epcas1p1.samsung.com>
2021-09-01  0:46 ` [PATCH v2] scsi: ufs: ufshpb: Remove unused parameters Chanwoo Lee
     [not found]   ` <CGME20210901005350epcas1p10781b465ef299afd8b2f69e78b39cf5c@epcms2p3>
2021-09-01  2:02     ` Daejun Park

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.