From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Yao Yuan <yao.yuan@freescale.com>,
"vinod.koul@intel.com" <vinod.koul@intel.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stefan@agner.ch" <stefan@agner.ch>
Subject: Re: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support
Date: Wed, 15 Jul 2015 16:54:33 +0200 [thread overview]
Message-ID: <2042080.Y9rzRSQLpW@wuerfel> (raw)
In-Reply-To: <BL2PR03MB338DF493E475876FF6C6038839A0@BL2PR03MB338.namprd03.prod.outlook.com>
On Wednesday 15 July 2015 10:29:55 Yao Yuan wrote:
> Hi Arnd,
>
> Thanks for your review.
> And can you give me more information?
> In my opinion, The fsl_edma_pm_state will just be used when CONFIG_PM support. So why not use the #ifdefs to remove the
> unnecessary code? Since the PM will not be selected in many use cases.
I would consider code readability more important than saving a
few instructions, and the #ifdef interrupts the reading flow.
Another aspect is that the compiler does not produce warnings
for incorrect code in an #ifdef, so we try to use e.g. 'if (IS_ENABLED(CONFIG_FOO))'
instead of '#ifdef CONFIG_FOO' wherever possible.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support
Date: Wed, 15 Jul 2015 16:54:33 +0200 [thread overview]
Message-ID: <2042080.Y9rzRSQLpW@wuerfel> (raw)
In-Reply-To: <BL2PR03MB338DF493E475876FF6C6038839A0@BL2PR03MB338.namprd03.prod.outlook.com>
On Wednesday 15 July 2015 10:29:55 Yao Yuan wrote:
> Hi Arnd,
>
> Thanks for your review.
> And can you give me more information?
> In my opinion, The fsl_edma_pm_state will just be used when CONFIG_PM support. So why not use the #ifdefs to remove the
> unnecessary code? Since the PM will not be selected in many use cases.
I would consider code readability more important than saving a
few instructions, and the #ifdef interrupts the reading flow.
Another aspect is that the compiler does not produce warnings
for incorrect code in an #ifdef, so we try to use e.g. 'if (IS_ENABLED(CONFIG_FOO))'
instead of '#ifdef CONFIG_FOO' wherever possible.
Arnd
next prev parent reply other threads:[~2015-07-15 14:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 9:32 Yuan Yao
2015-07-15 9:32 ` No subject Yuan Yao
2015-07-15 9:32 ` [PATCH] dmaengine: fsl-edma: add PM suspend/resume support Yuan Yao
2015-07-15 9:32 ` Yuan Yao
2015-07-15 9:56 ` Arnd Bergmann
2015-07-15 9:56 ` Arnd Bergmann
2015-07-15 10:29 ` Yao Yuan
2015-07-15 10:29 ` Yao Yuan
2015-07-15 14:54 ` Arnd Bergmann [this message]
2015-07-15 14:54 ` Arnd Bergmann
2015-07-16 8:01 ` Yao Yuan
2015-07-16 8:01 ` Yao Yuan
2015-07-16 13:24 ` Vinod Koul
2015-07-16 13:24 ` Vinod Koul
2015-07-17 5:41 ` Yao Yuan
2015-07-17 5:41 ` Yao Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2042080.Y9rzRSQLpW@wuerfel \
--to=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan@agner.ch \
--cc=vinod.koul@intel.com \
--cc=yao.yuan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.