* [PATCH] irqdomain: let the output of irq number align from left side
@ 2012-07-17 8:37 Hui Wang
2012-07-17 12:01 ` Lothar Waßmann
0 siblings, 1 reply; 2+ messages in thread
From: Hui Wang @ 2012-07-17 8:37 UTC (permalink / raw)
To: linux-arm-kernel
Except irq number, the rest columns all align from left side, the
output is ugly as following shows,
irq hwirq chip name chip data domain name
29 0x0001d GIC 0x805e1070 /interrupt-<snip>
34 0x00022 GIC 0x805e1070 /interrupt-<snip>
After applying the fix, the output like that,
irq hwirq chip name chip data domain name
29 0x0001d GIC 0x805e1070 /interrupt-<snip>
34 0x00022 GIC 0x805e1070 /interrupt-<snip>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Hui Wang <jason77.wang@gmail.com>
---
This is a trivial output alignment fix, i don't know if Grant
still maintain the irqdomain subsystem, Cced to Mark for a
backup.
kernel/irq/irqdomain.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 41c1564..575e643 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -712,7 +712,7 @@ static int virq_debug_show(struct seq_file *m, void *private)
if (desc->action && desc->action->handler) {
struct irq_chip *chip;
- seq_printf(m, "%5d ", i);
+ seq_printf(m, "%-5d ", i);
seq_printf(m, "0x%05lx ", desc->irq_data.hwirq);
chip = irq_desc_get_chip(desc);
--
1.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] irqdomain: let the output of irq number align from left side
2012-07-17 8:37 [PATCH] irqdomain: let the output of irq number align from left side Hui Wang
@ 2012-07-17 12:01 ` Lothar Waßmann
0 siblings, 0 replies; 2+ messages in thread
From: Lothar Waßmann @ 2012-07-17 12:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
Hui Wang writes:
> Except irq number, the rest columns all align from left side, the
> output is ugly as following shows,
> irq hwirq chip name chip data domain name
> 29 0x0001d GIC 0x805e1070 /interrupt-<snip>
> 34 0x00022 GIC 0x805e1070 /interrupt-<snip>
>
> After applying the fix, the output like that,
> irq hwirq chip name chip data domain name
> 29 0x0001d GIC 0x805e1070 /interrupt-<snip>
> 34 0x00022 GIC 0x805e1070 /interrupt-<snip>
>
I prefer numbers to be right aligned, because that makes numbers with
different numbers of digits easier to read.
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-17 12:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-17 8:37 [PATCH] irqdomain: let the output of irq number align from left side Hui Wang
2012-07-17 12:01 ` Lothar Waßmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.