* [PATCH] pinctrl: sh-pfc: sh7757: Fix duplicate initializer in GPIO pinmux data
@ 2016-06-10 9:58 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2016-06-10 9:58 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Linus Walleij, linux-renesas-soc, linux-sh, linux-gpio,
Geert Uytterhoeven
With C=1:
drivers/pinctrl/sh-pfc/pfc-sh7757.c:1613:9: warning: Initializer entry defined twice
drivers/pinctrl/sh-pfc/pfc-sh7757.c:1628:9: also defined here
Remove the duplicate initializer to fix this.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Based on the comment near the definition of A16_MARK, which states A16
belongs to the "PTV" section.
I do not have a sh7757 datasheet.
---
drivers/pinctrl/sh-pfc/pfc-sh7757.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/sh-pfc/pfc-sh7757.c b/drivers/pinctrl/sh-pfc/pfc-sh7757.c
index 0555a1fe076ed353..6d8c31caefc105e0 100644
--- a/drivers/pinctrl/sh-pfc/pfc-sh7757.c
+++ b/drivers/pinctrl/sh-pfc/pfc-sh7757.c
@@ -1625,7 +1625,6 @@ static const struct pinmux_func pinmux_func_gpios[] = {
GPIO_FN(VBIOS_CS),
/* PTW (mobule: LBSC, EVC, SCIF) */
- GPIO_FN(A16),
GPIO_FN(A15),
GPIO_FN(A14),
GPIO_FN(A13),
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] pinctrl: sh-pfc: sh7757: Fix duplicate initializer in GPIO pinmux data
@ 2016-06-10 9:58 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2016-06-10 9:58 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Linus Walleij, linux-renesas-soc, linux-sh, linux-gpio,
Geert Uytterhoeven
With C=1:
drivers/pinctrl/sh-pfc/pfc-sh7757.c:1613:9: warning: Initializer entry defined twice
drivers/pinctrl/sh-pfc/pfc-sh7757.c:1628:9: also defined here
Remove the duplicate initializer to fix this.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Based on the comment near the definition of A16_MARK, which states A16
belongs to the "PTV" section.
I do not have a sh7757 datasheet.
---
drivers/pinctrl/sh-pfc/pfc-sh7757.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/sh-pfc/pfc-sh7757.c b/drivers/pinctrl/sh-pfc/pfc-sh7757.c
index 0555a1fe076ed353..6d8c31caefc105e0 100644
--- a/drivers/pinctrl/sh-pfc/pfc-sh7757.c
+++ b/drivers/pinctrl/sh-pfc/pfc-sh7757.c
@@ -1625,7 +1625,6 @@ static const struct pinmux_func pinmux_func_gpios[] = {
GPIO_FN(VBIOS_CS),
/* PTW (mobule: LBSC, EVC, SCIF) */
- GPIO_FN(A16),
GPIO_FN(A15),
GPIO_FN(A14),
GPIO_FN(A13),
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: sh-pfc: sh7757: Fix duplicate initializer in GPIO pinmux data
2016-06-10 9:58 ` Geert Uytterhoeven
@ 2016-06-10 12:17 ` Laurent Pinchart
-1 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2016-06-10 12:17 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Linus Walleij, linux-renesas-soc, linux-sh, linux-gpio
Hi Geert,
Thank you for the patch.
On Friday 10 Jun 2016 11:58:19 Geert Uytterhoeven wrote:
> With C=1:
>
> drivers/pinctrl/sh-pfc/pfc-sh7757.c:1613:9: warning: Initializer entry
> defined twice drivers/pinctrl/sh-pfc/pfc-sh7757.c:1628:9: also defined
> here
>
> Remove the duplicate initializer to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Based on the comment near the definition of A16_MARK, which states A16
> belongs to the "PTV" section.
>
> I do not have a sh7757 datasheet.
> ---
> drivers/pinctrl/sh-pfc/pfc-sh7757.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-sh7757.c
> b/drivers/pinctrl/sh-pfc/pfc-sh7757.c index
> 0555a1fe076ed353..6d8c31caefc105e0 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-sh7757.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-sh7757.c
> @@ -1625,7 +1625,6 @@ static const struct pinmux_func pinmux_func_gpios[] > { GPIO_FN(VBIOS_CS),
>
> /* PTW (mobule: LBSC, EVC, SCIF) */
> - GPIO_FN(A16),
> GPIO_FN(A15),
> GPIO_FN(A14),
> GPIO_FN(A13),
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: sh-pfc: sh7757: Fix duplicate initializer in GPIO pinmux data
@ 2016-06-10 12:17 ` Laurent Pinchart
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2016-06-10 12:17 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Linus Walleij, linux-renesas-soc, linux-sh, linux-gpio
Hi Geert,
Thank you for the patch.
On Friday 10 Jun 2016 11:58:19 Geert Uytterhoeven wrote:
> With C=1:
>
> drivers/pinctrl/sh-pfc/pfc-sh7757.c:1613:9: warning: Initializer entry
> defined twice drivers/pinctrl/sh-pfc/pfc-sh7757.c:1628:9: also defined
> here
>
> Remove the duplicate initializer to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Based on the comment near the definition of A16_MARK, which states A16
> belongs to the "PTV" section.
>
> I do not have a sh7757 datasheet.
> ---
> drivers/pinctrl/sh-pfc/pfc-sh7757.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-sh7757.c
> b/drivers/pinctrl/sh-pfc/pfc-sh7757.c index
> 0555a1fe076ed353..6d8c31caefc105e0 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-sh7757.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-sh7757.c
> @@ -1625,7 +1625,6 @@ static const struct pinmux_func pinmux_func_gpios[] =
> { GPIO_FN(VBIOS_CS),
>
> /* PTW (mobule: LBSC, EVC, SCIF) */
> - GPIO_FN(A16),
> GPIO_FN(A15),
> GPIO_FN(A14),
> GPIO_FN(A13),
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-10 12:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-10 9:58 [PATCH] pinctrl: sh-pfc: sh7757: Fix duplicate initializer in GPIO pinmux data Geert Uytterhoeven
2016-06-10 9:58 ` Geert Uytterhoeven
2016-06-10 12:17 ` Laurent Pinchart
2016-06-10 12:17 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.