From: Arnd Bergmann <arnd@arndb.de>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Axel Lin <axel.lin@ingics.com>,
Hans de Goede <hdegoede@redhat.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org, Alban Bedel <albeu@free.fr>
Subject: Re: [PATCH 01/10] reset: ath79: add driver Kconfig option
Date: Wed, 24 Aug 2016 17:51:06 +0200 [thread overview]
Message-ID: <20643424.8eBLZWavEG@wuerfel> (raw)
In-Reply-To: <1472045342-7434-1-git-send-email-p.zabel@pengutronix.de>
On Wednesday, August 24, 2016 3:28:53 PM CEST Philipp Zabel wrote:
> if RESET_CONTROLLER
>
> +config RESET_ATH79
> + bool "AR71xx Reset Driver" if COMPILE_TEST
> + default ATH79
> + help
> + This enables the ATH79 reset controller driver that supports the
> + AR71xx SoC reset controller.
> +
>
Nice series!
Just note that there is one possible problem with COMPILE_TEST
when the platforms are enabled, as you can then disable a driver
that is normally there, and that can in turn cause problems in
rare cases, e.g. when the driver has a global function that is
called from platform code. I don't know if any of the drivers
do that, but if they do, you'd have to use
config RESET_ATH79
bool "AR71xx Reset Driver" if COMPILE_TEST && !ATH79
default ATH79
to ensure that it's impossible to disable the driver on platforms
that require it.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/10] reset: ath79: add driver Kconfig option
Date: Wed, 24 Aug 2016 17:51:06 +0200 [thread overview]
Message-ID: <20643424.8eBLZWavEG@wuerfel> (raw)
In-Reply-To: <1472045342-7434-1-git-send-email-p.zabel@pengutronix.de>
On Wednesday, August 24, 2016 3:28:53 PM CEST Philipp Zabel wrote:
> if RESET_CONTROLLER
>
> +config RESET_ATH79
> + bool "AR71xx Reset Driver" if COMPILE_TEST
> + default ATH79
> + help
> + This enables the ATH79 reset controller driver that supports the
> + AR71xx SoC reset controller.
> +
>
Nice series!
Just note that there is one possible problem with COMPILE_TEST
when the platforms are enabled, as you can then disable a driver
that is normally there, and that can in turn cause problems in
rare cases, e.g. when the driver has a global function that is
called from platform code. I don't know if any of the drivers
do that, but if they do, you'd have to use
config RESET_ATH79
bool "AR71xx Reset Driver" if COMPILE_TEST && !ATH79
default ATH79
to ensure that it's impossible to disable the driver on platforms
that require it.
Arnd
next prev parent reply other threads:[~2016-08-24 15:51 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
2016-08-24 13:28 ` Philipp Zabel
2016-08-24 13:28 ` [PATCH 02/10] reset: berlin: " Philipp Zabel
2016-08-24 13:28 ` Philipp Zabel
2016-08-24 17:43 ` Masahiro Yamada
2016-08-24 17:43 ` Masahiro Yamada
2016-08-24 13:28 ` [PATCH 03/10] reset: lpc18xx: " Philipp Zabel
2016-08-24 13:28 ` Philipp Zabel
2016-08-24 17:43 ` Masahiro Yamada
2016-08-24 17:43 ` Masahiro Yamada
2016-08-24 20:32 ` Joachim Eastwood
2016-08-24 20:32 ` Joachim Eastwood
2016-08-25 7:22 ` Philipp Zabel
2016-08-25 7:22 ` Philipp Zabel
2016-08-24 13:28 ` [PATCH 04/10] reset: meson: " Philipp Zabel
2016-08-24 13:28 ` Philipp Zabel
2016-08-24 13:30 ` Neil Armstrong
2016-08-24 13:30 ` Neil Armstrong
2016-08-24 17:43 ` Masahiro Yamada
2016-08-24 17:43 ` Masahiro Yamada
2016-08-24 13:28 ` [PATCH 05/10] reset: pistachio: " Philipp Zabel
2016-08-24 13:28 ` Philipp Zabel
2016-08-24 17:44 ` Masahiro Yamada
2016-08-24 17:44 ` Masahiro Yamada
2016-08-29 20:40 ` James Hartley
2016-08-29 20:40 ` James Hartley
2016-08-24 13:28 ` [PATCH 06/10] reset: socfpga: " Philipp Zabel
2016-08-24 13:28 ` Philipp Zabel
2016-08-24 15:26 ` Dinh Nguyen
2016-08-24 15:26 ` Dinh Nguyen
2016-08-25 7:23 ` Philipp Zabel
2016-08-25 7:23 ` Philipp Zabel
2016-08-24 17:44 ` Masahiro Yamada
2016-08-24 17:44 ` Masahiro Yamada
2016-08-24 13:28 ` [PATCH 07/10] reset: stm32: " Philipp Zabel
2016-08-24 13:28 ` Philipp Zabel
2016-08-24 17:44 ` Masahiro Yamada
2016-08-24 17:44 ` Masahiro Yamada
2016-08-24 13:29 ` [PATCH 08/10] reset: sunxi: " Philipp Zabel
2016-08-24 13:29 ` Philipp Zabel
2016-08-24 17:45 ` Masahiro Yamada
2016-08-24 17:45 ` Masahiro Yamada
2016-08-24 13:29 ` [PATCH 09/10] reset: zynq: " Philipp Zabel
2016-08-24 13:29 ` Philipp Zabel
2016-08-24 17:48 ` Masahiro Yamada
2016-08-24 17:48 ` Masahiro Yamada
2016-08-25 1:08 ` Masahiro Yamada
2016-08-25 1:08 ` Masahiro Yamada
2016-08-25 7:23 ` Philipp Zabel
2016-08-25 7:23 ` Philipp Zabel
2016-08-25 7:31 ` Masahiro Yamada
2016-08-25 7:31 ` Masahiro Yamada
2016-08-25 7:51 ` Philipp Zabel
2016-08-25 7:51 ` Philipp Zabel
2016-08-24 13:29 ` [PATCH 10/10] reset: hi6220: allow to compile test driver on other architectures Philipp Zabel
2016-08-24 13:29 ` Philipp Zabel
2016-08-24 18:00 ` Masahiro Yamada
2016-08-24 18:00 ` Masahiro Yamada
2016-08-25 7:23 ` Philipp Zabel
2016-08-25 7:23 ` Philipp Zabel
2016-08-24 15:51 ` Arnd Bergmann [this message]
2016-08-24 15:51 ` [PATCH 01/10] reset: ath79: add driver Kconfig option Arnd Bergmann
2016-08-24 18:18 ` Masahiro Yamada
2016-08-24 18:18 ` Masahiro Yamada
2016-08-24 20:06 ` Arnd Bergmann
2016-08-24 20:06 ` Arnd Bergmann
2016-08-25 2:43 ` Masahiro Yamada
2016-08-25 2:43 ` Masahiro Yamada
2016-08-25 7:22 ` Philipp Zabel
2016-08-25 7:22 ` Philipp Zabel
2016-08-25 7:27 ` Masahiro Yamada
2016-08-25 7:27 ` Masahiro Yamada
2016-08-25 7:51 ` Philipp Zabel
2016-08-25 7:51 ` Philipp Zabel
2016-08-24 17:42 ` Masahiro Yamada
2016-08-24 17:42 ` Masahiro Yamada
2016-08-25 10:31 ` kbuild test robot
2016-08-25 10:31 ` kbuild test robot
2016-08-25 10:50 ` Arnd Bergmann
2016-08-25 10:50 ` Arnd Bergmann
2016-08-25 10:57 ` Philipp Zabel
2016-08-25 10:57 ` Philipp Zabel
2016-08-25 11:10 ` Alban
2016-08-25 11:10 ` Alban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20643424.8eBLZWavEG@wuerfel \
--to=arnd@arndb.de \
--cc=albeu@free.fr \
--cc=axel.lin@ingics.com \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=p.zabel@pengutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.