All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, rsanford@akamai.com,
	erik.g.carrillo@intel.com, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/timer: fix incorrect time interval
Date: Wed, 21 Apr 2021 20:34:11 +0200	[thread overview]
Message-ID: <2073087.ahSVXVslbx@thomas> (raw)
In-Reply-To: <1618470748-12369-1-git-send-email-humin29@huawei.com>

15/04/2021 09:12, Min Hu (Connor):
> From: Chengchang Tang <tangchengchang@huawei.com>
> 
> Timer sample example assumes that the frequency of the timer is about
> 2Ghz to control the period of calling rte_timer_manage(). But this
> assumption is easy to fail. For example. the frequency of tsc on ARM64
> is much less than 2Ghz.

So rte_timer_manage() will be called less often, yes.

> This patch uses the frequency of the current timer to calculate the
> correct time interval to ensure consistent result on all platforms.

I am not sure about making the example more complex.
What is the issue with the previous value?




  reply	other threads:[~2021-04-21 18:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15  7:12 [dpdk-dev] [PATCH] examples/timer: fix incorrect time interval Min Hu (Connor)
2021-04-21 18:34 ` Thomas Monjalon [this message]
2021-04-22  1:38   ` Chengchang Tang
2021-04-21 19:12 ` Carrillo, Erik G
2021-05-05 21:37 ` Thomas Monjalon
2021-05-06  2:06   ` Chengchang Tang
2021-05-06  8:08     ` Thomas Monjalon
2021-05-06  8:23       ` Chengchang Tang
2021-05-06  9:29 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-05-12 14:40   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2073087.ahSVXVslbx@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=ferruh.yigit@intel.com \
    --cc=humin29@huawei.com \
    --cc=rsanford@akamai.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.