From: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"rsanford@akamai.com" <rsanford@akamai.com>
Subject: Re: [dpdk-dev] [PATCH] examples/timer: fix incorrect time interval
Date: Wed, 21 Apr 2021 19:12:32 +0000 [thread overview]
Message-ID: <SA2PR11MB5196F23969F19FDB98630C95B9479@SA2PR11MB5196.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1618470748-12369-1-git-send-email-humin29@huawei.com>
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Thursday, April 15, 2021 2:12 AM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; rsanford@akamai.com; Carrillo,
> Erik G <erik.g.carrillo@intel.com>
> Subject: [PATCH] examples/timer: fix incorrect time interval
>
> From: Chengchang Tang <tangchengchang@huawei.com>
>
> Timer sample example assumes that the frequency of the timer is about
> 2Ghz to control the period of calling rte_timer_manage(). But this
> assumption is easy to fail. For example. the frequency of tsc on ARM64 is
> much less than 2Ghz.
>
> This patch uses the frequency of the current timer to calculate the correct
> time interval to ensure consistent result on all platforms.
>
> In addition, the rte_rdtsc() is replaced with the more recommended
> rte_get_timer_cycles function in this patch.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
This LGTM - thanks.
Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
next prev parent reply other threads:[~2021-04-21 19:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 7:12 [dpdk-dev] [PATCH] examples/timer: fix incorrect time interval Min Hu (Connor)
2021-04-21 18:34 ` Thomas Monjalon
2021-04-22 1:38 ` Chengchang Tang
2021-04-21 19:12 ` Carrillo, Erik G [this message]
2021-05-05 21:37 ` Thomas Monjalon
2021-05-06 2:06 ` Chengchang Tang
2021-05-06 8:08 ` Thomas Monjalon
2021-05-06 8:23 ` Chengchang Tang
2021-05-06 9:29 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-05-12 14:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA2PR11MB5196F23969F19FDB98630C95B9479@SA2PR11MB5196.namprd11.prod.outlook.com \
--to=erik.g.carrillo@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
--cc=rsanford@akamai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.