From: Sujith Manoharan <sujith@msujith.org>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Adrian Chadd <adrian@freebsd.org>,
Bob Copeland <me@bobcopeland.com>,
"Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>,
Paul Stewart <pstew@google.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] ath9k: remove ath9k_rate_control
Date: Fri, 1 Mar 2013 06:53:08 +0530 [thread overview]
Message-ID: <20784.764.675035.560161@gargle.gargle.HOWL> (raw)
In-Reply-To: <512FAB01.2050104@openwrt.org>
Felix Fietkau wrote:
> In that case I'd rather keep PID than the ath9k rate control. The ath9k
> rate control is a horrible example of how to use the rate control API,
> and fixing that is a waste of time in my opinion.
I acked the earlier RFC patch to remove the ath9k RC as I assumed that minstrel_ht
would perform adequately, if not better. But, there appear to be areas in which
the numbers given by minstrel_ht are sub-optimal and which can be improved if we
have something to compare it with. The ath9k RC code is crap, no doubt, but I'd
prefer to have it for some time in the tree - we can switch the default RC to minstrel_ht
by default.
Can you also explain how the ath9k RC uses the mac80211 API horribly ? The algorithm might be
terribly implemented and the internal code nasty, but how does it violate the API ?
Sujith
next prev parent reply other threads:[~2013-03-01 1:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 13:13 [RFC] ath9k: remove ath9k_rate_control Felix Fietkau
2013-02-08 13:30 ` Sujith Manoharan
2013-02-08 14:04 ` Felix Fietkau
2013-02-08 14:06 ` Sujith Manoharan
2013-02-08 14:08 ` Sujith Manoharan
2013-02-08 14:16 ` Felix Fietkau
2013-02-08 16:38 ` Paul Stewart
2013-02-08 16:53 ` Felix Fietkau
2013-02-27 19:20 ` Luis R. Rodriguez
2013-02-28 2:21 ` Adrian Chadd
2013-02-28 3:24 ` Felix Fietkau
2013-02-28 3:54 ` Sujith Manoharan
2013-02-28 4:32 ` Felix Fietkau
2013-02-28 5:08 ` Sujith Manoharan
2013-03-01 14:31 ` Sujith Manoharan
2013-03-01 15:35 ` Ben Greear
2013-03-01 21:23 ` Adrian Chadd
2013-03-01 21:28 ` Adrian Chadd
2013-03-02 2:19 ` Sujith Manoharan
2013-03-02 5:40 ` Adrian Chadd
2013-03-02 8:26 ` Georgiewskiy Yuriy
2013-03-02 20:23 ` Felix Fietkau
2013-03-03 3:58 ` Sujith Manoharan
2013-02-28 11:47 ` Bob Copeland
2013-02-28 13:09 ` Felix Fietkau
2013-02-28 18:53 ` Adrian Chadd
2013-02-28 19:07 ` Felix Fietkau
2013-03-01 1:23 ` Sujith Manoharan [this message]
2013-03-01 10:09 ` Felix Fietkau
2013-03-01 3:53 ` Adrian Chadd
2013-03-01 10:14 ` Felix Fietkau
2013-03-01 10:22 ` Adrian Chadd
2013-03-01 10:29 ` Felix Fietkau
2013-03-01 11:18 ` Mohammed Shafi
2013-03-01 11:31 ` Felix Fietkau
2013-03-01 12:32 ` Mohammed Shafi
2013-03-01 13:05 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20784.764.675035.560161@gargle.gargle.HOWL \
--to=sujith@msujith.org \
--cc=adrian@freebsd.org \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=nbd@openwrt.org \
--cc=pstew@google.com \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.