From: Yangtao Li <frank.li@vivo.com> To: "Krzysztof Kozlowski" <krzk@kernel.org>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, miquel.raynal@bootlin.com Cc: miquel.raynal@bootlin.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com, tglx@linutronix.de, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, bchihi@baylibre.com, wenst@chromium.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v3 1/5] genirq/devres: Add devm_request_threaded_irq_emsg() Date: Tue, 4 Jul 2023 17:06:12 +0800 [thread overview] Message-ID: <20805fef-d6aa-91d8-999e-04b1d6b7a37a@vivo.com> (raw) In-Reply-To: <11052797-b006-11bb-e4eb-987ddd568b24@kernel.org> On 2023/7/4 16:48, Krzysztof Kozlowski wrote: > [你通常不会收到来自 krzk@kernel.org 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification,以了解这一点为什么很重要] > > On 03/07/2023 19:43, Uwe Kleine-König wrote: >> Hello Krzysztof, >> >> On Mon, Jul 03, 2023 at 02:31:59PM +0200, Krzysztof Kozlowski wrote: >>> On 03/07/2023 11:04, Yangtao Li wrote: >>>> There are more than 700 calls to the devm_request_threaded_irq method. >>>> Most drivers only request one interrupt resource, and these error >>>> messages are basically the same. If error messages are printed >>>> everywhere, more than 1000 lines of code can be saved by removing the >>>> msg in the driver. >>> >>> ... >>> >>>> +int devm_request_threaded_irq_emsg(struct device *dev, unsigned int irq, >>>> + irq_handler_t handler, irq_handler_t thread_fn, >>>> + unsigned long irqflags, const char *devname, >>>> + void *dev_id, const char *emsg) >>>> +{ >>>> + int rc; >>>> + >>>> + rc = devm_request_threaded_irq(dev, irq, handler, NULL, irqflags, >>>> + devname, dev_id); >>>> + if (rc && rc != -EPROBE_DEFER) { >>>> + dev_err(dev, "Failed to request %sinterrupt %u %s %s: %pe\n", >>>> + thread_fn ? "threaded " : "", irq, devname ? : dev_name(dev), >>>> + emsg ? : "", ERR_PTR(rc)); >>> It is open-coding dev_err_probe(). Just use dev_err_probe instead. >> dev_err_probe is supposed to be only called in probe functions, while >> devm_request_threaded_irq might be called in other contexts (e.g. when a >> device is opened). That's why I asked to not use dev_err_probe() in v2 > True, but then all the callers of this function will forget to set > deferred probe reason. So let's use dev_err_probe? BTW, any suggestions for names here, keep using devm_request_threaded_irq_emsg or change to a new name? I am afraid that after more drivers are changed in the follow-up series, the name will need to be changed again. Thx, Yangtao > > Best regards, > Krzysztof >
WARNING: multiple messages have this Message-ID (diff)
From: Yangtao Li <frank.li@vivo.com> To: "Krzysztof Kozlowski" <krzk@kernel.org>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, miquel.raynal@bootlin.com Cc: miquel.raynal@bootlin.com, rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com, tglx@linutronix.de, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, bchihi@baylibre.com, wenst@chromium.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v3 1/5] genirq/devres: Add devm_request_threaded_irq_emsg() Date: Tue, 4 Jul 2023 17:06:12 +0800 [thread overview] Message-ID: <20805fef-d6aa-91d8-999e-04b1d6b7a37a@vivo.com> (raw) In-Reply-To: <11052797-b006-11bb-e4eb-987ddd568b24@kernel.org> On 2023/7/4 16:48, Krzysztof Kozlowski wrote: > [你通常不会收到来自 krzk@kernel.org 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification,以了解这一点为什么很重要] > > On 03/07/2023 19:43, Uwe Kleine-König wrote: >> Hello Krzysztof, >> >> On Mon, Jul 03, 2023 at 02:31:59PM +0200, Krzysztof Kozlowski wrote: >>> On 03/07/2023 11:04, Yangtao Li wrote: >>>> There are more than 700 calls to the devm_request_threaded_irq method. >>>> Most drivers only request one interrupt resource, and these error >>>> messages are basically the same. If error messages are printed >>>> everywhere, more than 1000 lines of code can be saved by removing the >>>> msg in the driver. >>> >>> ... >>> >>>> +int devm_request_threaded_irq_emsg(struct device *dev, unsigned int irq, >>>> + irq_handler_t handler, irq_handler_t thread_fn, >>>> + unsigned long irqflags, const char *devname, >>>> + void *dev_id, const char *emsg) >>>> +{ >>>> + int rc; >>>> + >>>> + rc = devm_request_threaded_irq(dev, irq, handler, NULL, irqflags, >>>> + devname, dev_id); >>>> + if (rc && rc != -EPROBE_DEFER) { >>>> + dev_err(dev, "Failed to request %sinterrupt %u %s %s: %pe\n", >>>> + thread_fn ? "threaded " : "", irq, devname ? : dev_name(dev), >>>> + emsg ? : "", ERR_PTR(rc)); >>> It is open-coding dev_err_probe(). Just use dev_err_probe instead. >> dev_err_probe is supposed to be only called in probe functions, while >> devm_request_threaded_irq might be called in other contexts (e.g. when a >> device is opened). That's why I asked to not use dev_err_probe() in v2 > True, but then all the callers of this function will forget to set > deferred probe reason. So let's use dev_err_probe? BTW, any suggestions for names here, keep using devm_request_threaded_irq_emsg or change to a new name? I am afraid that after more drivers are changed in the follow-up series, the name will need to be changed again. Thx, Yangtao > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-04 9:06 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-03 9:04 [PATCH v3 0/5] introduce devm_request_threaded_irq_emsg() Yangtao Li 2023-07-03 9:04 ` Yangtao Li 2023-07-03 9:04 ` [PATCH v3 1/5] genirq/devres: Add devm_request_threaded_irq_emsg() Yangtao Li 2023-07-03 9:04 ` Yangtao Li 2023-07-03 12:31 ` Krzysztof Kozlowski 2023-07-03 12:31 ` Krzysztof Kozlowski 2023-07-03 13:24 ` Yangtao Li 2023-07-03 13:24 ` Yangtao Li 2023-07-03 13:37 ` Krzysztof Kozlowski 2023-07-03 13:37 ` Krzysztof Kozlowski 2023-07-03 17:43 ` Uwe Kleine-König 2023-07-03 17:43 ` Uwe Kleine-König 2023-07-04 8:48 ` Krzysztof Kozlowski 2023-07-04 8:48 ` Krzysztof Kozlowski 2023-07-04 9:06 ` Yangtao Li [this message] 2023-07-04 9:06 ` Yangtao Li 2023-07-04 14:19 ` Uwe Kleine-König 2023-07-04 14:19 ` Uwe Kleine-König 2023-07-05 2:15 ` Jonathan Cameron 2023-07-05 2:15 ` Jonathan Cameron 2023-07-05 7:30 ` Uwe Kleine-König 2023-07-05 7:30 ` Uwe Kleine-König 2023-07-05 7:43 ` Yangtao Li 2023-07-05 7:43 ` Yangtao Li 2023-07-05 7:49 ` Yangtao Li 2023-07-05 7:49 ` Yangtao Li 2023-07-05 10:14 ` AngeloGioacchino Del Regno 2023-07-05 10:14 ` AngeloGioacchino Del Regno 2023-07-03 9:04 ` [PATCH v3 2/5] thermal/drivers/armada: convert to use devm_request_threaded_irq_emsg() Yangtao Li 2023-07-03 9:04 ` Yangtao Li 2023-07-04 8:46 ` Miquel Raynal 2023-07-04 8:46 ` Miquel Raynal 2023-07-04 14:22 ` Uwe Kleine-König 2023-07-04 14:22 ` Uwe Kleine-König 2023-07-04 14:29 ` Miquel Raynal 2023-07-04 14:29 ` Miquel Raynal 2023-07-03 9:04 ` [PATCH v3 3/5] thermal/drivers/brcmstb_thermal: " Yangtao Li 2023-07-03 9:04 ` Yangtao Li 2023-07-03 9:04 ` [PATCH v3 4/5] thermal/drivers/db8500: " Yangtao Li 2023-07-03 9:04 ` Yangtao Li 2023-07-03 9:04 ` [PATCH v3 5/5] thermal/drivers/mediatek/lvts_thermal: " Yangtao Li 2023-07-03 9:04 ` Yangtao Li 2023-07-03 11:47 ` [PATCH v3 0/5] introduce devm_request_threaded_irq_emsg() Yangtao Li 2023-07-03 11:47 ` Yangtao Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20805fef-d6aa-91d8-999e-04b1d6b7a37a@vivo.com \ --to=frank.li@vivo.com \ --cc=amitk@kernel.org \ --cc=angelogioacchino.delregno@collabora.com \ --cc=bchihi@baylibre.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=daniel.lezcano@linaro.org \ --cc=florian.fainelli@broadcom.com \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=matthias.bgg@gmail.com \ --cc=miquel.raynal@bootlin.com \ --cc=mmayer@broadcom.com \ --cc=rafael@kernel.org \ --cc=rui.zhang@intel.com \ --cc=tglx@linutronix.de \ --cc=u.kleine-koenig@pengutronix.de \ --cc=wenst@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.