All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: YangHaibo <b40869@freescale.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-networking][PATCH] pimd: add recipe for pimd-2.1.8
Date: Tue, 16 Sep 2014 18:32:05 +0100	[thread overview]
Message-ID: <2081672.Qnn2s3x9XX@peggleto-mobl5.ger.corp.intel.com> (raw)
In-Reply-To: <1410835738-27343-1-git-send-email-b40869@freescale.com>

Hi there,

On Tuesday 16 September 2014 10:48:58 YangHaibo wrote:
> Signed-off-by: YangHaibo <b40869@freescale.com>
> ---
>  meta-networking/recipes-support/pimd/pimd_2.1.8.bb | 9 +++++++++
>  1 file changed, 9 insertions(+)
>  create mode 100644 meta-networking/recipes-support/pimd/pimd_2.1.8.bb
> 
> diff --git a/meta-networking/recipes-support/pimd/pimd_2.1.8.bb
> b/meta-networking/recipes-support/pimd/pimd_2.1.8.bb new file mode 100644
> index 0000000..4d1137f
> --- /dev/null
> +++ b/meta-networking/recipes-support/pimd/pimd_2.1.8.bb
> @@ -0,0 +1,9 @@
> +DESCRIPTION = "pimd is a lightweight stand-alone PIM-SM v2 multicast
> routing daemon." 

Please set SUMMARY for one-line descriptions like this.

> +HOMEPAGE = "http://troglobit.com/pimd.html"
> +LICENSE = "BSD"

Please be specific and say "BSD-3-Clause" (since that appears to be the variant 
upstream is using).

> +LIC_FILES_CHKSUM = "file://LICENSE;md5=94f108f91fab720d62425770b70dd790"
> +
> +SRC_URI = "ftp://troglobit.com/pimd/pimd-2.1.8.tar.bz2"

Please use ${PV} instead of hardcoding 2.1.8 .

> +SRC_URI[md5sum] = "a12448bc7c9bfcebf51a13ebf1ffa962"

Please also add a sha256sum.

> +CFLAGS_prepend = "-I ${S}/include "

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


  reply	other threads:[~2014-09-16 17:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16  2:48 [meta-networking][PATCH] pimd: add recipe for pimd-2.1.8 YangHaibo
2014-09-16 17:32 ` Paul Eggleton [this message]
2014-09-19  4:43 ` Khem Raj
2014-09-19  5:59   ` B40869

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2081672.Qnn2s3x9XX@peggleto-mobl5.ger.corp.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=b40869@freescale.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.