All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-networking][PATCH] pimd: add recipe for pimd-2.1.8
@ 2014-09-16  2:48 YangHaibo
  2014-09-16 17:32 ` Paul Eggleton
  2014-09-19  4:43 ` Khem Raj
  0 siblings, 2 replies; 4+ messages in thread
From: YangHaibo @ 2014-09-16  2:48 UTC (permalink / raw)
  To: openembedded-devel; +Cc: YangHaibo

Signed-off-by: YangHaibo <b40869@freescale.com>
---
 meta-networking/recipes-support/pimd/pimd_2.1.8.bb | 9 +++++++++
 1 file changed, 9 insertions(+)
 create mode 100644 meta-networking/recipes-support/pimd/pimd_2.1.8.bb

diff --git a/meta-networking/recipes-support/pimd/pimd_2.1.8.bb b/meta-networking/recipes-support/pimd/pimd_2.1.8.bb
new file mode 100644
index 0000000..4d1137f
--- /dev/null
+++ b/meta-networking/recipes-support/pimd/pimd_2.1.8.bb
@@ -0,0 +1,9 @@
+DESCRIPTION = "pimd is a lightweight stand-alone PIM-SM v2 multicast routing daemon."
+HOMEPAGE = "http://troglobit.com/pimd.html"
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=94f108f91fab720d62425770b70dd790"
+
+SRC_URI = "ftp://troglobit.com/pimd/pimd-2.1.8.tar.bz2"
+SRC_URI[md5sum] = "a12448bc7c9bfcebf51a13ebf1ffa962"
+
+CFLAGS_prepend = "-I ${S}/include "
-- 
1.9.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [meta-networking][PATCH] pimd: add recipe for pimd-2.1.8
  2014-09-16  2:48 [meta-networking][PATCH] pimd: add recipe for pimd-2.1.8 YangHaibo
@ 2014-09-16 17:32 ` Paul Eggleton
  2014-09-19  4:43 ` Khem Raj
  1 sibling, 0 replies; 4+ messages in thread
From: Paul Eggleton @ 2014-09-16 17:32 UTC (permalink / raw)
  To: YangHaibo; +Cc: openembedded-devel

Hi there,

On Tuesday 16 September 2014 10:48:58 YangHaibo wrote:
> Signed-off-by: YangHaibo <b40869@freescale.com>
> ---
>  meta-networking/recipes-support/pimd/pimd_2.1.8.bb | 9 +++++++++
>  1 file changed, 9 insertions(+)
>  create mode 100644 meta-networking/recipes-support/pimd/pimd_2.1.8.bb
> 
> diff --git a/meta-networking/recipes-support/pimd/pimd_2.1.8.bb
> b/meta-networking/recipes-support/pimd/pimd_2.1.8.bb new file mode 100644
> index 0000000..4d1137f
> --- /dev/null
> +++ b/meta-networking/recipes-support/pimd/pimd_2.1.8.bb
> @@ -0,0 +1,9 @@
> +DESCRIPTION = "pimd is a lightweight stand-alone PIM-SM v2 multicast
> routing daemon." 

Please set SUMMARY for one-line descriptions like this.

> +HOMEPAGE = "http://troglobit.com/pimd.html"
> +LICENSE = "BSD"

Please be specific and say "BSD-3-Clause" (since that appears to be the variant 
upstream is using).

> +LIC_FILES_CHKSUM = "file://LICENSE;md5=94f108f91fab720d62425770b70dd790"
> +
> +SRC_URI = "ftp://troglobit.com/pimd/pimd-2.1.8.tar.bz2"

Please use ${PV} instead of hardcoding 2.1.8 .

> +SRC_URI[md5sum] = "a12448bc7c9bfcebf51a13ebf1ffa962"

Please also add a sha256sum.

> +CFLAGS_prepend = "-I ${S}/include "

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [meta-networking][PATCH] pimd: add recipe for pimd-2.1.8
  2014-09-16  2:48 [meta-networking][PATCH] pimd: add recipe for pimd-2.1.8 YangHaibo
  2014-09-16 17:32 ` Paul Eggleton
@ 2014-09-19  4:43 ` Khem Raj
  2014-09-19  5:59   ` B40869
  1 sibling, 1 reply; 4+ messages in thread
From: Khem Raj @ 2014-09-19  4:43 UTC (permalink / raw)
  To: openembeded-devel; +Cc: YangHaibo

On Mon, Sep 15, 2014 at 7:48 PM, YangHaibo <b40869@freescale.com> wrote:
> +CFLAGS_prepend = "-I ${S}/include "

why is prepend needed  += would be better


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [meta-networking][PATCH] pimd: add recipe for pimd-2.1.8
  2014-09-19  4:43 ` Khem Raj
@ 2014-09-19  5:59   ` B40869
  0 siblings, 0 replies; 4+ messages in thread
From: B40869 @ 2014-09-19  5:59 UTC (permalink / raw)
  To: Khem Raj, openembeded-devel

New patch is sent out. Replace with +=.

BR,
YangHaibo
________________________________________
From: Khem Raj <raj.khem@gmail.com>
Sent: Friday, September 19, 2014 12:43 PM
To: openembeded-devel
Cc: Yang Haibo-B40869
Subject: Re: [oe] [meta-networking][PATCH] pimd: add recipe for pimd-2.1.8

On Mon, Sep 15, 2014 at 7:48 PM, YangHaibo <b40869@freescale.com> wrote:
> +CFLAGS_prepend = "-I ${S}/include "

why is prepend needed  += would be better


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-09-19  5:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-16  2:48 [meta-networking][PATCH] pimd: add recipe for pimd-2.1.8 YangHaibo
2014-09-16 17:32 ` Paul Eggleton
2014-09-19  4:43 ` Khem Raj
2014-09-19  5:59   ` B40869

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.