From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Carlos Hernandez <ceh@ti.com>, Tony Lindgren <tony@atomide.com>, Thomas Gleixner <tglx@linutronix.de> Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Fix suspend and resume for am3 and am4 Date: Tue, 21 Jul 2020 15:49:01 +0200 [thread overview] Message-ID: <2081a11d-8678-03ec-cde4-b4eaae10e82d@linaro.org> (raw) In-Reply-To: <6b5fc12c-4da3-fc67-b9dd-bfca2ae870f2@ti.com> On 21/07/2020 15:11, Carlos Hernandez wrote: > > On 7/17/20 6:29 AM, Daniel Lezcano wrote: >> On 13/07/2020 18:26, Tony Lindgren wrote: >>> Carlos Hernandez <ceh@ti.com> reported that we now have a suspend and >>> resume regresssion on am3 and am4 compared to the earlier kernels. While >>> suspend and resume works with v5.8-rc3, we now get errors with rtcwake: >>> >>> pm33xx pm33xx: PM: Could not transition all powerdomains to target state >>> ... >>> rtcwake: write error >>> >>> This is because we now fail to idle the system timer clocks that the >>> idle code checks and the error gets propagated to the rtcwake. >>> >>> Turns out there are several issues that need to be fixed: >>> >>> 1. Ignore no-idle and no-reset configured timers for the ti-sysc >>> interconnect target driver as otherwise it will keep the system >>> timer >>> clocks enabled >>> >>> 2. Toggle the system timer functional clock for suspend for am3 and am4 >>> (but not for clocksource on am3) >>> >>> 3. Only reconfigure type1 timers in dmtimer_systimer_disable() >>> >>> 4. Use of_machine_is_compatible() instead of of_device_is_compatible() >>> for checking the SoC type >>> >>> Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent >>> and clocksource support") >>> Reported-by: Carlos Hernandez <ceh@ti.com> >>> Signed-off-by: Tony Lindgren <tony@atomide.com> >>> --- > > Tested-by: Carlos Hernandez <ceh@ti.com> Thanks >> Carlos, were you able to test this patch ? >> -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org> To: Carlos Hernandez <ceh@ti.com>, Tony Lindgren <tony@atomide.com>, Thomas Gleixner <tglx@linutronix.de> Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Fix suspend and resume for am3 and am4 Date: Tue, 21 Jul 2020 15:49:01 +0200 [thread overview] Message-ID: <2081a11d-8678-03ec-cde4-b4eaae10e82d@linaro.org> (raw) In-Reply-To: <6b5fc12c-4da3-fc67-b9dd-bfca2ae870f2@ti.com> On 21/07/2020 15:11, Carlos Hernandez wrote: > > On 7/17/20 6:29 AM, Daniel Lezcano wrote: >> On 13/07/2020 18:26, Tony Lindgren wrote: >>> Carlos Hernandez <ceh@ti.com> reported that we now have a suspend and >>> resume regresssion on am3 and am4 compared to the earlier kernels. While >>> suspend and resume works with v5.8-rc3, we now get errors with rtcwake: >>> >>> pm33xx pm33xx: PM: Could not transition all powerdomains to target state >>> ... >>> rtcwake: write error >>> >>> This is because we now fail to idle the system timer clocks that the >>> idle code checks and the error gets propagated to the rtcwake. >>> >>> Turns out there are several issues that need to be fixed: >>> >>> 1. Ignore no-idle and no-reset configured timers for the ti-sysc >>> interconnect target driver as otherwise it will keep the system >>> timer >>> clocks enabled >>> >>> 2. Toggle the system timer functional clock for suspend for am3 and am4 >>> (but not for clocksource on am3) >>> >>> 3. Only reconfigure type1 timers in dmtimer_systimer_disable() >>> >>> 4. Use of_machine_is_compatible() instead of of_device_is_compatible() >>> for checking the SoC type >>> >>> Fixes: 52762fbd1c47 ("clocksource/drivers/timer-ti-dm: Add clockevent >>> and clocksource support") >>> Reported-by: Carlos Hernandez <ceh@ti.com> >>> Signed-off-by: Tony Lindgren <tony@atomide.com> >>> --- > > Tested-by: Carlos Hernandez <ceh@ti.com> Thanks >> Carlos, were you able to test this patch ? >> -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-21 13:49 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-13 16:26 [PATCH] clocksource/drivers/timer-ti-dm: Fix suspend and resume for am3 and am4 Tony Lindgren 2020-07-13 16:26 ` Tony Lindgren 2020-07-15 10:17 ` Grygorii Strashko 2020-07-15 10:17 ` Grygorii Strashko 2020-07-15 17:32 ` Tony Lindgren 2020-07-15 17:32 ` Tony Lindgren 2020-07-15 18:43 ` Grygorii Strashko 2020-07-15 18:43 ` Grygorii Strashko 2020-07-17 10:29 ` Daniel Lezcano 2020-07-17 10:29 ` Daniel Lezcano [not found] ` <f96cb9d8-c940-672a-b1d2-a26570d6f775@ti.com> 2020-07-20 13:56 ` Carlos Hernandez 2020-07-20 13:56 ` Carlos Hernandez 2020-07-20 14:30 ` Tony Lindgren 2020-07-20 14:30 ` Tony Lindgren 2020-07-21 3:35 ` Sekhar Nori 2020-07-21 3:35 ` Sekhar Nori 2020-07-21 13:11 ` Carlos Hernandez 2020-07-21 13:11 ` Carlos Hernandez 2020-07-21 13:49 ` Daniel Lezcano [this message] 2020-07-21 13:49 ` Daniel Lezcano 2020-07-21 16:15 ` [tip: timers/urgent] " tip-bot2 for Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2081a11d-8678-03ec-cde4-b4eaae10e82d@linaro.org \ --to=daniel.lezcano@linaro.org \ --cc=ceh@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=tglx@linutronix.de \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.