Re: [PATCH] qemu-traditional: update configure check for -lrt changes in glibc 2.17

Re: [PATCH] qemu-traditional: update configure check for -lrt changes in glibc 2.17

[Eric Shelton]

On Wed, May 1, 2013 at 09:21:17AM -0700, Matt Wilson wrote:
> On Mon, Apr 29, 2013 at 03:40:13PM +0200, Olaf Hering wrote:
> > Ping
>
> Makes sense.
>
> Acked-by: Matt Wilson <msw@amazon.com>
>
> > On Wed, Jan 16, Olaf Hering wrote:
> >
> > > Ping
> > >
> > > On Wed, Dec 05, Olaf Hering wrote:
> > >
> > > > configure uses clock_gettime to check whether -lrt is needed - and don't
> > > > check other functions. With glibc 2.17 clock_gettime is part of libc, so
> > > > use timer_gettime instead, which is in -lrt in old and new versions of
> > > > glibc.
> > > >
> > > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > > > ---
> > > >  configure | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/configure b/configure
> > > > index 904e019..ace3c3e 100755
> > > > --- a/configure
> > > > +++ b/configure
> > > > @@ -1097,7 +1097,7 @@ fi
> > > >  cat > $TMPC <<EOF
> > > >  #include <signal.h>
> > > >  #include <time.h>
> > > > -int main(void) { clockid_t id; return clock_gettime(id, NULL); }
> > > > +int main(void) { struct itimerspec v; timer_t t; return timer_gettime (t, &v); }
> > > >  EOF
> > > >
> > > >  rt=no

At least 2 acked patches were not committed to qemu-traditional before
the RC1 freeze & tag.

The above patch (against qemu-traditional - qemu-upstream is OK) was
acked a couple of days before Friday's RC1 code freeze, but it still
remains uncommitted.  This patch appears to be needed to build
successfully on Ubuntu Server 13.04, as I was unable to build
yesterday's xen-unstable (specifically the qemu-traditional portion)
without the above patch.

Another patch (subject line "Re: [PATCH] qemu-traditional: do not
strip binaries during make install") was also acked on May 1, but
remains uncommitted.

- Eric

Re: [PATCH] qemu-traditional: update configure check for -lrt changes in glibc 2.17

[George Dunlap]

On Tue, May 7, 2013 at 4:41 PM, Eric Shelton <eshelton@pobox.com> wrote:
> On Wed, May 1, 2013 at 09:21:17AM -0700, Matt Wilson wrote:
>> On Mon, Apr 29, 2013 at 03:40:13PM +0200, Olaf Hering wrote:
>> > Ping
>>
>> Makes sense.
>>
>> Acked-by: Matt Wilson <msw@amazon.com>
>>
>> > On Wed, Jan 16, Olaf Hering wrote:
>> >
>> > > Ping
>> > >
>> > > On Wed, Dec 05, Olaf Hering wrote:
>> > >
>> > > > configure uses clock_gettime to check whether -lrt is needed - and don't
>> > > > check other functions. With glibc 2.17 clock_gettime is part of libc, so
>> > > > use timer_gettime instead, which is in -lrt in old and new versions of
>> > > > glibc.
>> > > >
>> > > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
>> > > > ---
>> > > >  configure | 2 +-
>> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
>> > > >
>> > > > diff --git a/configure b/configure
>> > > > index 904e019..ace3c3e 100755
>> > > > --- a/configure
>> > > > +++ b/configure
>> > > > @@ -1097,7 +1097,7 @@ fi
>> > > >  cat > $TMPC <<EOF
>> > > >  #include <signal.h>
>> > > >  #include <time.h>
>> > > > -int main(void) { clockid_t id; return clock_gettime(id, NULL); }
>> > > > +int main(void) { struct itimerspec v; timer_t t; return timer_gettime (t, &v); }
>> > > >  EOF
>> > > >
>> > > >  rt=no
>
> At least 2 acked patches were not committed to qemu-traditional before
> the RC1 freeze & tag.

The important thing is that you need to start CC'ing the maintainer
(Stefano Stabellini for qemu-traditional, as i understand it) when
submitting a patch like this.  We're beginning to get enough patches
on the list that it's easy for mere humans to miss ones which are in
their domain if they're not deliberately cc'd.

>
> The above patch (against qemu-traditional - qemu-upstream is OK) was
> acked a couple of days before Friday's RC1 code freeze, but it still
> remains uncommitted.  This patch appears to be needed to build
> successfully on Ubuntu Server 13.04, as I was unable to build
> yesterday's xen-unstable (specifically the qemu-traditional portion)
> without the above patch.

This looks like a bug fix, so re the 4.3 release:

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

Re: [PATCH] qemu-traditional: update configure check for -lrt changes in glibc 2.17

[Ian Campbell]

On Wed, 2013-05-08 at 10:43 +0100, George Dunlap wrote:
> On Tue, May 7, 2013 at 4:41 PM, Eric Shelton <eshelton@pobox.com> wrote:
> > On Wed, May 1, 2013 at 09:21:17AM -0700, Matt Wilson wrote:
> >> On Mon, Apr 29, 2013 at 03:40:13PM +0200, Olaf Hering wrote:
> >> > Ping
> >>
> >> Makes sense.
> >>
> >> Acked-by: Matt Wilson <msw@amazon.com>
> >>
> >> > On Wed, Jan 16, Olaf Hering wrote:
> >> >
> >> > > Ping
> >> > >
> >> > > On Wed, Dec 05, Olaf Hering wrote:
> >> > >
> >> > > > configure uses clock_gettime to check whether -lrt is needed - and don't
> >> > > > check other functions. With glibc 2.17 clock_gettime is part of libc, so
> >> > > > use timer_gettime instead, which is in -lrt in old and new versions of
> >> > > > glibc.
> >> > > >
> >> > > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> >> > > > ---
> >> > > >  configure | 2 +-
> >> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> > > >
> >> > > > diff --git a/configure b/configure
> >> > > > index 904e019..ace3c3e 100755
> >> > > > --- a/configure
> >> > > > +++ b/configure
> >> > > > @@ -1097,7 +1097,7 @@ fi
> >> > > >  cat > $TMPC <<EOF
> >> > > >  #include <signal.h>
> >> > > >  #include <time.h>
> >> > > > -int main(void) { clockid_t id; return clock_gettime(id, NULL); }
> >> > > > +int main(void) { struct itimerspec v; timer_t t; return timer_gettime (t, &v); }
> >> > > >  EOF
> >> > > >
> >> > > >  rt=no
> >
> > At least 2 acked patches were not committed to qemu-traditional before
> > the RC1 freeze & tag.
> 
> The important thing is that you need to start CC'ing the maintainer
> (Stefano Stabellini for qemu-traditional, as i understand it) when

Ian Jackson for -trad and Stefano for -upstream.

These are both listed in MAINTAINERS:
QEMU-DM
M:      Ian Jackson <ian.jackson@eu.citrix.com>
S:      Supported
T:      git git://xenbits.xen.org/qemu-xen-*.git

QEMU UPSTREAM
M:      Stefano Stabellini <stefano.stabellini@eu.citrix.com>
S:      Supported
T:      git git://xenbits.xen.org/qemu-upstream-*.git

It's possible that the title of QEMU-DM need clarifying now that we have
two qemus.

Ian.

Re: [PATCH] qemu-traditional: update configure check for -lrt changes in glibc 2.17

[Ian Jackson]

George Dunlap writes ("Re: [Xen-devel] [PATCH] qemu-traditional: update configure check for -lrt changes in glibc 2.17"):
> On Tue, May 7, 2013 at 4:41 PM, Eric Shelton <eshelton@pobox.com> wrote:
> >> > > > -int main(void) { clockid_t id; return clock_gettime(id, NULL); }
> >> > > > +int main(void) { struct itimerspec v; timer_t t; return timer_gettime (t, &v); }

I have applied this patch, thanks.

Ian.

Re: [PATCH] qemu-traditional: update configure check for -lrt changes in glibc 2.17

[Matt Wilson]

On Mon, Apr 29, 2013 at 03:40:13PM +0200, Olaf Hering wrote:
> Ping

Makes sense.

Acked-by: Matt Wilson <msw@amazon.com>

> On Wed, Jan 16, Olaf Hering wrote:
> 
> > Ping
> > 
> > On Wed, Dec 05, Olaf Hering wrote:
> > 
> > > configure uses clock_gettime to check whether -lrt is needed - and don't
> > > check other functions. With glibc 2.17 clock_gettime is part of libc, so
> > > use timer_gettime instead, which is in -lrt in old and new versions of
> > > glibc.
> > > 
> > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > > ---
> > >  configure | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/configure b/configure
> > > index 904e019..ace3c3e 100755
> > > --- a/configure
> > > +++ b/configure
> > > @@ -1097,7 +1097,7 @@ fi
> > >  cat > $TMPC <<EOF
> > >  #include <signal.h>
> > >  #include <time.h>
> > > -int main(void) { clockid_t id; return clock_gettime(id, NULL); }
> > > +int main(void) { struct itimerspec v; timer_t t; return timer_gettime (t, &v); }
> > >  EOF
> > >  
> > >  rt=no

Re: [PATCH] qemu-traditional: update configure check for -lrt changes in glibc 2.17

[Olaf Hering]

Ping

On Wed, Jan 16, Olaf Hering wrote:

> Ping
> 
> On Wed, Dec 05, Olaf Hering wrote:
> 
> > configure uses clock_gettime to check whether -lrt is needed - and don't
> > check other functions. With glibc 2.17 clock_gettime is part of libc, so
> > use timer_gettime instead, which is in -lrt in old and new versions of
> > glibc.
> > 
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > ---
> >  configure | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure b/configure
> > index 904e019..ace3c3e 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1097,7 +1097,7 @@ fi
> >  cat > $TMPC <<EOF
> >  #include <signal.h>
> >  #include <time.h>
> > -int main(void) { clockid_t id; return clock_gettime(id, NULL); }
> > +int main(void) { struct itimerspec v; timer_t t; return timer_gettime (t, &v); }
> >  EOF
> >  
> >  rt=no

Re: [PATCH] qemu-traditional: update configure check for -lrt changes in glibc 2.17

[Olaf Hering]

Ping

On Wed, Dec 05, Olaf Hering wrote:

> configure uses clock_gettime to check whether -lrt is needed - and don't
> check other functions. With glibc 2.17 clock_gettime is part of libc, so
> use timer_gettime instead, which is in -lrt in old and new versions of
> glibc.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 904e019..ace3c3e 100755
> --- a/configure
> +++ b/configure
> @@ -1097,7 +1097,7 @@ fi
>  cat > $TMPC <<EOF
>  #include <signal.h>
>  #include <time.h>
> -int main(void) { clockid_t id; return clock_gettime(id, NULL); }
> +int main(void) { struct itimerspec v; timer_t t; return timer_gettime (t, &v); }
>  EOF
>  
>  rt=no

[PATCH] qemu-traditional: update configure check for -lrt changes in glibc 2.17

[Olaf Hering]

configure uses clock_gettime to check whether -lrt is needed - and don't
check other functions. With glibc 2.17 clock_gettime is part of libc, so
use timer_gettime instead, which is in -lrt in old and new versions of
glibc.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 904e019..ace3c3e 100755
--- a/configure
+++ b/configure
@@ -1097,7 +1097,7 @@ fi
 cat > $TMPC <<EOF
 #include <signal.h>
 #include <time.h>
-int main(void) { clockid_t id; return clock_gettime(id, NULL); }
+int main(void) { struct itimerspec v; timer_t t; return timer_gettime (t, &v); }
 EOF
 
 rt=no
-- 
1.8.0.1