All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alexey Klimov" <klimov.linux@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Greg KH <greg@kroah.com>,
	linux-next@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@redhat.com>,
	Douglas Schilling Landgraf <dougsland@gmail.com>
Subject: Re: linux-next: usb tree build failure
Date: Tue, 14 Oct 2008 21:41:52 +0400	[thread overview]
Message-ID: <208cbae30810141041j2133d5a6s92d61fd5ea40fd9f@mail.gmail.com> (raw)
In-Reply-To: <208cbae30810132251k7c671a12rf259855a252d093@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

Hello, all
Sorry, bother you all again.
Here is the patch that removes info() and err()-statements in
drivers/media/radio/radio-mr800.c
Also, in previous letter i sent you patch that removes
warn()-statements from there.

May be it can help current situation.
-- 
Best regards, Klimov Alexey

[-- Attachment #2: radio-mr800-remove-warn-and-err.patch --]
[-- Type: application/octet-stream, Size: 2491 bytes --]

diff -r 270723a73207 linux/drivers/media/radio/radio-mr800.c
--- a/linux/drivers/media/radio/radio-mr800.c	Tue Oct 14 20:46:52 2008 +0400
+++ b/linux/drivers/media/radio/radio-mr800.c	Tue Oct 14 21:22:15 2008 +0400
@@ -362,7 +362,7 @@
 
 	radio->curfreq = f->frequency;
 	if (amradio_setfreq(radio, radio->curfreq) < 0)
-		warn("Set frequency failed");
+		printk(KERN_WARNING KBUILD_MODNAME ": Set frequency failed\n");
 	return 0;
 }
 
@@ -417,12 +417,14 @@
 	case V4L2_CID_AUDIO_MUTE:
 		if (ctrl->value) {
 			if (amradio_stop(radio) < 0) {
-				warn("amradio_stop() failed");
+				printk(KERN_WARNING KBUILD_MODNAME
+						": amradio_stop() failed\n");
 				return -1;
 			}
 		} else {
 			if (amradio_start(radio) < 0) {
-				warn("amradio_start() failed");
+				printk(KERN_WARNING KBUILD_MODNAME
+						": amradio_start() failed\n");
 				return -1;
 			}
 		}
@@ -476,12 +478,13 @@
 	radio->muted = 1;
 
 	if (amradio_start(radio) < 0) {
-		warn("Radio did not start up properly");
+		printk(KERN_WARNING KBUILD_MODNAME
+					": Radio did not start up properly\n");
 		radio->users = 0;
 		return -EIO;
 	}
 	if (amradio_setfreq(radio, radio->curfreq) < 0)
-		warn("Set frequency failed");
+		printk(KERN_WARNING KBUILD_MODNAME ": Set frequency failed\n");
 	return 0;
 }
 
@@ -506,7 +509,7 @@
 	struct amradio_device *radio = usb_get_intfdata(intf);
 
 	if (amradio_stop(radio) < 0)
-		warn("amradio_stop() failed");
+		printk(KERN_WARNING KBUILD_MODNAME ": amradio_stop() failed\n");
 
 	printk(KERN_INFO KBUILD_MODNAME ": Going into suspend..\n");
 
@@ -519,7 +522,8 @@
 	struct amradio_device *radio = usb_get_intfdata(intf);
 
 	if (amradio_start(radio) < 0)
-		warn("amradio_start() failed");
+		printk(KERN_WARNING KBUILD_MODNAME
+						": amradio_start() failed\n");
 
 	printk(KERN_INFO KBUILD_MODNAME ": Coming out of suspend..\n");
 
@@ -600,7 +604,8 @@
 
 	video_set_drvdata(radio->videodev, radio);
 	if (video_register_device(radio->videodev, VFL_TYPE_RADIO, radio_nr)) {
-		warn("Could not register video device");
+		printk(KERN_WARNING KBUILD_MODNAME
+					": Could not register video device\n");
 		video_device_release(radio->videodev);
 		kfree(radio->buffer);
 		kfree(radio);
@@ -618,7 +623,8 @@
 	printk(KERN_INFO KBUILD_MODNAME ": "
 			DRIVER_VERSION " " DRIVER_DESC "\n");
 	if (retval)
-		err("usb_register failed. Error number %d", retval);
+		printk(KERN_ERR KBUILD_MODNAME
+			": usb_register failed. Error number %d\n", retval);
 	return retval;
 }
 

  reply	other threads:[~2008-10-14 17:42 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-14  4:08 linux-next: usb tree build failure Stephen Rothwell
2008-10-14  5:51 ` Alexey Klimov
2008-10-14 17:41   ` Alexey Klimov [this message]
2008-10-14 17:26     ` Mauro Carvalho Chehab
  -- strict thread matches above, loose matches on Subject: below --
2010-02-02  6:10 Stephen Rothwell
2010-02-02 13:53 ` Greg KH
2010-02-02 22:33   ` Stephen Rothwell
2009-08-19  8:34 Stephen Rothwell
2009-08-19 13:52 ` Greg KH
2009-08-19 23:45   ` Greg KH
2009-08-19 23:58     ` Stephen Rothwell
2009-04-29  7:17 Stephen Rothwell
2009-04-29 14:15 ` Greg KH
2009-04-29 15:00   ` Stephen Rothwell
2009-04-29 15:16     ` Greg KH
2009-04-29 15:18 ` Randy Dunlap
2009-04-29 15:37   ` Greg KH
2009-04-29 15:44     ` Randy Dunlap
2009-04-29 17:44       ` Greg KH
2009-04-29 17:53         ` Randy Dunlap
2009-04-30 16:13           ` Greg KH
2009-04-30 16:27             ` Randy Dunlap
2008-12-22  0:33 Stephen Rothwell
2008-12-22  1:31 ` Greg KH
2008-12-22  2:42   ` Stephen Rothwell
2008-12-22  6:45     ` Sam Ravnborg
2008-12-22 17:26       ` Inaky Perez-Gonzalez
2008-12-22 17:53         ` Sam Ravnborg
2008-12-22 23:37           ` Inaky Perez-Gonzalez
2008-12-23  4:31             ` Greg KH
2008-12-23  4:30           ` Greg KH
2008-12-23  4:31         ` Greg KH
2008-12-23 10:26           ` Inaky Perez-Gonzalez
2008-12-23 17:17             ` Greg KH
2008-12-24  1:07               ` Inaky Perez-Gonzalez
2009-01-05  4:34                 ` Greg KH
2009-01-05  5:55                   ` Stephen Rothwell
2008-12-29  3:55 ` Stephen Rothwell
2009-01-02  7:27   ` Greg KH
2009-01-03  4:33     ` Stephen Rothwell
2008-11-03  0:36 Stephen Rothwell
2008-11-05  4:47 ` Greg KH
2008-11-05 18:19   ` Mauro Carvalho Chehab
2008-10-14  3:59 Stephen Rothwell
2008-10-14  8:24 ` Dmitry
2008-10-14 15:42   ` Dmitry
2008-10-16 16:05 ` Greg KH
2008-10-16 17:27   ` Dmitry Baryshkov
2008-10-16 21:36   ` Dmitry Baryshkov
2008-10-17  0:26     ` Stephen Rothwell
2008-10-17  0:41       ` Dmitry
2008-10-20 18:45         ` Greg KH
2008-08-13  6:37 Stephen Rothwell
2008-08-13  7:33 ` Stephen Rothwell
2008-08-13 14:23   ` Stephen Rothwell
2008-08-14  6:28     ` Stephen Rothwell
2008-08-14  6:54       ` Stephen Rothwell
2008-08-14 12:25         ` Greg KH
2008-08-15  0:16           ` Stephen Rothwell
2008-07-18  1:31 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=208cbae30810141041j2133d5a6s92d61fd5ea40fd9f@mail.gmail.com \
    --to=klimov.linux@gmail.com \
    --cc=dougsland@gmail.com \
    --cc=greg@kroah.com \
    --cc=linux-next@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.