* [Qemu-devel] [PATCH] vfio: fix wrong initialize vfio_group_list
@ 2015-01-22 3:50 Chen Fan
2015-01-22 8:14 ` Eric Auger
0 siblings, 1 reply; 6+ messages in thread
From: Chen Fan @ 2015-01-22 3:50 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Williamson
Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
---
hw/vfio/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index cf483ff..e71385e 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -32,7 +32,7 @@
#include "trace.h"
struct vfio_group_head vfio_group_list =
- QLIST_HEAD_INITIALIZER(vfio_address_spaces);
+ QLIST_HEAD_INITIALIZER(vfio_group_list);
struct vfio_as_head vfio_address_spaces =
QLIST_HEAD_INITIALIZER(vfio_address_spaces);
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] vfio: fix wrong initialize vfio_group_list
2015-01-22 3:50 [Qemu-devel] [PATCH] vfio: fix wrong initialize vfio_group_list Chen Fan
@ 2015-01-22 8:14 ` Eric Auger
2015-01-26 1:06 ` Chen Fan
0 siblings, 1 reply; 6+ messages in thread
From: Eric Auger @ 2015-01-22 8:14 UTC (permalink / raw)
To: Chen Fan, qemu-devel; +Cc: Alex Williamson
Hi Chen,
thanks for correcting this mistake I introduced when moving code from
pci to common.
Best Regards
Eric
On 01/22/2015 04:50 AM, Chen Fan wrote:
> Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
> ---
> hw/vfio/common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> index cf483ff..e71385e 100644
> --- a/hw/vfio/common.c
> +++ b/hw/vfio/common.c
> @@ -32,7 +32,7 @@
> #include "trace.h"
>
> struct vfio_group_head vfio_group_list =
> - QLIST_HEAD_INITIALIZER(vfio_address_spaces);
> + QLIST_HEAD_INITIALIZER(vfio_group_list);
> struct vfio_as_head vfio_address_spaces =
> QLIST_HEAD_INITIALIZER(vfio_address_spaces);
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] vfio: fix wrong initialize vfio_group_list
2015-01-22 8:14 ` Eric Auger
@ 2015-01-26 1:06 ` Chen Fan
2015-01-26 2:06 ` Alex Williamson
0 siblings, 1 reply; 6+ messages in thread
From: Chen Fan @ 2015-01-26 1:06 UTC (permalink / raw)
To: Eric Auger, qemu-devel, qemu-trivial; +Cc: Alex Williamson
CC: qemu-trivial@nongnu.org
On 01/22/2015 04:14 PM, Eric Auger wrote:
> Hi Chen,
>
> thanks for correcting this mistake I introduced when moving code from
> pci to common.
so, can you check in this patch?
Thanks,
Chen
>
> Best Regards
>
> Eric
>
> On 01/22/2015 04:50 AM, Chen Fan wrote:
>> Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
>> ---
>> hw/vfio/common.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
>> index cf483ff..e71385e 100644
>> --- a/hw/vfio/common.c
>> +++ b/hw/vfio/common.c
>> @@ -32,7 +32,7 @@
>> #include "trace.h"
>>
>> struct vfio_group_head vfio_group_list =
>> - QLIST_HEAD_INITIALIZER(vfio_address_spaces);
>> + QLIST_HEAD_INITIALIZER(vfio_group_list);
>> struct vfio_as_head vfio_address_spaces =
>> QLIST_HEAD_INITIALIZER(vfio_address_spaces);
>>
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] vfio: fix wrong initialize vfio_group_list
2015-01-26 1:06 ` Chen Fan
@ 2015-01-26 2:06 ` Alex Williamson
2015-01-26 2:18 ` Chen Fan
0 siblings, 1 reply; 6+ messages in thread
From: Alex Williamson @ 2015-01-26 2:06 UTC (permalink / raw)
To: Chen Fan; +Cc: qemu-trivial, qemu-devel, Eric Auger
----- Original Message -----
> CC: qemu-trivial@nongnu.org
>
> On 01/22/2015 04:14 PM, Eric Auger wrote:
> > Hi Chen,
> >
> > thanks for correcting this mistake I introduced when moving code from
> > pci to common.
>
> so, can you check in this patch?
I've got it queued up and while it's clearly an error, I don't see that the fix actually changes the resulting code, the parameter is ignored in the macro. Am I missing something? If that's the case, I'll include it in my next pull request, but I don't see any pressing reason to rush that request. Thanks,
Alex
> > On 01/22/2015 04:50 AM, Chen Fan wrote:
> >> Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
> >> ---
> >> hw/vfio/common.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> >> index cf483ff..e71385e 100644
> >> --- a/hw/vfio/common.c
> >> +++ b/hw/vfio/common.c
> >> @@ -32,7 +32,7 @@
> >> #include "trace.h"
> >>
> >> struct vfio_group_head vfio_group_list =
> >> - QLIST_HEAD_INITIALIZER(vfio_address_spaces);
> >> + QLIST_HEAD_INITIALIZER(vfio_group_list);
> >> struct vfio_as_head vfio_address_spaces =
> >> QLIST_HEAD_INITIALIZER(vfio_address_spaces);
> >>
> >>
> >
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] vfio: fix wrong initialize vfio_group_list
2015-01-26 2:06 ` Alex Williamson
@ 2015-01-26 2:18 ` Chen Fan
2015-01-26 2:39 ` Alex Williamson
0 siblings, 1 reply; 6+ messages in thread
From: Chen Fan @ 2015-01-26 2:18 UTC (permalink / raw)
To: Alex Williamson; +Cc: qemu-trivial, qemu-devel, Eric Auger
On 01/26/2015 10:06 AM, Alex Williamson wrote:
>
> ----- Original Message -----
>> CC: qemu-trivial@nongnu.org
>>
>> On 01/22/2015 04:14 PM, Eric Auger wrote:
>>> Hi Chen,
>>>
>>> thanks for correcting this mistake I introduced when moving code from
>>> pci to common.
>> so, can you check in this patch?
> I've got it queued up and while it's clearly an error, I don't see that the fix actually changes the resulting code, the parameter is ignored in the macro. Am I missing something? If that's the case, I'll include it in my next pull request, but I don't see any pressing reason to rush that request. Thanks,
Yes, this patch can not affect the result of the code execution for
now, but I think it is also a typo mistake, if the macro
QLIST_HEAD_INITIALIZER
will be changed and using the parameter in the future, this error will
be difficultly found. I think the earlier found the earlier fixed.
Thanks,
Chen
>
> Alex
>
>>> On 01/22/2015 04:50 AM, Chen Fan wrote:
>>>> Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
>>>> ---
>>>> hw/vfio/common.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
>>>> index cf483ff..e71385e 100644
>>>> --- a/hw/vfio/common.c
>>>> +++ b/hw/vfio/common.c
>>>> @@ -32,7 +32,7 @@
>>>> #include "trace.h"
>>>>
>>>> struct vfio_group_head vfio_group_list =
>>>> - QLIST_HEAD_INITIALIZER(vfio_address_spaces);
>>>> + QLIST_HEAD_INITIALIZER(vfio_group_list);
>>>> struct vfio_as_head vfio_address_spaces =
>>>> QLIST_HEAD_INITIALIZER(vfio_address_spaces);
>>>>
>>>>
>>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] vfio: fix wrong initialize vfio_group_list
2015-01-26 2:18 ` Chen Fan
@ 2015-01-26 2:39 ` Alex Williamson
0 siblings, 0 replies; 6+ messages in thread
From: Alex Williamson @ 2015-01-26 2:39 UTC (permalink / raw)
To: Chen Fan; +Cc: qemu-trivial, qemu-devel, Eric Auger
----- Original Message -----
>
> On 01/26/2015 10:06 AM, Alex Williamson wrote:
> >
> > ----- Original Message -----
> >> CC: qemu-trivial@nongnu.org
> >>
> >> On 01/22/2015 04:14 PM, Eric Auger wrote:
> >>> Hi Chen,
> >>>
> >>> thanks for correcting this mistake I introduced when moving code from
> >>> pci to common.
> >> so, can you check in this patch?
> > I've got it queued up and while it's clearly an error, I don't see that the
> > fix actually changes the resulting code, the parameter is ignored in the
> > macro. Am I missing something? If that's the case, I'll include it in my
> > next pull request, but I don't see any pressing reason to rush that
> > request. Thanks,
> Yes, this patch can not affect the result of the code execution for
> now, but I think it is also a typo mistake, if the macro
> QLIST_HEAD_INITIALIZER
> will be changed and using the parameter in the future, this error will
> be difficultly found. I think the earlier found the earlier fixed.
Yes, it's obviously an error and I'll get it in before QEMU 2.3, likely within the next week or so. Thanks,
Alex
> >>> On 01/22/2015 04:50 AM, Chen Fan wrote:
> >>>> Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
> >>>> ---
> >>>> hw/vfio/common.c | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> >>>> index cf483ff..e71385e 100644
> >>>> --- a/hw/vfio/common.c
> >>>> +++ b/hw/vfio/common.c
> >>>> @@ -32,7 +32,7 @@
> >>>> #include "trace.h"
> >>>>
> >>>> struct vfio_group_head vfio_group_list =
> >>>> - QLIST_HEAD_INITIALIZER(vfio_address_spaces);
> >>>> + QLIST_HEAD_INITIALIZER(vfio_group_list);
> >>>> struct vfio_as_head vfio_address_spaces =
> >>>> QLIST_HEAD_INITIALIZER(vfio_address_spaces);
> >>>>
> >>>>
> >>
> > .
> >
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-26 2:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-22 3:50 [Qemu-devel] [PATCH] vfio: fix wrong initialize vfio_group_list Chen Fan
2015-01-22 8:14 ` Eric Auger
2015-01-26 1:06 ` Chen Fan
2015-01-26 2:06 ` Alex Williamson
2015-01-26 2:18 ` Chen Fan
2015-01-26 2:39 ` Alex Williamson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.