All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	kernel@savoirfairelinux.com,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Russell King - ARM Linux <linux@armlinux.org.uk>,
	Mark Rutland <mark.rutland@arm.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	kris@embeddedarm.com, Mark Featherston <mark@embeddedarm.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: TS-7970: add basic device tree
Date: Thu, 23 Nov 2017 11:28:52 -0500	[thread overview]
Message-ID: <20977491-3a0a-1136-e35f-7b5c47dcfe18@savoirfairelinux.com> (raw)
In-Reply-To: <CAOMZO5CzXo63fbFZWE-KR1FC7VQ4DzKvR-SdDmp+5L5+=Rd10Q@mail.gmail.com>

Hi Fabio,

On 11/22/2017 03:48 PM, Fabio Estevam wrote:
> On Wed, Nov 22, 2017 at 6:32 PM, Sebastien Bourdelin
> <sebastien.bourdelin@savoirfairelinux.com> wrote:
> 
>> +/dts-v1/;
>> +#include "imx6q.dtsi"
>> +#include "imx6qdl-ts7970.dtsi"
>> +
>> +/ {
>> +       model = "Technologic Systems i.MX6 Quad TS-7970 (Default Devuice Tree)";
> 
> Typo: Devuice--> Device
Thanks!
> 
>> +       reg_can1_3v3: reg_can1_3v3 {
>> +               compatible = "regulator-fixed";
>> +               regulator-name = "reg_can1_3v3";
>> +               regulator-min-microvolt = <3300000>;
>> +               regulator-max-microvolt = <3300000>;
>> +               gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
> 
> Are you sure this is GPIO_ACTIVE_HIGH?
> 
> If so, then it would need the 'enable-active-high' property.
Ok
> 
> 
>> +       };
>> +
>> +       reg_can2_3v3: en-reg_can2_3v3 {
>> +               compatible = "regulator-fixed";
>> +               regulator-name = "reg_can2_3v3";
>> +               regulator-min-microvolt = <3300000>;
>> +               regulator-max-microvolt = <3300000>;
>> +               gpio = <&gpio6 31 GPIO_ACTIVE_HIGH>;
> 
> Same here.
Ok
> 
>> +
>> +&fec {
>> +       pinctrl-names = "default";
>> +       pinctrl-0 = <&pinctrl_enet>;
>> +       interrupts-extended = <&gpio1 6 0x04>, <&gpc 0 119 0x04>;
> 
> I think you meant to say:
> 
> interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
>       <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
> fsl,err006687-workaround-present;
Nice for the workaround, thanks!

> 
>> +&pcie {
>> +       reset-gpio = <&gpio2 21 GPIO_ACTIVE_HIGH>;
> 
> Are you sure it is GPIO_ACTIVE_HIGH? if so, it would need a
> reset-gpio-active-high property.
> 
> Most likely this should be:
> 
> reset-gpio = <&gpio2 21 GPIO_ACTIVE_LOW>;
> 
I have difficulties to verify this information, i will remove it unless
Mark Featherston can confirm it.

Thanks for your review Fabio!

WARNING: multiple messages have this Message-ID (diff)
From: sebastien.bourdelin@savoirfairelinux.com (Sebastien Bourdelin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] ARM: dts: TS-7970: add basic device tree
Date: Thu, 23 Nov 2017 11:28:52 -0500	[thread overview]
Message-ID: <20977491-3a0a-1136-e35f-7b5c47dcfe18@savoirfairelinux.com> (raw)
In-Reply-To: <CAOMZO5CzXo63fbFZWE-KR1FC7VQ4DzKvR-SdDmp+5L5+=Rd10Q@mail.gmail.com>

Hi Fabio,

On 11/22/2017 03:48 PM, Fabio Estevam wrote:
> On Wed, Nov 22, 2017 at 6:32 PM, Sebastien Bourdelin
> <sebastien.bourdelin@savoirfairelinux.com> wrote:
> 
>> +/dts-v1/;
>> +#include "imx6q.dtsi"
>> +#include "imx6qdl-ts7970.dtsi"
>> +
>> +/ {
>> +       model = "Technologic Systems i.MX6 Quad TS-7970 (Default Devuice Tree)";
> 
> Typo: Devuice--> Device
Thanks!
> 
>> +       reg_can1_3v3: reg_can1_3v3 {
>> +               compatible = "regulator-fixed";
>> +               regulator-name = "reg_can1_3v3";
>> +               regulator-min-microvolt = <3300000>;
>> +               regulator-max-microvolt = <3300000>;
>> +               gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
> 
> Are you sure this is GPIO_ACTIVE_HIGH?
> 
> If so, then it would need the 'enable-active-high' property.
Ok
> 
> 
>> +       };
>> +
>> +       reg_can2_3v3: en-reg_can2_3v3 {
>> +               compatible = "regulator-fixed";
>> +               regulator-name = "reg_can2_3v3";
>> +               regulator-min-microvolt = <3300000>;
>> +               regulator-max-microvolt = <3300000>;
>> +               gpio = <&gpio6 31 GPIO_ACTIVE_HIGH>;
> 
> Same here.
Ok
> 
>> +
>> +&fec {
>> +       pinctrl-names = "default";
>> +       pinctrl-0 = <&pinctrl_enet>;
>> +       interrupts-extended = <&gpio1 6 0x04>, <&gpc 0 119 0x04>;
> 
> I think you meant to say:
> 
> interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
>       <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
> fsl,err006687-workaround-present;
Nice for the workaround, thanks!

> 
>> +&pcie {
>> +       reset-gpio = <&gpio2 21 GPIO_ACTIVE_HIGH>;
> 
> Are you sure it is GPIO_ACTIVE_HIGH? if so, it would need a
> reset-gpio-active-high property.
> 
> Most likely this should be:
> 
> reset-gpio = <&gpio2 21 GPIO_ACTIVE_LOW>;
> 
I have difficulties to verify this information, i will remove it unless
Mark Featherston can confirm it.

Thanks for your review Fabio!

  reply	other threads:[~2017-11-23 16:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22 20:32 [PATCH v2 1/2] of: documentation: add bindings documentation for TS-7970 Sebastien Bourdelin
2017-11-22 20:32 ` Sebastien Bourdelin
2017-11-22 20:32 ` [PATCH v2 2/2] ARM: dts: TS-7970: add basic device tree Sebastien Bourdelin
2017-11-22 20:32   ` Sebastien Bourdelin
2017-11-22 20:48   ` Fabio Estevam
2017-11-22 20:48     ` Fabio Estevam
2017-11-23 16:28     ` Sebastien Bourdelin [this message]
2017-11-23 16:28       ` Sebastien Bourdelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20977491-3a0a-1136-e35f-7b5c47dcfe18@savoirfairelinux.com \
    --to=sebastien.bourdelin@savoirfairelinux.com \
    --cc=fabio.estevam@nxp.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kernel@savoirfairelinux.com \
    --cc=kris@embeddedarm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mark@embeddedarm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.