All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Patrick Wildt <patrick@blueri.se>
Cc: festevam@denx.de, frieder.schrempf@kontron.de,
	heiko.thiery@gmail.com, hs@denx.de, marcel.ziswiler@toradex.com,
	peng.fan@oss.nxp.com, sbabic@denx.de, trini@konsulko.com,
	u-boot@lists.denx.de
Subject: Re: [PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name
Date: Thu, 13 Jan 2022 14:29:50 +0100	[thread overview]
Message-ID: <20a6a4f25750fa6760f18079b684aee2@walle.cc> (raw)
In-Reply-To: <YeAmOearXH04cl2M@ryzen.fritz.box>

Am 2022-01-13 14:16, schrieb Patrick Wildt:
> On Thu, Jan 13, 2022 at 12:42:50PM +0100, Michael Walle wrote:
>> Hi,
>> 
>> > --- a/arch/arm/dts/imx8mm-u-boot.dtsi
>> > +++ b/arch/arm/dts/imx8mm-u-boot.dtsi
>> > @@ -39,7 +39,7 @@
>> >  			filename = "u-boot-spl.bin";
>> >  		};
>> >
>> > -		1d-imem {
>> > +		1d_imem {
>> 
>> I think it is the other way around. Device tree node names should 
>> contain
>> hyphens and not underscores.
>> 
>> I couldn't find any references in dtschema though. Maybe I haven't 
>> looked
>> hard enough.
>> 
>> But you can see linux commit 28d7f0f3f10b, for example.
>> 
>> -michael
> 
> Hi,
> 
> I don't know what's right, but every other of these in the i.MX8MM file
> use _ instead of -, so if at all this makes it consistenly wrong, but
> at least now it's consistent. ;)
> 
> If it's wrong, I'm sure someone will step up and rectify it.

Why don't you just change it to the correct naming then?

-michael

  reply	other threads:[~2022-01-13 13:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12 21:19 [PATCH 0/4] arm64: imx8mq/imx8mm: cleanup binman configuration Patrick Wildt
2022-01-12 21:20 ` [PATCH 1/4] arm64: dts: imx8mq-u-boot.dtsi: alphabetically re-order properties Patrick Wildt
2022-01-12 21:21 ` [PATCH 2/4] arm64: dts: imx8mq-u-boot.dtsi: explicitly add spl filename Patrick Wildt
2022-01-12 21:21 ` [PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name Patrick Wildt
2022-01-13 11:42   ` Michael Walle
2022-01-13 13:16     ` Patrick Wildt
2022-01-13 13:29       ` Michael Walle [this message]
2022-01-13 13:40         ` Fabio Estevam
2022-01-13 14:18           ` Patrick Wildt
2022-01-12 21:22 ` [PATCH 4/4] arm64: dts: imx8mq-u-boot.dtsi: improve odd blob-ext naming Patrick Wildt
2022-01-13 11:29 ` [PATCH 0/4] arm64: imx8mq/imx8mm: cleanup binman configuration Frieder Schrempf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20a6a4f25750fa6760f18079b684aee2@walle.cc \
    --to=michael@walle.cc \
    --cc=festevam@denx.de \
    --cc=frieder.schrempf@kontron.de \
    --cc=heiko.thiery@gmail.com \
    --cc=hs@denx.de \
    --cc=marcel.ziswiler@toradex.com \
    --cc=patrick@blueri.se \
    --cc=peng.fan@oss.nxp.com \
    --cc=sbabic@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.