From: Dou Liyang <douly.fnst@cn.fujitsu.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: <tglx@linutronix.de>, <hpa@zytor.com>, <bp@alien8.de>,
<wanpeng.li@hotmail.com>, <nicstange@gmail.com>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/apic: Remove the extra judgement of skipped IO APIC setup
Date: Wed, 1 Mar 2017 17:31:55 +0800 [thread overview]
Message-ID: <20f40557-b9ca-7442-a9af-3beccb0093d9@cn.fujitsu.com> (raw)
In-Reply-To: <20170301090455.GA23669@gmail.com>
Dear Ingo,
At 03/01/2017 05:04 PM, Ingo Molnar wrote:
[...]
>> + pr_info("Not init interrupt remapping due to skipped IO-APIC setup\n");
>
> So you replaced a perfectly readable kernel message:
>
> - pr_info("Not enabling interrupt remapping due to skipped IO-APIC setup\n");
>
> ... with an unreadable one:
>
> + pr_info("Not init interrupt remapping due to skipped IO-APIC setup\n");
>
> Why?
I am very sorry.
Because of my weak English skills :) . I am trying to improve my
English ability.
>
> Also, the changelog is pretty much unreadable as well:
>
>> As the commit 2e63ad4bd5dd ("x86/apic: Do not init irq remapping
>> if ioapic is disabled") added the judgement of skipped IO APIC
>> setup at the beginning of enable_IR_x2apic(). It may be redundant
>> that we check it again when we try to enable the interrupt mapping.
>>
>> So, remove the one in try_to_enable_IR() and refine them for
>> better readability.
>
> I edited it to:
Thanks very much ! it became very clear.
>
> The following commit:
>
> 2e63ad4bd5dd ("x86/apic: Do not init irq remapping if ioapic is disabled")
>
> ... added a check for skipped IO-APIC setup to enable_IR_x2apic(), but this
Could you tell me what is the meaning of "..." . How to use it?
> check is also duplicated in try_to_enable_IR() - and it will never succeed in
> calling irq_remapping_enable().
>
> Remove the whole irq_remapping_enable() complication: if the IO-APIC is
> disabled we cannot enable IRQ remapping.
>
> And I restored the original pr_info() message as well.
Yes. Thanks!
Sincerely,
Liyang
>
> Thanks,
>
> Ingo
>
>
>
next prev parent reply other threads:[~2017-03-01 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 9:16 [PATCH] x86/apic: Remove the extra judgement of skipped IO APIC setup Dou Liyang
2017-03-01 9:04 ` Ingo Molnar
2017-03-01 9:31 ` Dou Liyang [this message]
2017-03-01 9:14 ` [tip:x86/urgent] x86/apic: Simplify enable_IR_x2apic(), remove try_to_enable_IR() tip-bot for Dou Liyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20f40557-b9ca-7442-a9af-3beccb0093d9@cn.fujitsu.com \
--to=douly.fnst@cn.fujitsu.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nicstange@gmail.com \
--cc=tglx@linutronix.de \
--cc=wanpeng.li@hotmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.