* [Outreachy kernel] [Patch 0/3]
@ 2021-04-09 16:29 Fabio M. De Francesco
2021-04-10 7:29 ` Greg KH
0 siblings, 1 reply; 8+ messages in thread
From: Fabio M. De Francesco @ 2021-04-09 16:29 UTC (permalink / raw)
To: Greg KH, outreachy-kernel, linux-staging, linux-kernel
This patch series removes camelcases, changes the type and use of a
variable, and correct misspelled words.
Patch 1/3: staging: rtl8723bs: Remove camelcase in several files
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 +++++++++---------
drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 6 +++---
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +-
drivers/staging/rtl8723bs/hal/sdio_ops.c | 14 +++++++-------
.../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
8 files changed, 24 insertions(+), 24 deletions(-)
Patch 2/3: staging: rtl8723bs: Change the type and use of a variable
drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Patch 3/3: staging: rtl8723bs: include: Fix misspelled words in comments
.../rtl8723bs/include/Hal8192CPhyReg.h | 8 ++---
.../staging/rtl8723bs/include/basic_types.h | 2 +-
drivers/staging/rtl8723bs/include/drv_types.h | 2 +-
drivers/staging/rtl8723bs/include/hal_com.h | 2 +-
.../staging/rtl8723bs/include/hal_com_reg.h | 34 +++++++++----------
drivers/staging/rtl8723bs/include/hal_data.h | 2 +-
.../staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
drivers/staging/rtl8723bs/include/rtw_cmd.h | 6 ++--
drivers/staging/rtl8723bs/include/rtw_mlme.h | 18 +++++-----
.../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
drivers/staging/rtl8723bs/include/rtw_mp.h | 2 +-
.../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
drivers/staging/rtl8723bs/include/rtw_recv.h | 4 +--
drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +-
drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
drivers/staging/rtl8723bs/include/wifi.h | 2 +-
16 files changed, 46 insertions(+), 46 deletions(-)
Fabio M. De Francesco
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [Patch 0/3]
2021-04-09 16:29 [Outreachy kernel] [Patch 0/3] Fabio M. De Francesco
@ 2021-04-10 7:29 ` Greg KH
2021-04-10 7:57 ` Fabio M. De Francesco
0 siblings, 1 reply; 8+ messages in thread
From: Greg KH @ 2021-04-10 7:29 UTC (permalink / raw)
To: Fabio M. De Francesco; +Cc: outreachy-kernel, linux-staging, linux-kernel
On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote:
> This patch series removes camelcases, changes the type and use of a
> variable, and correct misspelled words.
>
> Patch 1/3: staging: rtl8723bs: Remove camelcase in several files
>
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 +++++++++---------
> drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 6 +++---
> .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +-
> drivers/staging/rtl8723bs/hal/sdio_ops.c | 14 +++++++-------
> .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> 8 files changed, 24 insertions(+), 24 deletions(-)
>
> Patch 2/3: staging: rtl8723bs: Change the type and use of a variable
>
> drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Patch 3/3: staging: rtl8723bs: include: Fix misspelled words in comments
>
> .../rtl8723bs/include/Hal8192CPhyReg.h | 8 ++---
> .../staging/rtl8723bs/include/basic_types.h | 2 +-
> drivers/staging/rtl8723bs/include/drv_types.h | 2 +-
> drivers/staging/rtl8723bs/include/hal_com.h | 2 +-
> .../staging/rtl8723bs/include/hal_com_reg.h | 34 +++++++++----------
> drivers/staging/rtl8723bs/include/hal_data.h | 2 +-
> .../staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
> drivers/staging/rtl8723bs/include/rtw_cmd.h | 6 ++--
> drivers/staging/rtl8723bs/include/rtw_mlme.h | 18 +++++-----
> .../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
> drivers/staging/rtl8723bs/include/rtw_mp.h | 2 +-
> .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> drivers/staging/rtl8723bs/include/rtw_recv.h | 4 +--
> drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +-
> drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
> drivers/staging/rtl8723bs/include/wifi.h | 2 +-
> 16 files changed, 46 insertions(+), 46 deletions(-)
>
> Fabio M. De Francesco
I have no idea how you created this patch series, but I do not think it
worked well :(
Please use our standard tools, that do this all for you automatically,
and send them out in a series of emails that have a proper subject line
(look at what you used here...) and are properly "threaded".
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [Patch 0/3]
2021-04-10 7:29 ` Greg KH
@ 2021-04-10 7:57 ` Fabio M. De Francesco
2021-04-10 8:04 ` Greg KH
2021-04-10 8:20 ` Julia Lawall
0 siblings, 2 replies; 8+ messages in thread
From: Fabio M. De Francesco @ 2021-04-10 7:57 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel, linux-staging, linux-kernel
On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote:
> On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote:
> > This patch series removes camelcases, changes the type and use of a
> > variable, and correct misspelled words.
> >
> > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files
> >
> > drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
> > drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 +++++++++---------
> > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 6 +++---
> > .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +-
> > drivers/staging/rtl8723bs/hal/sdio_ops.c | 14 +++++++-------
> > .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > 8 files changed, 24 insertions(+), 24 deletions(-)
> >
> > Patch 2/3: staging: rtl8723bs: Change the type and use of a variable
> >
> > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> >
> > drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > Patch 3/3: staging: rtl8723bs: include: Fix misspelled words in
> > comments
> >
> > .../rtl8723bs/include/Hal8192CPhyReg.h | 8 ++---
> >
> > .../staging/rtl8723bs/include/basic_types.h | 2 +-
> > drivers/staging/rtl8723bs/include/drv_types.h | 2 +-
> > drivers/staging/rtl8723bs/include/hal_com.h | 2 +-
> > .../staging/rtl8723bs/include/hal_com_reg.h | 34 +++++++++----------
> > drivers/staging/rtl8723bs/include/hal_data.h | 2 +-
> > .../staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
> > drivers/staging/rtl8723bs/include/rtw_cmd.h | 6 ++--
> > drivers/staging/rtl8723bs/include/rtw_mlme.h | 18 +++++-----
> > .../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
> > drivers/staging/rtl8723bs/include/rtw_mp.h | 2 +-
> > .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > drivers/staging/rtl8723bs/include/rtw_recv.h | 4 +--
> > drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +-
> > drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
> > drivers/staging/rtl8723bs/include/wifi.h | 2 +-
> > 16 files changed, 46 insertions(+), 46 deletions(-)
> >
> > Fabio M. De Francesco
>
> I have no idea how you created this patch series, but I do not think it
> worked well :(
>
> Please use our standard tools, that do this all for you automatically,
>
Apart from the fact that I forgot to save the subject, I didn't know that
there are standard tools for doing Patch 0/N. Therefore I thought to make
an email message that contained the information about the patch series.
I was wrong, sorry. I have to research this topic in the git manual or
somewhere else.
Thanks,
Fabio
>
> and send them out in a series of emails that have a proper subject line
> (look at what you used here...) and are properly "threaded".
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [Patch 0/3]
2021-04-10 7:57 ` Fabio M. De Francesco
@ 2021-04-10 8:04 ` Greg KH
2021-04-10 8:22 ` Julia Lawall
2021-04-10 8:20 ` Julia Lawall
1 sibling, 1 reply; 8+ messages in thread
From: Greg KH @ 2021-04-10 8:04 UTC (permalink / raw)
To: Fabio M. De Francesco; +Cc: outreachy-kernel, linux-staging, linux-kernel
On Sat, Apr 10, 2021 at 09:57:00AM +0200, Fabio M. De Francesco wrote:
> On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote:
> > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote:
> > > This patch series removes camelcases, changes the type and use of a
> > > variable, and correct misspelled words.
> > >
> > > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files
> > >
> > > drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> > > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
> > > drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 +++++++++---------
> > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > > drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 6 +++---
> > > .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +-
> > > drivers/staging/rtl8723bs/hal/sdio_ops.c | 14 +++++++-------
> > > .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > 8 files changed, 24 insertions(+), 24 deletions(-)
> > >
> > > Patch 2/3: staging: rtl8723bs: Change the type and use of a variable
> > >
> > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > >
> > > drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > Patch 3/3: staging: rtl8723bs: include: Fix misspelled words in
> > > comments
> > >
> > > .../rtl8723bs/include/Hal8192CPhyReg.h | 8 ++---
> > >
> > > .../staging/rtl8723bs/include/basic_types.h | 2 +-
> > > drivers/staging/rtl8723bs/include/drv_types.h | 2 +-
> > > drivers/staging/rtl8723bs/include/hal_com.h | 2 +-
> > > .../staging/rtl8723bs/include/hal_com_reg.h | 34 +++++++++----------
> > > drivers/staging/rtl8723bs/include/hal_data.h | 2 +-
> > > .../staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
> > > drivers/staging/rtl8723bs/include/rtw_cmd.h | 6 ++--
> > > drivers/staging/rtl8723bs/include/rtw_mlme.h | 18 +++++-----
> > > .../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
> > > drivers/staging/rtl8723bs/include/rtw_mp.h | 2 +-
> > > .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > drivers/staging/rtl8723bs/include/rtw_recv.h | 4 +--
> > > drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +-
> > > drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
> > > drivers/staging/rtl8723bs/include/wifi.h | 2 +-
> > > 16 files changed, 46 insertions(+), 46 deletions(-)
> > >
> > > Fabio M. De Francesco
> >
> > I have no idea how you created this patch series, but I do not think it
> > worked well :(
> >
> > Please use our standard tools, that do this all for you automatically,
> >
> Apart from the fact that I forgot to save the subject, I didn't know that
> there are standard tools for doing Patch 0/N. Therefore I thought to make
> an email message that contained the information about the patch series.
>
> I was wrong, sorry. I have to research this topic in the git manual or
> somewhere else.
'git format-patch --cover-letter main..HEAD' will to the trick, if you
are on a different branch from 'main'. Then edit the 0000-* file and
then send them all off with 'git send-email'.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [Patch 0/3]
2021-04-10 7:57 ` Fabio M. De Francesco
@ 2021-04-10 8:20 ` Julia Lawall
2021-04-10 8:20 ` Julia Lawall
1 sibling, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2021-04-10 8:20 UTC (permalink / raw)
To: Fabio M. De Francesco
Cc: Greg KH, outreachy-kernel, linux-staging, linux-kernel
On Sat, 10 Apr 2021, Fabio M. De Francesco wrote:
> On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote:
> > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote:
> > > This patch series removes camelcases, changes the type and use of a
> > > variable, and correct misspelled words.
> > >
> > > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files
> > >
> > > drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> > > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
> > > drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 +++++++++---------
> > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > > drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 6 +++---
> > > .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +-
> > > drivers/staging/rtl8723bs/hal/sdio_ops.c | 14 +++++++-------
> > > .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > 8 files changed, 24 insertions(+), 24 deletions(-)
> > >
> > > Patch 2/3: staging: rtl8723bs: Change the type and use of a variable
> > >
> > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > >
> > > drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > Patch 3/3: staging: rtl8723bs: include: Fix misspelled words in
> > > comments
> > >
> > > .../rtl8723bs/include/Hal8192CPhyReg.h | 8 ++---
> > >
> > > .../staging/rtl8723bs/include/basic_types.h | 2 +-
> > > drivers/staging/rtl8723bs/include/drv_types.h | 2 +-
> > > drivers/staging/rtl8723bs/include/hal_com.h | 2 +-
> > > .../staging/rtl8723bs/include/hal_com_reg.h | 34 +++++++++----------
> > > drivers/staging/rtl8723bs/include/hal_data.h | 2 +-
> > > .../staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
> > > drivers/staging/rtl8723bs/include/rtw_cmd.h | 6 ++--
> > > drivers/staging/rtl8723bs/include/rtw_mlme.h | 18 +++++-----
> > > .../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
> > > drivers/staging/rtl8723bs/include/rtw_mp.h | 2 +-
> > > .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > drivers/staging/rtl8723bs/include/rtw_recv.h | 4 +--
> > > drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +-
> > > drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
> > > drivers/staging/rtl8723bs/include/wifi.h | 2 +-
> > > 16 files changed, 46 insertions(+), 46 deletions(-)
> > >
> > > Fabio M. De Francesco
> >
> > I have no idea how you created this patch series, but I do not think it
> > worked well :(
> >
> > Please use our standard tools, that do this all for you automatically,
> >
> Apart from the fact that I forgot to save the subject, I didn't know that
> there are standard tools for doing Patch 0/N. Therefore I thought to make
> an email message that contained the information about the patch series.
>
> I was wrong, sorry. I have to research this topic in the git manual or
> somewhere else.
Everything should be clear in the Kernelnewbies outreachy tutorial. If
there is something about this issue that is not clear, please comment on
it or propose a fix.
julia
>
> Thanks,
>
> Fabio
> >
> > and send them out in a series of emails that have a proper subject line
> > (look at what you used here...) and are properly "threaded".
> >
> > thanks,
> >
> > greg k-h
>
>
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2101069.1PIH1tPmJ7%40localhost.localdomain.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [Patch 0/3]
@ 2021-04-10 8:20 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2021-04-10 8:20 UTC (permalink / raw)
To: Fabio M. De Francesco
Cc: Greg KH, outreachy-kernel, linux-staging, linux-kernel
On Sat, 10 Apr 2021, Fabio M. De Francesco wrote:
> On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote:
> > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote:
> > > This patch series removes camelcases, changes the type and use of a
> > > variable, and correct misspelled words.
> > >
> > > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files
> > >
> > > drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> > > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
> > > drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 +++++++++---------
> > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > > drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 6 +++---
> > > .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +-
> > > drivers/staging/rtl8723bs/hal/sdio_ops.c | 14 +++++++-------
> > > .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > 8 files changed, 24 insertions(+), 24 deletions(-)
> > >
> > > Patch 2/3: staging: rtl8723bs: Change the type and use of a variable
> > >
> > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > >
> > > drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > Patch 3/3: staging: rtl8723bs: include: Fix misspelled words in
> > > comments
> > >
> > > .../rtl8723bs/include/Hal8192CPhyReg.h | 8 ++---
> > >
> > > .../staging/rtl8723bs/include/basic_types.h | 2 +-
> > > drivers/staging/rtl8723bs/include/drv_types.h | 2 +-
> > > drivers/staging/rtl8723bs/include/hal_com.h | 2 +-
> > > .../staging/rtl8723bs/include/hal_com_reg.h | 34 +++++++++----------
> > > drivers/staging/rtl8723bs/include/hal_data.h | 2 +-
> > > .../staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
> > > drivers/staging/rtl8723bs/include/rtw_cmd.h | 6 ++--
> > > drivers/staging/rtl8723bs/include/rtw_mlme.h | 18 +++++-----
> > > .../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
> > > drivers/staging/rtl8723bs/include/rtw_mp.h | 2 +-
> > > .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > drivers/staging/rtl8723bs/include/rtw_recv.h | 4 +--
> > > drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +-
> > > drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
> > > drivers/staging/rtl8723bs/include/wifi.h | 2 +-
> > > 16 files changed, 46 insertions(+), 46 deletions(-)
> > >
> > > Fabio M. De Francesco
> >
> > I have no idea how you created this patch series, but I do not think it
> > worked well :(
> >
> > Please use our standard tools, that do this all for you automatically,
> >
> Apart from the fact that I forgot to save the subject, I didn't know that
> there are standard tools for doing Patch 0/N. Therefore I thought to make
> an email message that contained the information about the patch series.
>
> I was wrong, sorry. I have to research this topic in the git manual or
> somewhere else.
Everything should be clear in the Kernelnewbies outreachy tutorial. If
there is something about this issue that is not clear, please comment on
it or propose a fix.
julia
>
> Thanks,
>
> Fabio
> >
> > and send them out in a series of emails that have a proper subject line
> > (look at what you used here...) and are properly "threaded".
> >
> > thanks,
> >
> > greg k-h
>
>
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2101069.1PIH1tPmJ7%40localhost.localdomain.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [Patch 0/3]
2021-04-10 8:04 ` Greg KH
@ 2021-04-10 8:22 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2021-04-10 8:22 UTC (permalink / raw)
To: Greg KH
Cc: Fabio M. De Francesco, outreachy-kernel, linux-staging, linux-kernel
On Sat, 10 Apr 2021, Greg KH wrote:
> On Sat, Apr 10, 2021 at 09:57:00AM +0200, Fabio M. De Francesco wrote:
> > On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote:
> > > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote:
> > > > This patch series removes camelcases, changes the type and use of a
> > > > variable, and correct misspelled words.
> > > >
> > > > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files
> > > >
> > > > drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> > > > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
> > > > drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 +++++++++---------
> > > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > > > drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 6 +++---
> > > > .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +-
> > > > drivers/staging/rtl8723bs/hal/sdio_ops.c | 14 +++++++-------
> > > > .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > > 8 files changed, 24 insertions(+), 24 deletions(-)
> > > >
> > > > Patch 2/3: staging: rtl8723bs: Change the type and use of a variable
> > > >
> > > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > > >
> > > > drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > Patch 3/3: staging: rtl8723bs: include: Fix misspelled words in
> > > > comments
> > > >
> > > > .../rtl8723bs/include/Hal8192CPhyReg.h | 8 ++---
> > > >
> > > > .../staging/rtl8723bs/include/basic_types.h | 2 +-
> > > > drivers/staging/rtl8723bs/include/drv_types.h | 2 +-
> > > > drivers/staging/rtl8723bs/include/hal_com.h | 2 +-
> > > > .../staging/rtl8723bs/include/hal_com_reg.h | 34 +++++++++----------
> > > > drivers/staging/rtl8723bs/include/hal_data.h | 2 +-
> > > > .../staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
> > > > drivers/staging/rtl8723bs/include/rtw_cmd.h | 6 ++--
> > > > drivers/staging/rtl8723bs/include/rtw_mlme.h | 18 +++++-----
> > > > .../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
> > > > drivers/staging/rtl8723bs/include/rtw_mp.h | 2 +-
> > > > .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > > drivers/staging/rtl8723bs/include/rtw_recv.h | 4 +--
> > > > drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +-
> > > > drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
> > > > drivers/staging/rtl8723bs/include/wifi.h | 2 +-
> > > > 16 files changed, 46 insertions(+), 46 deletions(-)
> > > >
> > > > Fabio M. De Francesco
> > >
> > > I have no idea how you created this patch series, but I do not think it
> > > worked well :(
> > >
> > > Please use our standard tools, that do this all for you automatically,
> > >
> > Apart from the fact that I forgot to save the subject, I didn't know that
> > there are standard tools for doing Patch 0/N. Therefore I thought to make
> > an email message that contained the information about the patch series.
> >
> > I was wrong, sorry. I have to research this topic in the git manual or
> > somewhere else.
>
> 'git format-patch --cover-letter main..HEAD' will to the trick, if you
> are on a different branch from 'main'. Then edit the 0000-* file and
> then send them all off with 'git send-email'.
Fabio,
The --cover-letter option is discussed in the "Versioning patchsets"
section of the tutorial. Perhaps that is not the best place for it, since
the need for a cover letter is not specific to versioning...
julia
>
> thanks,
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YHFcI104K%2Bih3UDG%40kroah.com.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [Patch 0/3]
@ 2021-04-10 8:22 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2021-04-10 8:22 UTC (permalink / raw)
To: Greg KH
Cc: Fabio M. De Francesco, outreachy-kernel, linux-staging, linux-kernel
On Sat, 10 Apr 2021, Greg KH wrote:
> On Sat, Apr 10, 2021 at 09:57:00AM +0200, Fabio M. De Francesco wrote:
> > On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote:
> > > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote:
> > > > This patch series removes camelcases, changes the type and use of a
> > > > variable, and correct misspelled words.
> > > >
> > > > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files
> > > >
> > > > drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> > > > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
> > > > drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 +++++++++---------
> > > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > > > drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 6 +++---
> > > > .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +-
> > > > drivers/staging/rtl8723bs/hal/sdio_ops.c | 14 +++++++-------
> > > > .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > > 8 files changed, 24 insertions(+), 24 deletions(-)
> > > >
> > > > Patch 2/3: staging: rtl8723bs: Change the type and use of a variable
> > > >
> > > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > > >
> > > > drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > Patch 3/3: staging: rtl8723bs: include: Fix misspelled words in
> > > > comments
> > > >
> > > > .../rtl8723bs/include/Hal8192CPhyReg.h | 8 ++---
> > > >
> > > > .../staging/rtl8723bs/include/basic_types.h | 2 +-
> > > > drivers/staging/rtl8723bs/include/drv_types.h | 2 +-
> > > > drivers/staging/rtl8723bs/include/hal_com.h | 2 +-
> > > > .../staging/rtl8723bs/include/hal_com_reg.h | 34 +++++++++----------
> > > > drivers/staging/rtl8723bs/include/hal_data.h | 2 +-
> > > > .../staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
> > > > drivers/staging/rtl8723bs/include/rtw_cmd.h | 6 ++--
> > > > drivers/staging/rtl8723bs/include/rtw_mlme.h | 18 +++++-----
> > > > .../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
> > > > drivers/staging/rtl8723bs/include/rtw_mp.h | 2 +-
> > > > .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > > drivers/staging/rtl8723bs/include/rtw_recv.h | 4 +--
> > > > drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +-
> > > > drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
> > > > drivers/staging/rtl8723bs/include/wifi.h | 2 +-
> > > > 16 files changed, 46 insertions(+), 46 deletions(-)
> > > >
> > > > Fabio M. De Francesco
> > >
> > > I have no idea how you created this patch series, but I do not think it
> > > worked well :(
> > >
> > > Please use our standard tools, that do this all for you automatically,
> > >
> > Apart from the fact that I forgot to save the subject, I didn't know that
> > there are standard tools for doing Patch 0/N. Therefore I thought to make
> > an email message that contained the information about the patch series.
> >
> > I was wrong, sorry. I have to research this topic in the git manual or
> > somewhere else.
>
> 'git format-patch --cover-letter main..HEAD' will to the trick, if you
> are on a different branch from 'main'. Then edit the 0000-* file and
> then send them all off with 'git send-email'.
Fabio,
The --cover-letter option is discussed in the "Versioning patchsets"
section of the tutorial. Perhaps that is not the best place for it, since
the need for a cover letter is not specific to versioning...
julia
>
> thanks,
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YHFcI104K%2Bih3UDG%40kroah.com.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-04-10 8:23 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 16:29 [Outreachy kernel] [Patch 0/3] Fabio M. De Francesco
2021-04-10 7:29 ` Greg KH
2021-04-10 7:57 ` Fabio M. De Francesco
2021-04-10 8:04 ` Greg KH
2021-04-10 8:22 ` Julia Lawall
2021-04-10 8:22 ` Julia Lawall
2021-04-10 8:20 ` Julia Lawall
2021-04-10 8:20 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.