* [PATCH] MIPS: VDSO: Drop duplicated -I*/-E* aflags
@ 2016-10-07 9:23 ` James Hogan
0 siblings, 0 replies; 4+ messages in thread
From: James Hogan @ 2016-10-07 9:23 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Maciej W . Rozycki, James Hogan, linux-mips
The aflags-vdso is based on ccflags-vdso, which already contains the -I*
and -EL/-EB flags from KBUILD_CFLAGS, but those flags are needlessly
added again to aflags-vdso.
Drop the duplication.
Reported-by: Maciej W. Rozycki <macro@imgtec.com>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
---
arch/mips/vdso/Makefile | 2 --
1 file changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile
index de9e8836d248..c3dc12a8b7d9 100644
--- a/arch/mips/vdso/Makefile
+++ b/arch/mips/vdso/Makefile
@@ -13,8 +13,6 @@ cflags-vdso := $(ccflags-vdso) \
-DDISABLE_BRANCH_PROFILING \
$(call cc-option, -fno-stack-protector)
aflags-vdso := $(ccflags-vdso) \
- $(filter -I%,$(KBUILD_CFLAGS)) \
- $(filter -E%,$(KBUILD_CFLAGS)) \
-D__ASSEMBLY__ -Wa,-gdwarf-2
#
--
git-series 0.8.10
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] MIPS: VDSO: Drop duplicated -I*/-E* aflags
@ 2016-10-07 9:23 ` James Hogan
0 siblings, 0 replies; 4+ messages in thread
From: James Hogan @ 2016-10-07 9:23 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Maciej W . Rozycki, James Hogan, linux-mips
The aflags-vdso is based on ccflags-vdso, which already contains the -I*
and -EL/-EB flags from KBUILD_CFLAGS, but those flags are needlessly
added again to aflags-vdso.
Drop the duplication.
Reported-by: Maciej W. Rozycki <macro@imgtec.com>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
---
arch/mips/vdso/Makefile | 2 --
1 file changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile
index de9e8836d248..c3dc12a8b7d9 100644
--- a/arch/mips/vdso/Makefile
+++ b/arch/mips/vdso/Makefile
@@ -13,8 +13,6 @@ cflags-vdso := $(ccflags-vdso) \
-DDISABLE_BRANCH_PROFILING \
$(call cc-option, -fno-stack-protector)
aflags-vdso := $(ccflags-vdso) \
- $(filter -I%,$(KBUILD_CFLAGS)) \
- $(filter -E%,$(KBUILD_CFLAGS)) \
-D__ASSEMBLY__ -Wa,-gdwarf-2
#
--
git-series 0.8.10
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: VDSO: Drop duplicated -I*/-E* aflags
@ 2016-10-07 15:22 ` Maciej W. Rozycki
0 siblings, 0 replies; 4+ messages in thread
From: Maciej W. Rozycki @ 2016-10-07 15:22 UTC (permalink / raw)
To: James Hogan; +Cc: Ralf Baechle, linux-mips
On Fri, 7 Oct 2016, James Hogan wrote:
> The aflags-vdso is based on ccflags-vdso, which already contains the -I*
> and -EL/-EB flags from KBUILD_CFLAGS, but those flags are needlessly
> added again to aflags-vdso.
>
> Drop the duplication.
>
> Reported-by: Maciej W. Rozycki <macro@imgtec.com>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> ---
Reviewed-by: Maciej W. Rozycki <macro@imgtec.com>
Maciej
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: VDSO: Drop duplicated -I*/-E* aflags
@ 2016-10-07 15:22 ` Maciej W. Rozycki
0 siblings, 0 replies; 4+ messages in thread
From: Maciej W. Rozycki @ 2016-10-07 15:22 UTC (permalink / raw)
To: James Hogan; +Cc: Ralf Baechle, linux-mips
On Fri, 7 Oct 2016, James Hogan wrote:
> The aflags-vdso is based on ccflags-vdso, which already contains the -I*
> and -EL/-EB flags from KBUILD_CFLAGS, but those flags are needlessly
> added again to aflags-vdso.
>
> Drop the duplication.
>
> Reported-by: Maciej W. Rozycki <macro@imgtec.com>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> ---
Reviewed-by: Maciej W. Rozycki <macro@imgtec.com>
Maciej
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-07 15:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-07 9:23 [PATCH] MIPS: VDSO: Drop duplicated -I*/-E* aflags James Hogan
2016-10-07 9:23 ` James Hogan
2016-10-07 15:22 ` Maciej W. Rozycki
2016-10-07 15:22 ` Maciej W. Rozycki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.