All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrei Lifchits <andrei.lifchits@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH] libvhd: use UTC for VHD timestamp
Date: Fri, 30 Aug 2013 16:52:24 +0100	[thread overview]
Message-ID: <21024.49080.965845.357206@mariner.uk.xensource.com> (raw)
In-Reply-To: <20130830155013.GY15729@zion.uk.xensource.com>

Wei Liu writes ("Re: [PATCH] libvhd: use UTC for VHD timestamp"):
> Update commit message.

Thanks.

> From: Wei Liu <wei.liu2@citrix.com>
> Date: Fri, 30 Aug 2013 12:33:33 +0100
> Subject: [PATCH] libvhd: use UTC for VHD timestamp
> 
> [ported from xapi-project/blktap a79ac2c05f9 ("XOP-289: use UTC for VHD
> timestamps")]
> 
> Currently, the local timezone is factored into VHD timestamps due to the
> use of mktime(). This breaks "vhd-util check" for VHDs created in one
> timezone and then moved westward, which results in "primary footer
> invalid: creation time in future" errors.

The existing code here is, erm, "surprising".  Thanks for your
attention to it!

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Ian.

  reply	other threads:[~2013-08-30 15:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30 13:07 [PATCH] libvhd: use UTC for VHD timestamp Wei Liu
2013-08-30 15:50 ` Wei Liu
2013-08-30 15:52   ` Ian Jackson [this message]
2013-09-03 16:32     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21024.49080.965845.357206@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=andrei.lifchits@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.