All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: "Kishon Vijay Abraham I" <kishon@ti.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Rob Herring" <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	<linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 15/15] ARM: dts: dra7: Add high speed modes capability to MMC1/MMC2 dt node
Date: Wed, 7 Feb 2018 14:41:48 +0530	[thread overview]
Message-ID: <210939ed-67fc-fa37-b4f2-c1faefcc4642@ti.com> (raw)
In-Reply-To: <20180206125806.19350-16-kishon@ti.com>

Kishon,

On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote:
> Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

Along with this, dont we need to have

	/delete-property/ mmc-hs200-1_8v;

for eMMC on Beagle x15 which does not support HS200?

Or are you planning to depend on lack of pinctrl entries for HS200 to
take care of that?

Thanks,
Sekhar


> ---
>  arch/arm/boot/dts/dra7.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 7bf33d522b14..feb496e7c5ef 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -1073,7 +1073,13 @@
>  			status = "disabled";
>  			pbias-supply = <&pbias_mmc_reg>;
>  			max-frequency = <192000000>;
> +			sd-uhs-sdr104;
> +			sd-uhs-sdr50;
> +			sd-uhs-ddr50;
> +			sd-uhs-sdr25;
> +			sd-uhs-sdr12;
>  			cap-sd-highspeed;
> +			mmc-ddr-1_8v;
>  			cap-mmc-highspeed;
>  		};
>  
> @@ -1092,6 +1098,10 @@
>  			status = "disabled";
>  			max-frequency = <192000000>;
>  			cap-sd-highspeed;
> +			sd-uhs-sdr25;
> +			sd-uhs-sdr12;
> +			mmc-hs200-1_8v;
> +			mmc-ddr-1_8v;
>  			cap-mmc-highspeed;
>  		};
>  
> -- 
> 2.11.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
To: "Kishon Vijay Abraham I" <kishon-l0cyMroinI0@public.gmane.org>,
	"Benoît Cousson"
	<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	"Tony Lindgren" <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 15/15] ARM: dts: dra7: Add high speed modes capability to MMC1/MMC2 dt node
Date: Wed, 7 Feb 2018 14:41:48 +0530	[thread overview]
Message-ID: <210939ed-67fc-fa37-b4f2-c1faefcc4642@ti.com> (raw)
In-Reply-To: <20180206125806.19350-16-kishon-l0cyMroinI0@public.gmane.org>

Kishon,

On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote:
> Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>

Along with this, dont we need to have

	/delete-property/ mmc-hs200-1_8v;

for eMMC on Beagle x15 which does not support HS200?

Or are you planning to depend on lack of pinctrl entries for HS200 to
take care of that?

Thanks,
Sekhar


> ---
>  arch/arm/boot/dts/dra7.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 7bf33d522b14..feb496e7c5ef 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -1073,7 +1073,13 @@
>  			status = "disabled";
>  			pbias-supply = <&pbias_mmc_reg>;
>  			max-frequency = <192000000>;
> +			sd-uhs-sdr104;
> +			sd-uhs-sdr50;
> +			sd-uhs-ddr50;
> +			sd-uhs-sdr25;
> +			sd-uhs-sdr12;
>  			cap-sd-highspeed;
> +			mmc-ddr-1_8v;
>  			cap-mmc-highspeed;
>  		};
>  
> @@ -1092,6 +1098,10 @@
>  			status = "disabled";
>  			max-frequency = <192000000>;
>  			cap-sd-highspeed;
> +			sd-uhs-sdr25;
> +			sd-uhs-sdr12;
> +			mmc-hs200-1_8v;
> +			mmc-ddr-1_8v;
>  			cap-mmc-highspeed;
>  		};
>  
> -- 
> 2.11.0
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 15/15] ARM: dts: dra7: Add high speed modes capability to MMC1/MMC2 dt node
Date: Wed, 7 Feb 2018 14:41:48 +0530	[thread overview]
Message-ID: <210939ed-67fc-fa37-b4f2-c1faefcc4642@ti.com> (raw)
In-Reply-To: <20180206125806.19350-16-kishon@ti.com>

Kishon,

On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote:
> Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

Along with this, dont we need to have

	/delete-property/ mmc-hs200-1_8v;

for eMMC on Beagle x15 which does not support HS200?

Or are you planning to depend on lack of pinctrl entries for HS200 to
take care of that?

Thanks,
Sekhar


> ---
>  arch/arm/boot/dts/dra7.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 7bf33d522b14..feb496e7c5ef 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -1073,7 +1073,13 @@
>  			status = "disabled";
>  			pbias-supply = <&pbias_mmc_reg>;
>  			max-frequency = <192000000>;
> +			sd-uhs-sdr104;
> +			sd-uhs-sdr50;
> +			sd-uhs-ddr50;
> +			sd-uhs-sdr25;
> +			sd-uhs-sdr12;
>  			cap-sd-highspeed;
> +			mmc-ddr-1_8v;
>  			cap-mmc-highspeed;
>  		};
>  
> @@ -1092,6 +1098,10 @@
>  			status = "disabled";
>  			max-frequency = <192000000>;
>  			cap-sd-highspeed;
> +			sd-uhs-sdr25;
> +			sd-uhs-sdr12;
> +			mmc-hs200-1_8v;
> +			mmc-ddr-1_8v;
>  			cap-mmc-highspeed;
>  		};
>  
> -- 
> 2.11.0
> 

  reply	other threads:[~2018-02-07  9:12 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 12:57 [PATCH v2 00/15] dra7: mmc: Update mmc dt node Kishon Vijay Abraham I
2018-02-06 12:57 ` Kishon Vijay Abraham I
2018-02-06 12:57 ` Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 01/15] ARM: multi_v7_defconfig: Enable CONFIG_MMC_SDHCI_OMAP Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 02/15] ARM: omap2plus_defconfig: " Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 03/15] ARM: dts: dra76x: Create a common file with MMC/SD IOdelay data Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 04/15] ARM: dts: dra76-evm: Shift to using common " Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 05/15] ARM: dts: dra76-evm: Add pinctrl data for higher speed MMC/SD modes Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 06/15] ARM: dts: am57xx-beagle-x15: Add "vqmmc-supply" property for mmc2 Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 07/15] ARM: dts: dra7-evm: Remove mmc specific pinmux Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 08/15] ARM: dts: dra7-evm: Add "vqmmc-supply" property for mmc2 Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:57   ` Kishon Vijay Abraham I
2018-02-06 12:58 ` [PATCH v2 09/15] ARM: dts: am57xx-idk: " Kishon Vijay Abraham I
2018-02-06 12:58   ` Kishon Vijay Abraham I
2018-02-06 12:58   ` Kishon Vijay Abraham I
2018-02-06 12:58 ` [PATCH v2 10/15] ARM: dts: dra76-evm: " Kishon Vijay Abraham I
2018-02-06 12:58   ` Kishon Vijay Abraham I
2018-02-06 12:58   ` Kishon Vijay Abraham I
2018-02-06 12:58 ` [PATCH v2 11/15] ARM: dts: dra71-evm: Correct evm_sd regulator max voltage Kishon Vijay Abraham I
2018-02-06 12:58   ` Kishon Vijay Abraham I
2018-02-06 12:58   ` Kishon Vijay Abraham I
2018-02-06 12:58 ` [PATCH v2 12/15] ARM: dts: dra71-evm: Select pull down for mmc1_clk line in default mode Kishon Vijay Abraham I
2018-02-06 12:58   ` Kishon Vijay Abraham I
2018-02-06 12:58   ` Kishon Vijay Abraham I
2018-02-06 12:58 ` [PATCH v2 13/15] ARM: dts: am57xx-idk: " Kishon Vijay Abraham I
2018-02-06 12:58   ` Kishon Vijay Abraham I
2018-02-06 12:58   ` Kishon Vijay Abraham I
2018-02-06 12:58 ` [PATCH v2 14/15] ARM: dts: dra7: Use sdhci-omap programming model Kishon Vijay Abraham I
2018-02-06 12:58   ` Kishon Vijay Abraham I
2018-02-06 12:58   ` Kishon Vijay Abraham I
2018-02-06 12:58 ` [PATCH v2 15/15] ARM: dts: dra7: Add high speed modes capability to MMC1/MMC2 dt node Kishon Vijay Abraham I
2018-02-06 12:58   ` Kishon Vijay Abraham I
2018-02-06 12:58   ` Kishon Vijay Abraham I
2018-02-07  9:11   ` Sekhar Nori [this message]
2018-02-07  9:11     ` Sekhar Nori
2018-02-07  9:11     ` Sekhar Nori
2018-02-07  9:21     ` Kishon Vijay Abraham I
2018-02-07  9:21       ` Kishon Vijay Abraham I
2018-02-07  9:21       ` Kishon Vijay Abraham I
2018-02-07  9:27       ` Sekhar Nori
2018-02-07  9:27         ` Sekhar Nori
2018-02-07  9:27         ` Sekhar Nori
2018-02-13 11:10       ` Sekhar Nori
2018-02-13 11:10         ` Sekhar Nori
2018-02-13 11:10         ` Sekhar Nori
2018-02-28 22:34         ` Tony Lindgren
2018-02-28 22:34           ` Tony Lindgren
2018-03-01  5:18           ` Kishon Vijay Abraham I
2018-03-01  5:18             ` Kishon Vijay Abraham I
2018-03-01  5:18             ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=210939ed-67fc-fa37-b4f2-c1faefcc4642@ti.com \
    --to=nsekhar@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.