* [PATCH v2] timer: allow timer reset on service cores
@ 2017-09-06 10:03 Pavan Nikhilesh
2017-09-21 20:10 ` [PATCH v3] " Pavan Nikhilesh
0 siblings, 1 reply; 3+ messages in thread
From: Pavan Nikhilesh @ 2017-09-06 10:03 UTC (permalink / raw)
To: harry.van.haaren, rsanford; +Cc: dev, Pavan Bhagavatula
From: Pavan Bhagavatula <pbhagavatula@caviumnetworks.com>
API rte_timer_reset() should be able to register timers on service
lcores as they are EAL threads.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
---
This patch depends on http://dpdk.org/dev/patchwork/patch/27818/
v2 changes:
-modified the commit title.
lib/librte_timer/rte_timer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
index 5ee0840..a5a045c 100644
--- a/lib/librte_timer/rte_timer.c
+++ b/lib/librte_timer/rte_timer.c
@@ -432,7 +432,8 @@ rte_timer_reset(struct rte_timer *tim, uint64_t ticks,
uint64_t period;
if (unlikely((tim_lcore != (unsigned)LCORE_ID_ANY) &&
- !rte_lcore_is_enabled(tim_lcore)))
+ !(rte_lcore_is_enabled(tim_lcore) ||
+ rte_lcore_is_service_lcore(tim_lcore))))
return -1;
if (type == PERIODICAL)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v3] timer: allow timer reset on service cores
2017-09-06 10:03 [PATCH v2] timer: allow timer reset on service cores Pavan Nikhilesh
@ 2017-09-21 20:10 ` Pavan Nikhilesh
2017-10-11 20:34 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Pavan Nikhilesh @ 2017-09-21 20:10 UTC (permalink / raw)
To: harry.van.haaren, rsanford; +Cc: dev, Pavan Bhagavatula
From: Pavan Bhagavatula <pbhagavatula@caviumnetworks.com>
The rte_timer_reset function should be able to register timers on service
lcores as they are EAL threads.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
---
This patch depends on http://dpdk.org/dev/patchwork/patch/29056/
v3 changes:
-updated the API as per the new lcore role API
v2 changes:
-modified the commit title.
lib/librte_timer/rte_timer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
index 5ee0840..ec86744 100644
--- a/lib/librte_timer/rte_timer.c
+++ b/lib/librte_timer/rte_timer.c
@@ -432,7 +432,8 @@ rte_timer_reset(struct rte_timer *tim, uint64_t ticks,
uint64_t period;
if (unlikely((tim_lcore != (unsigned)LCORE_ID_ANY) &&
- !rte_lcore_is_enabled(tim_lcore)))
+ !(rte_lcore_is_enabled(tim_lcore) ||
+ rte_lcore_has_role(tim_lcore, ROLE_SERVICE))))
return -1;
if (type == PERIODICAL)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] timer: allow timer reset on service cores
2017-09-21 20:10 ` [PATCH v3] " Pavan Nikhilesh
@ 2017-10-11 20:34 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-10-11 20:34 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: dev, harry.van.haaren, rsanford
21/09/2017 22:10, Pavan Nikhilesh:
> From: Pavan Bhagavatula <pbhagavatula@caviumnetworks.com>
>
> The rte_timer_reset function should be able to register timers on service
> lcores as they are EAL threads.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-11 20:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-06 10:03 [PATCH v2] timer: allow timer reset on service cores Pavan Nikhilesh
2017-09-21 20:10 ` [PATCH v3] " Pavan Nikhilesh
2017-10-11 20:34 ` Thomas Monjalon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.