* Re: Re: [PATCH v2] net: fix null pointer dereference when parsing ICMP6_ROUTER_ADVERTISE messages
@ 2022-04-21 13:56 zhangqiumiao
2022-04-21 17:39 ` Daniel Kiper
0 siblings, 1 reply; 2+ messages in thread
From: zhangqiumiao @ 2022-04-21 13:56 UTC (permalink / raw)
To: Daniel Kiper
Cc: grub-devel, Fengtao (fengtao, Euler), Chenxiang (EulerOS),
Zhaowei (EulerOS)
On Thu, Apr 21, 2022 at 21:41:52PM +0800, Daniel Kiper wrote:
> On Sat, Apr 16, 2022 at 09:50:11AM +0800, Qiumiao Zhang via Grub-devel wrote:
> > During UEFI PXE boot in IPv6 network, if the DHCP server adopts
> > stateful automatic configuration, then the client receives a
> > ICMP6_ROUTER_ADVERTISE multicast message from the server. This may be
> > received without the interfaced having a configured network address,
> > so orig_inf will be null, which can lead to a null dereference when
> > creating the default route. Actually, in this case, the client obtains
> > the default route through DHCPv6 instead of RA messages. So if
> > orig_inf == NULL and route_inf == null, we should not set the default
> > route.
> >
> > Fixes bug: https://savannah.gnu.org/bugs/index.php?62072
> Missing "Signed-off-by: Qiumiao Zhang <zhangqiumiao1@huawei.com>" line.
> May I add it on behalf of you?
Yes, that's perfect.
> Otherwise Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Qiumiao
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Re: [PATCH v2] net: fix null pointer dereference when parsing ICMP6_ROUTER_ADVERTISE messages
2022-04-21 13:56 Re: [PATCH v2] net: fix null pointer dereference when parsing ICMP6_ROUTER_ADVERTISE messages zhangqiumiao
@ 2022-04-21 17:39 ` Daniel Kiper
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Kiper @ 2022-04-21 17:39 UTC (permalink / raw)
To: zhangqiumiao
Cc: grub-devel, Fengtao (fengtao, Euler), Chenxiang (EulerOS),
Zhaowei (EulerOS)
On Thu, Apr 21, 2022 at 01:56:35PM +0000, zhangqiumiao via Grub-devel wrote:
> On Thu, Apr 21, 2022 at 21:41:52PM +0800, Daniel Kiper wrote:
> > On Sat, Apr 16, 2022 at 09:50:11AM +0800, Qiumiao Zhang via Grub-devel wrote:
> > > During UEFI PXE boot in IPv6 network, if the DHCP server adopts
> > > stateful automatic configuration, then the client receives a
> > > ICMP6_ROUTER_ADVERTISE multicast message from the server. This may be
> > > received without the interfaced having a configured network address,
> > > so orig_inf will be null, which can lead to a null dereference when
> > > creating the default route. Actually, in this case, the client obtains
> > > the default route through DHCPv6 instead of RA messages. So if
> > > orig_inf == NULL and route_inf == null, we should not set the default
> > > route.
> > >
> > > Fixes bug: https://savannah.gnu.org/bugs/index.php?62072
>
> > Missing "Signed-off-by: Qiumiao Zhang <zhangqiumiao1@huawei.com>" line.
> > May I add it on behalf of you?
>
> Yes, that's perfect.
Cool! Thank you for fixing this!
Daniel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-21 17:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 13:56 Re: [PATCH v2] net: fix null pointer dereference when parsing ICMP6_ROUTER_ADVERTISE messages zhangqiumiao
2022-04-21 17:39 ` Daniel Kiper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.