* Compiling: error: cast increases required alignment of target type [-Werror=cast-align]
@ 2019-02-04 22:28 =?unknown-8bit?q?Pi=C4=8Dugins?= Arsenijs
2019-02-08 20:15 ` Denis Kenzior
0 siblings, 1 reply; 5+ messages in thread
From: =?unknown-8bit?q?Pi=C4=8Dugins?= Arsenijs @ 2019-02-04 22:28 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 1088 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Compiling: error: cast increases required alignment of target type [-Werror=cast-align]
2019-02-04 22:28 Compiling: error: cast increases required alignment of target type [-Werror=cast-align] =?unknown-8bit?q?Pi=C4=8Dugins?= Arsenijs
@ 2019-02-08 20:15 ` Denis Kenzior
2019-06-21 9:52 ` Martin =?unknown-8bit?q?Hundeb=C3=B8ll?=
0 siblings, 1 reply; 5+ messages in thread
From: Denis Kenzior @ 2019-02-08 20:15 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
Hi,
On 02/04/2019 04:28 PM, Pičugins Arsenijs wrote:
> CC drivers/mbimmodem/mbim-message.o
> drivers/mbimmodem/mbim-message.c: In function ‘_iter_copy_string’:
> drivers/mbimmodem/mbim-message.c:199:18: error: cast increases required
> alignment of target type [-Werror=cast-align]
> uint16_t *le = (uint16_t *) buf;
> ^
Does the attached patch fix this?
Regards,
-Denis
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-mbim-Fix-compile-warning.patch --]
[-- Type: text/x-patch, Size: 1523 bytes --]
>From 85b218730efad7143b9be0c3653ad3f4545ff0c7 Mon Sep 17 00:00:00 2001
From: Denis Kenzior <denkenz@gmail.com>
Date: Fri, 8 Feb 2019 14:14:09 -0600
Subject: [PATCH] mbim: Fix compile warning
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
CC drivers/mbimmodem/mbim-message.o
drivers/mbimmodem/mbim-message.c: In function ‘_iter_copy_string’:
drivers/mbimmodem/mbim-message.c:199:18: error: cast increases required alignment of target type [-Werror=cast-align]
uint16_t *le = (uint16_t *) buf;
^
---
drivers/mbimmodem/mbim-message.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mbimmodem/mbim-message.c b/drivers/mbimmodem/mbim-message.c
index 7899bc65..0c117658 100644
--- a/drivers/mbimmodem/mbim-message.c
+++ b/drivers/mbimmodem/mbim-message.c
@@ -153,8 +153,8 @@ static bool _iter_copy_string(struct mbim_message_iter *iter,
uint32_t offset, uint32_t len,
char **out)
{
- uint8_t buf[len];
- uint8_t *dest = buf;
+ uint16_t buf[len / 2 + 1];
+ uint8_t *dest = (uint8_t *) buf;
uint32_t remaining = len;
uint32_t iov_start = 0;
uint32_t i = 0;
@@ -196,7 +196,7 @@ static bool _iter_copy_string(struct mbim_message_iter *iter,
/* Strings are in UTF16-LE, so convert to UTF16-CPU first if needed */
if (L_CPU_TO_LE16(0x8000) != 0x8000) {
- uint16_t *le = (uint16_t *) buf;
+ uint16_t *le = buf;
for (i = 0; i < len / 2; i++)
le[i] = __builtin_bswap16(le[i]);
--
2.13.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: Compiling: error: cast increases required alignment of target type [-Werror=cast-align]
2019-02-08 20:15 ` Denis Kenzior
@ 2019-06-21 9:52 ` Martin =?unknown-8bit?q?Hundeb=C3=B8ll?=
2019-06-21 17:48 ` Denis Kenzior
0 siblings, 1 reply; 5+ messages in thread
From: Martin =?unknown-8bit?q?Hundeb=C3=B8ll?= @ 2019-06-21 9:52 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
Hi Denis,
On 08/02/2019 21.15, Denis Kenzior wrote:
> Hi,
>
> On 02/04/2019 04:28 PM, Pičugins Arsenijs wrote:
>> CC drivers/mbimmodem/mbim-message.o
>> drivers/mbimmodem/mbim-message.c: In function ‘_iter_copy_string’:
>> drivers/mbimmodem/mbim-message.c:199:18: error: cast increases
>> required alignment of target type [-Werror=cast-align]
>> uint16_t *le = (uint16_t *) buf;
>> ^
>
> Does the attached patch fix this?
It fixes it for me. Please apply.
// Martin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Compiling: error: cast increases required alignment of target type [-Werror=cast-align]
2019-06-21 9:52 ` Martin =?unknown-8bit?q?Hundeb=C3=B8ll?=
@ 2019-06-21 17:48 ` Denis Kenzior
2019-06-22 5:40 ` Marcel Holtmann
0 siblings, 1 reply; 5+ messages in thread
From: Denis Kenzior @ 2019-06-21 17:48 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
Hi Martin,
On 06/21/2019 04:52 AM, Martin Hundebøll wrote:
> Hi Denis,
>
> On 08/02/2019 21.15, Denis Kenzior wrote:
>> Hi,
>>
>> On 02/04/2019 04:28 PM, Pičugins Arsenijs wrote:
>>> CC drivers/mbimmodem/mbim-message.o
>>> drivers/mbimmodem/mbim-message.c: In function ‘_iter_copy_string’:
>>> drivers/mbimmodem/mbim-message.c:199:18: error: cast increases
>>> required alignment of target type [-Werror=cast-align]
>>> uint16_t *le = (uint16_t *) buf;
>>> ^
>>
>> Does the attached patch fix this?
>
> It fixes it for me. Please apply.
>
> // Martin
All right, applied.
Regards,
-Denis
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Compiling: error: cast increases required alignment of target type [-Werror=cast-align]
2019-06-21 17:48 ` Denis Kenzior
@ 2019-06-22 5:40 ` Marcel Holtmann
0 siblings, 0 replies; 5+ messages in thread
From: Marcel Holtmann @ 2019-06-22 5:40 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
Hi Denis,
>>> On 02/04/2019 04:28 PM, Pičugins Arsenijs wrote:
>>>> CC drivers/mbimmodem/mbim-message.o
>>>> drivers/mbimmodem/mbim-message.c: In function ‘_iter_copy_string’:
>>>> drivers/mbimmodem/mbim-message.c:199:18: error: cast increases required alignment of target type [-Werror=cast-align]
>>>> uint16_t *le = (uint16_t *) buf;
>>>> ^
>>>
>>> Does the attached patch fix this?
>> It fixes it for me. Please apply.
>> // Martin
>
> All right, applied.
I wonder if using l_get_u16 here to ensure that we always get the alignment right isn’t better.
Regards
Marcel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-22 5:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-04 22:28 Compiling: error: cast increases required alignment of target type [-Werror=cast-align] =?unknown-8bit?q?Pi=C4=8Dugins?= Arsenijs
2019-02-08 20:15 ` Denis Kenzior
2019-06-21 9:52 ` Martin =?unknown-8bit?q?Hundeb=C3=B8ll?=
2019-06-21 17:48 ` Denis Kenzior
2019-06-22 5:40 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.