* next-20141126 build failures in wd719x
[not found] <E1XtdBa-00087r-J4@debutante>
@ 2014-11-26 17:26 ` Mark Brown
2014-11-26 17:41 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2014-11-26 17:26 UTC (permalink / raw)
To: Ondrej Zary, Hannes Reinecke, Christoph Hellwig, James E.J. Bottomley
Cc: kernel-build-reports, linaro-kernel, linux-scsi, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Wed, Nov 26, 2014 at 02:03:14PM +0000, Build bot for Mark Brown wrote:
The wd719x driver fails to build on at least arm and arm64 in today's
-next since:
> arm64-allmodconfig
> ../drivers/scsi/wd719x.c:247:2: error: implicit declaration of function 'dma_cache_sync' [-Werror=implicit-function-declaration]
>
> arm-allmodconfig
> ../drivers/scsi/wd719x.c:247:2: error: implicit declaration of function 'dma_cache_sync' [-Werror=implicit-function-declaration]
dma_cache_sync() is not available on these architectures. I can't
immediately see something to depend on that'd exclude the driver from
these architectures, the other users seem to all have architecture
specific dependencies.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: next-20141126 build failures in wd719x
2014-11-26 17:26 ` next-20141126 build failures in wd719x Mark Brown
@ 2014-11-26 17:41 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2014-11-26 17:41 UTC (permalink / raw)
To: kernel-build-reports
Cc: Mark Brown, Ondrej Zary, Hannes Reinecke, Christoph Hellwig,
James E.J. Bottomley, linaro-kernel, linux-arm-kernel,
linux-scsi
On Wednesday 26 November 2014 17:26:06 Mark Brown wrote:
> On Wed, Nov 26, 2014 at 02:03:14PM +0000, Build bot for Mark Brown wrote:
>
> The wd719x driver fails to build on at least arm and arm64 in today's
> -next since:
>
> > arm64-allmodconfig
> > ../drivers/scsi/wd719x.c:247:2: error: implicit declaration of function 'dma_cache_sync' [-Werror=implicit-function-declaration]
> >
> > arm-allmodconfig
> > ../drivers/scsi/wd719x.c:247:2: error: implicit declaration of function 'dma_cache_sync' [-Werror=implicit-function-declaration]
>
> dma_cache_sync() is not available on these architectures. I can't
> immediately see something to depend on that'd exclude the driver from
> these architectures, the other users seem to all have architecture
> specific dependencies.
I think the use of dma_cache_sync in this driver is just a bug:
cmd->SCp.dma_handle = dma_map_single(&wd->pdev->dev, cmd->sense_buffer,
SCSI_SENSE_BUFFERSIZE, DMA_FROM_DEVICE);
dma_cache_sync(&wd->pdev->dev, cmd->sense_buffer,
SCSI_SENSE_BUFFERSIZE, DMA_FROM_DEVICE);
dma_cache_sync only makes sense with buffers allocated through
dma_alloc_noncoherent(), which this one is not. I suspect we can just
remove the call to dma_cache_sync here, in particular since the
buffer is passed to the device next, and dma_map_single has
already done all the necessary synchronization.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
* next-20141126 build failures in wd719x
@ 2014-11-26 17:41 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2014-11-26 17:41 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 26 November 2014 17:26:06 Mark Brown wrote:
> On Wed, Nov 26, 2014 at 02:03:14PM +0000, Build bot for Mark Brown wrote:
>
> The wd719x driver fails to build on at least arm and arm64 in today's
> -next since:
>
> > arm64-allmodconfig
> > ../drivers/scsi/wd719x.c:247:2: error: implicit declaration of function 'dma_cache_sync' [-Werror=implicit-function-declaration]
> >
> > arm-allmodconfig
> > ../drivers/scsi/wd719x.c:247:2: error: implicit declaration of function 'dma_cache_sync' [-Werror=implicit-function-declaration]
>
> dma_cache_sync() is not available on these architectures. I can't
> immediately see something to depend on that'd exclude the driver from
> these architectures, the other users seem to all have architecture
> specific dependencies.
I think the use of dma_cache_sync in this driver is just a bug:
cmd->SCp.dma_handle = dma_map_single(&wd->pdev->dev, cmd->sense_buffer,
SCSI_SENSE_BUFFERSIZE, DMA_FROM_DEVICE);
dma_cache_sync(&wd->pdev->dev, cmd->sense_buffer,
SCSI_SENSE_BUFFERSIZE, DMA_FROM_DEVICE);
dma_cache_sync only makes sense with buffers allocated through
dma_alloc_noncoherent(), which this one is not. I suspect we can just
remove the call to dma_cache_sync here, in particular since the
buffer is passed to the device next, and dma_map_single has
already done all the necessary synchronization.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-26 17:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1XtdBa-00087r-J4@debutante>
2014-11-26 17:26 ` next-20141126 build failures in wd719x Mark Brown
2014-11-26 17:41 ` Arnd Bergmann
2014-11-26 17:41 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.