* [PATCH] arm64: dts: tqma8mqml: Include phy-imx8-pcie.h header
@ 2022-09-09 13:51 Fabio Estevam
2022-09-09 14:08 ` Alexander Stein
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2022-09-09 13:51 UTC (permalink / raw)
To: shawnguo; +Cc: alexander.stein, linux-arm-kernel, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
imx8mm-tqma8mqml.dtsi has PCIe support, so it should include
<dt-bindings/phy/phy-imx8-pcie.h>.
Otherwise, there are build errors when this SoM dtsi is included
on customers' carrier boards.
Fixes: 1d84283101fc ("arm64: dts: tqma8mqml: add PCIe support")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
index 16ee9b5179e6..f649dfacb4b6 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
@@ -3,6 +3,7 @@
* Copyright 2020-2021 TQ-Systems GmbH
*/
+#include <dt-bindings/phy/phy-imx8-pcie.h>
#include "imx8mm.dtsi"
/ {
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: tqma8mqml: Include phy-imx8-pcie.h header
2022-09-09 13:51 [PATCH] arm64: dts: tqma8mqml: Include phy-imx8-pcie.h header Fabio Estevam
@ 2022-09-09 14:08 ` Alexander Stein
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Stein @ 2022-09-09 14:08 UTC (permalink / raw)
To: Fabio Estevam; +Cc: shawnguo, linux-arm-kernel, Fabio Estevam
Hello Fabio,
thanks for the patch.
Am Freitag, 9. September 2022, 15:51:50 CEST schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> imx8mm-tqma8mqml.dtsi has PCIe support, so it should include
> <dt-bindings/phy/phy-imx8-pcie.h>.
>
> Otherwise, there are build errors when this SoM dtsi is included
> on customers' carrier boards.
>
> Fixes: 1d84283101fc ("arm64: dts: tqma8mqml: add PCIe support")
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi index
> 16ee9b5179e6..f649dfacb4b6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml.dtsi
> @@ -3,6 +3,7 @@
> * Copyright 2020-2021 TQ-Systems GmbH
> */
>
> +#include <dt-bindings/phy/phy-imx8-pcie.h>
> #include "imx8mm.dtsi"
>
> / {
Does it make sense to remove this include from the board then? It's not needed
then anymore. Either way:
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-09 14:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-09 13:51 [PATCH] arm64: dts: tqma8mqml: Include phy-imx8-pcie.h header Fabio Estevam
2022-09-09 14:08 ` Alexander Stein
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.