From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Paul Greenwalt <paul.greenwalt@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Wojciech Drewek <wojciech.drewek@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 2/2] ice: update E830 device ids and comments
Date: Thu, 28 Mar 2024 14:16:15 -0700 [thread overview]
Message-ID: <212d2acd-5f5a-aa20-ca24-13746f23d492@intel.com> (raw)
In-Reply-To: <20240326163635.1529314-2-paul.greenwalt@intel.com>
On 3/26/2024 9:36 AM, Paul Greenwalt wrote:
> Update existing E830 device ids and comments to align with new naming 'C'
> for 100G and 'CC' for 200G.
>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
> ---
...
> diff --git a/drivers/net/ethernet/intel/ice/ice_devids.h b/drivers/net/ethernet/intel/ice/ice_devids.h
> index c37b2b450b02..9a1bc434f167 100644
> --- a/drivers/net/ethernet/intel/ice/ice_devids.h
> +++ b/drivers/net/ethernet/intel/ice/ice_devids.h
> @@ -16,14 +16,14 @@
> #define ICE_DEV_ID_E823L_1GBE 0x124F
> /* Intel(R) Ethernet Connection E823-L for QSFP */
> #define ICE_DEV_ID_E823L_QSFP 0x151D
> -/* Intel(R) Ethernet Controller E830-C for backplane */
> -#define ICE_DEV_ID_E830_BACKPLANE 0x12D1
> -/* Intel(R) Ethernet Controller E830-C for QSFP */
> -#define ICE_DEV_ID_E830_QSFP56 0x12D2
> -/* Intel(R) Ethernet Controller E830-C for SFP */
> -#define ICE_DEV_ID_E830_SFP 0x12D3
> -/* Intel(R) Ethernet Controller E830-C for SFP-DD */
> -#define ICE_DEV_ID_E830_SFP_DD 0x12D4
> +/* Intel(R) Ethernet Controller E830-CC for backplane */
> +#define ICE_DEV_ID_E830CC_BACKPLANE 0x12D1
> +/* Intel(R) Ethernet Controller E830-CC for QSFP */
> +#define ICE_DEV_ID_E830CC_QSFP56 0x12D2
> +/* Intel(R) Ethernet Controller E830-CC for SFP */
> +#define ICE_DEV_ID_E830CC_SFP 0x12D3
> +/* Intel(R) Ethernet Controller E830-CC for SFP-DD */
> +#define ICE_DEV_ID_E83CC0_SFP_DD 0x12D4
This doesn't compile; there's a stray '0' here.
../drivers/net/ethernet/intel/ice/ice_common.c:166:14: error:
‘ICE_DEV_ID_E830CC_SFP_DD’ undeclared (first use in this function); did
you mean ‘ICE_DEV_ID_E83CC0_SFP_DD’?
166 | case ICE_DEV_ID_E830CC_SFP_DD:
| ^~~~~~~~~~~~~~~~~~~~~~~~
| ICE_DEV_ID_E83CC0_SFP_DD
...
> /* Intel(R) Ethernet Controller E830-C for backplane */
> #define ICE_DEV_ID_E830C_BACKPLANE 0x12D5
> /* Intel(R) Ethernet Controller E830-C for QSFP */
next prev parent reply other threads:[~2024-03-28 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 16:36 [Intel-wired-lan] [PATCH iwl-next v1 1/2] ice: add additional E830 device ids Paul Greenwalt
2024-03-26 16:36 ` [Intel-wired-lan] [PATCH iwl-next v1 2/2] ice: update E830 device ids and comments Paul Greenwalt
2024-03-28 21:16 ` Tony Nguyen [this message]
2024-03-28 21:37 ` Rustad, Mark D
2024-03-28 21:41 ` Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=212d2acd-5f5a-aa20-ca24-13746f23d492@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=paul.greenwalt@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.