From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: "Rustad, Mark D" <mark.d.rustad@intel.com>
Cc: "Drewek, Wojciech" <wojciech.drewek@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"Greenwalt, Paul" <paul.greenwalt@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 2/2] ice: update E830 device ids and comments
Date: Thu, 28 Mar 2024 14:41:18 -0700 [thread overview]
Message-ID: <8cf627a3-18d6-692c-7b83-6a2e24c3ddea@intel.com> (raw)
In-Reply-To: <6C819B98-E110-43A9-8578-3C04B03FC954@intel.com>
On 3/28/2024 2:37 PM, Rustad, Mark D wrote:
>> On Mar 28, 2024, at 2:16 PM, Tony Nguyen <anthony.l.nguyen@intel.com> wrote:
>>
>>> +/* Intel(R) Ethernet Controller E830-CC for SFP-DD */
>>> +#define ICE_DEV_ID_E83CC0_SFP_DD 0x12D4
>>
>> This doesn't compile; there's a stray '0' here.
>
> Not stray, just mispositioned in the definition above.
Missed the missing 0. Yea, mispositioned. Thanks Mark :)
>
>> ../drivers/net/ethernet/intel/ice/ice_common.c:166:14: error: ‘ICE_DEV_ID_E830CC_SFP_DD’ undeclared (first use in this function); did you mean ‘ICE_DEV_ID_E83CC0_SFP_DD’?
>> 166 | case ICE_DEV_ID_E830CC_SFP_DD:
>> | ^~~~~~~~~~~~~~~~~~~~~~~~
>> | ICE_DEV_ID_E83CC0_SFP_DD
>>
>> ...
>
prev parent reply other threads:[~2024-03-28 21:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 16:36 [Intel-wired-lan] [PATCH iwl-next v1 1/2] ice: add additional E830 device ids Paul Greenwalt
2024-03-26 16:36 ` [Intel-wired-lan] [PATCH iwl-next v1 2/2] ice: update E830 device ids and comments Paul Greenwalt
2024-03-28 21:16 ` Tony Nguyen
2024-03-28 21:37 ` Rustad, Mark D
2024-03-28 21:41 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cf627a3-18d6-692c-7b83-6a2e24c3ddea@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=mark.d.rustad@intel.com \
--cc=paul.greenwalt@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.