Re: [LTP] [PATCH] Fix MSGCTL10() to avoid un-necessary cluttering of whole system with all PIDs

* Re: [LTP] [PATCH] Fix MSGCTL10() to avoid un-necessary cluttering of whole system with all PIDs
       [not found] <239293073.562841271760559982.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com>
@ 2010-04-20 10:49 ` Caspar ZHANG
  2010-04-20 11:47   ` Rishikesh K Rajak
  0 siblings, 1 reply; 5+ messages in thread
From: Caspar ZHANG @ 2010-04-20 10:49 UTC (permalink / raw)
  To: Rishikesh K Rajak; +Cc: LTP Mailing List

[-- Attachment #1: Type: text/plain, Size: 2278 bytes --]


----- "Rishikesh K Rajak" <risrajak@linux.vnet.ibm.com> wrote:

> On Tue, Apr 20, 2010 at 06:00:13AM -0400, Caspar ZHANG wrote:
> > 
> > 
> > ----- "Subrata Modak" <subrata@linux.vnet.ibm.com> wrote:
> > 
> > > Hi,
> > > 
> > > msgctl10() un-necessarily eats up all the PIDs of the system
> leading
> > > to
> > > system becoming un-responsive. The changed no.s would better do
> the
> > > job.
> > 
> > Hi, I see this patch is not included in ltp-full-20100331, will it
> be 
> > accepted in the future? 
> 
> Thanks for testing this patch. can you put your Acked-By / Tested-By
> ?
> 
> After that it will be included in master branch immediately.

Sure, add Acked-by info in the attached patch.

Thanks,
Caspar

> 
> -Rishi
> > 
> > I tested msgctl10 testcase on RHEL5(2.6.18) and RHEL6(>2.6.31),
> > Since /proc/sys/kernel/msgmni has increased from 10 (RHEL5) to 
> > thousands (RHEL6), the testing time will be several hours long.
> > Applied this patch, the testing time can be lowed down to minutes.
> > 
> > Thanks,
> > Caspar
> > 
> > > 
> > > Signed-off-by: Subrata Modak<subrata@linux.vnet.ibm.com>
> > > ---
> > > 
> > > ---
> > >
> ltp-full-20100131/testcases/kernel/syscalls/ipc/msgctl/msgctl10.c.orig
> > > 2010-02-19 17:59:23.000000000 +0530
> > > +++
> ltp-full-20100131/testcases/kernel/syscalls/ipc/msgctl/msgctl10.c
> > > 2010-02-19 18:01:13.000000000 +0530
> > > @@ -65,12 +65,8 @@ extern int Tst_count;		/* Test Case coun
> > >  
> > >  int exp_enos[] = { 0 };		/* List must end with 0 */
> > >  
> > > -#ifndef CONFIG_COLDFIRE
> > > -#define MAXNPROCS	1000000	/* This value is set to an arbitrary
> high
> > > limit. */
> > > -#else
> > > -#define MAXNPROCS	 100000	/* Coldfire can't deal with 1000000 */
> > > -#endif
> > > -#define MAXNREPS	100000
> > > +#define MAXNPROCS	10000 	/*These should be sufficient*/
> > > +#define MAXNREPS	10000	/*Else they srewup the system
> > > un-necessarily*/
> > >  #define FAIL		1
> > >  #define PASS		0
> > >  
> > > 
> > > ---
> > > Regards--
> > > Subrata

-- 
Kernel Associate Quality Engineer
Red Hat Inc. (Beijing R&D Branch)

Red Hat China R&D Branch Unit 907, North Tower C, 
  Raycom Infotech Park, No.2 Kexueyuan Nanlu, 
  Haidian District, Beijing 100190

TEL: +86-10-62608150
Web: http://www.redhat.com/

[-- Attachment #2: syscalls-msgctl10-decrease-proc-num.patch --]
[-- Type: text/x-patch, Size: 894 bytes --]

Hi,

	msgctl10() un-necessarily eats up all the PIDs of the system leading to
	system becoming un-responsive. The changed no.s would better do the job.

	Signed-off-by: Subrata Modak<subrata@linux.vnet.ibm.com>
	Acked-by: Caspar Zhang<czhang@redhat.com>

---

--- a/testcases/kernel/syscalls/ipc/msgctl/msgctl10.c	2010-04-15 18:55:19.857267414 +0800
+++ b/testcases/kernel/syscalls/ipc/msgctl/msgctl10.c	2010-04-15 18:56:53.943358977 +0800
@@ -65,12 +65,8 @@
 
 int exp_enos[] = { 0 };		/* List must end with 0 */
 
-#ifndef CONFIG_COLDFIRE
-#define MAXNPROCS	1000000	/* This value is set to an arbitrary high limit. */
-#else
-#define MAXNPROCS	 100000	/* Coldfire can't deal with 1000000 */
-#endif
-#define MAXNREPS	100000
+#define MAXNPROCS	10000	/* These should be sufficient */
+#define MAXNREPS	10000	/* Else they screw up the system un-necessarily */
 #define FAIL		1
 #define PASS		0
 

[-- Attachment #3: Type: text/plain, Size: 345 bytes --]

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 5+ messages in thread