From: Thomas Huth <thuth@redhat.com>
To: Roman Kagan <rvkagan@yandex-team.ru>, qemu-devel@nongnu.org
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Laurent Vivier <lvivier@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
yc-core@yandex-team.ru, Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot
Date: Wed, 20 Jul 2022 12:31:08 +0200 [thread overview]
Message-ID: <213763c7-b59a-45e0-cc8a-c21a2dea5baa@redhat.com> (raw)
In-Reply-To: <20220720102555.874394-1-rvkagan@yandex-team.ru>
On 20/07/2022 12.25, Roman Kagan wrote:
> It's possible to create non-working configurations by attaching a device
> to a derivative of PCIe slot (pcie-root-port, ioh3420, etc) and
> specifying a slot number other that zero, e.g.:
>
> -device pcie-root-port,id=s0,... \
> -device virtio-blk-pci,bus=s0,addr=4,...
>
> Make QEMU reject such configurations and only allow addr=0 on the
> secondary bus of a PCIe slot.
>
> To verify this new behavior, add two basic qtests for the PCIe bridges
> that may be affected by change: pcie-root-port and x3130. For the
> former, two testcases are included, one positive for slot #0 and one
> negative for (arbitrary) slot #4; for the latter, only a positive
> testcase for slot #4 is included.
>
> Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru>
> ---
> v2 -> v3:
> - do not use qtest-single stuff [Thomas]
Acked-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2022-07-20 10:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 10:25 [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot Roman Kagan
2022-07-20 10:31 ` Thomas Huth [this message]
2022-07-20 10:44 ` Daniel P. Berrangé
2022-07-20 11:00 ` Roman Kagan
2022-07-20 11:04 ` Daniel P. Berrangé
2022-07-20 11:48 ` Roman Kagan
2022-07-25 13:59 ` Vladimir Sementsov-Ogievskiy
2022-07-27 8:26 ` Igor Mammedov
2022-07-20 13:21 ` Mark Cave-Ayland
2022-07-21 14:28 ` Roman Kagan
2022-07-21 15:51 ` Mark Cave-Ayland
2022-07-21 15:56 ` Daniel P. Berrangé
2022-07-21 16:05 ` Mark Cave-Ayland
2022-07-21 16:10 ` Roman Kagan
2022-07-21 16:12 ` Daniel P. Berrangé
2022-07-22 7:28 ` Thomas Huth
2022-07-22 16:36 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=213763c7-b59a-45e0-cc8a-c21a2dea5baa@redhat.com \
--to=thuth@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rvkagan@yandex-team.ru \
--cc=vsementsov@yandex-team.ru \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.