* [PATCH 0/3] r8a7793 Gose video input support
@ 2016-09-16 13:09 Ulrich Hecht
2016-09-16 13:09 ` [PATCH 1/3] ARM: dts: r8a7793: Enable VIN0, VIN1 Ulrich Hecht
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Ulrich Hecht @ 2016-09-16 13:09 UTC (permalink / raw)
To: horms
Cc: geert, hans.verkuil, niklas.soderlund, linux-media,
linux-renesas-soc, magnus.damm, ulrich.hecht+renesas,
laurent.pinchart
Hi!
This is a by-the-datasheet implementation of analog and digital video input
on the Gose board.
I don't have that hardware, so if somebody could test this, I would
appreciate it. To get the digital part to work, use Hans's R-Car branch
(https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=rcar) plus the
"media: adv7604: automatic "default-input" selection" patch.
CU
Uli
Ulrich Hecht (3):
ARM: dts: r8a7793: Enable VIN0, VIN1
ARM: dts: gose: add HDMI input
ARM: dts: gose: add composite video input
arch/arm/boot/dts/r8a7793-gose.dts | 77 ++++++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/r8a7793.dtsi | 20 ++++++++++
2 files changed, 97 insertions(+)
--
2.9.3
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/3] ARM: dts: r8a7793: Enable VIN0, VIN1
2016-09-16 13:09 [PATCH 0/3] r8a7793 Gose video input support Ulrich Hecht
@ 2016-09-16 13:09 ` Ulrich Hecht
2016-09-19 7:17 ` Geert Uytterhoeven
2016-09-30 10:55 ` Laurent Pinchart
2016-09-16 13:09 ` [PATCH 2/3] ARM: dts: gose: add HDMI input Ulrich Hecht
2016-09-16 13:09 ` [PATCH 3/3] ARM: dts: gose: add composite video input Ulrich Hecht
2 siblings, 2 replies; 14+ messages in thread
From: Ulrich Hecht @ 2016-09-16 13:09 UTC (permalink / raw)
To: horms
Cc: geert, hans.verkuil, niklas.soderlund, linux-media,
linux-renesas-soc, magnus.damm, ulrich.hecht+renesas,
laurent.pinchart
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
arch/arm/boot/dts/r8a7793.dtsi | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
index 8d02aac..0898668 100644
--- a/arch/arm/boot/dts/r8a7793.dtsi
+++ b/arch/arm/boot/dts/r8a7793.dtsi
@@ -30,6 +30,8 @@
i2c7 = &i2c7;
i2c8 = &i2c8;
spi0 = &qspi;
+ vin0 = &vin0;
+ vin1 = &vin1;
};
cpus {
@@ -852,6 +854,24 @@
status = "disabled";
};
+ vin0: video@e6ef0000 {
+ compatible = "renesas,vin-r8a7793";
+ reg = <0 0xe6ef0000 0 0x1000>;
+ interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp8_clks R8A7793_CLK_VIN0>;
+ power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
+ status = "disabled";
+ };
+
+ vin1: video@e6ef1000 {
+ compatible = "renesas,vin-r8a7793";
+ reg = <0 0xe6ef1000 0 0x1000>;
+ interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp8_clks R8A7793_CLK_VIN1>;
+ power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
+ status = "disabled";
+ };
+
qspi: spi@e6b10000 {
compatible = "renesas,qspi-r8a7793", "renesas,qspi";
reg = <0 0xe6b10000 0 0x2c>;
--
2.9.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: dts: gose: add HDMI input
2016-09-16 13:09 [PATCH 0/3] r8a7793 Gose video input support Ulrich Hecht
2016-09-16 13:09 ` [PATCH 1/3] ARM: dts: r8a7793: Enable VIN0, VIN1 Ulrich Hecht
@ 2016-09-16 13:09 ` Ulrich Hecht
2016-09-30 12:40 ` Laurent Pinchart
2016-09-16 13:09 ` [PATCH 3/3] ARM: dts: gose: add composite video input Ulrich Hecht
2 siblings, 1 reply; 14+ messages in thread
From: Ulrich Hecht @ 2016-09-16 13:09 UTC (permalink / raw)
To: horms
Cc: geert, hans.verkuil, niklas.soderlund, linux-media,
linux-renesas-soc, magnus.damm, ulrich.hecht+renesas,
laurent.pinchart
Identical to the setup on Lager.
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
arch/arm/boot/dts/r8a7793-gose.dts | 41 ++++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts
index 90af186..e22d63c 100644
--- a/arch/arm/boot/dts/r8a7793-gose.dts
+++ b/arch/arm/boot/dts/r8a7793-gose.dts
@@ -374,6 +374,11 @@
groups = "audio_clk_a";
function = "audio_clk";
};
+
+ vin0_pins: vin0 {
+ groups = "vin0_data24", "vin0_sync", "vin0_clkenb", "vin0_clk";
+ function = "vin0";
+ };
};
ðer {
@@ -531,6 +536,21 @@
};
};
+ hdmi-in@4c {
+ compatible = "adi,adv7612";
+ reg = <0x4c>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
+ remote = <&vin0>;
+ default-input = <0>;
+
+ port {
+ adv7612: endpoint {
+ remote-endpoint = <&vin0ep>;
+ };
+ };
+ };
+
eeprom@50 {
compatible = "renesas,r1ex24002", "atmel,24c02";
reg = <0x50>;
@@ -558,3 +578,24 @@
&ssi1 {
shared-pin;
};
+
+/* HDMI video input */
+&vin0 {
+ status = "okay";
+ pinctrl-0 = <&vin0_pins>;
+ pinctrl-names = "default";
+
+ port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ vin0ep: endpoint {
+ remote-endpoint = <&adv7612>;
+ bus-width = <24>;
+ hsync-active = <0>;
+ vsync-active = <0>;
+ pclk-sample = <1>;
+ data-active = <1>;
+ };
+ };
+};
--
2.9.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/3] ARM: dts: gose: add composite video input
2016-09-16 13:09 [PATCH 0/3] r8a7793 Gose video input support Ulrich Hecht
2016-09-16 13:09 ` [PATCH 1/3] ARM: dts: r8a7793: Enable VIN0, VIN1 Ulrich Hecht
2016-09-16 13:09 ` [PATCH 2/3] ARM: dts: gose: add HDMI input Ulrich Hecht
@ 2016-09-16 13:09 ` Ulrich Hecht
2016-09-30 12:42 ` Laurent Pinchart
2 siblings, 1 reply; 14+ messages in thread
From: Ulrich Hecht @ 2016-09-16 13:09 UTC (permalink / raw)
To: horms
Cc: geert, hans.verkuil, niklas.soderlund, linux-media,
linux-renesas-soc, magnus.damm, ulrich.hecht+renesas,
laurent.pinchart
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
arch/arm/boot/dts/r8a7793-gose.dts | 36 ++++++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7793-gose.dts b/arch/arm/boot/dts/r8a7793-gose.dts
index e22d63c..981f0fe 100644
--- a/arch/arm/boot/dts/r8a7793-gose.dts
+++ b/arch/arm/boot/dts/r8a7793-gose.dts
@@ -379,6 +379,11 @@
groups = "vin0_data24", "vin0_sync", "vin0_clkenb", "vin0_clk";
function = "vin0";
};
+
+ vin1_pins: vin1 {
+ groups = "vin1_data8", "vin1_clk";
+ function = "vin1";
+ };
};
ðer {
@@ -504,6 +509,19 @@
reg = <0x12>;
};
+ composite-in@20 {
+ compatible = "adi,adv7180";
+ reg = <0x20>;
+ remote = <&vin1>;
+
+ port {
+ adv7180: endpoint {
+ bus-width = <8>;
+ remote-endpoint = <&vin1ep>;
+ };
+ };
+ };
+
hdmi@39 {
compatible = "adi,adv7511w";
reg = <0x39>;
@@ -599,3 +617,21 @@
};
};
};
+
+/* composite video input */
+&vin1 {
+ pinctrl-0 = <&vin1_pins>;
+ pinctrl-names = "default";
+
+ status = "okay";
+
+ port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ vin1ep: endpoint {
+ remote-endpoint = <&adv7180>;
+ bus-width = <8>;
+ };
+ };
+};
--
2.9.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] ARM: dts: r8a7793: Enable VIN0, VIN1
2016-09-16 13:09 ` [PATCH 1/3] ARM: dts: r8a7793: Enable VIN0, VIN1 Ulrich Hecht
@ 2016-09-19 7:17 ` Geert Uytterhoeven
2016-09-30 10:55 ` Laurent Pinchart
1 sibling, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2016-09-19 7:17 UTC (permalink / raw)
To: Ulrich Hecht
Cc: Simon Horman, Hans Verkuil, Niklas Söderlund,
Linux Media Mailing List, Linux-Renesas, Magnus Damm,
Laurent Pinchart
Hi Ulrich,
On Fri, Sep 16, 2016 at 3:09 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/arch/arm/boot/dts/r8a7793.dtsi
> +++ b/arch/arm/boot/dts/r8a7793.dtsi
> @@ -30,6 +30,8 @@
> i2c7 = &i2c7;
> i2c8 = &i2c8;
> spi0 = &qspi;
> + vin0 = &vin0;
> + vin1 = &vin1;
> };
>
> cpus {
> @@ -852,6 +854,24 @@
> status = "disabled";
> };
>
> + vin0: video@e6ef0000 {
> + vin1: video@e6ef1000 {
Any specific reason you didn't add vin2?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] ARM: dts: r8a7793: Enable VIN0, VIN1
2016-09-16 13:09 ` [PATCH 1/3] ARM: dts: r8a7793: Enable VIN0, VIN1 Ulrich Hecht
2016-09-19 7:17 ` Geert Uytterhoeven
@ 2016-09-30 10:55 ` Laurent Pinchart
2016-09-30 11:08 ` Laurent Pinchart
1 sibling, 1 reply; 14+ messages in thread
From: Laurent Pinchart @ 2016-09-30 10:55 UTC (permalink / raw)
To: Ulrich Hecht
Cc: horms, geert, hans.verkuil, niklas.soderlund, linux-media,
linux-renesas-soc, magnus.damm
Hi Ulrich,
Thanks for the patch.
On Friday 16 Sep 2016 15:09:33 Ulrich Hecht wrote:
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
> arch/arm/boot/dts/r8a7793.dtsi | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
> index 8d02aac..0898668 100644
> --- a/arch/arm/boot/dts/r8a7793.dtsi
> +++ b/arch/arm/boot/dts/r8a7793.dtsi
> @@ -30,6 +30,8 @@
> i2c7 = &i2c7;
> i2c8 = &i2c8;
> spi0 = &qspi;
> + vin0 = &vin0;
> + vin1 = &vin1;
Why is this needed ?
> };
>
> cpus {
> @@ -852,6 +854,24 @@
> status = "disabled";
> };
>
> + vin0: video@e6ef0000 {
> + compatible = "renesas,vin-r8a7793";
> + reg = <0 0xe6ef0000 0 0x1000>;
> + interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp8_clks R8A7793_CLK_VIN0>;
> + power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
> + status = "disabled";
> + };
> +
> + vin1: video@e6ef1000 {
> + compatible = "renesas,vin-r8a7793";
> + reg = <0 0xe6ef1000 0 0x1000>;
> + interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp8_clks R8A7793_CLK_VIN1>;
> + power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
> + status = "disabled";
> + };
> +
As Geert mentioned, you should add vin2 here.
> qspi: spi@e6b10000 {
> compatible = "renesas,qspi-r8a7793", "renesas,qspi";
> reg = <0 0xe6b10000 0 0x2c>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] ARM: dts: r8a7793: Enable VIN0, VIN1
2016-09-30 10:55 ` Laurent Pinchart
@ 2016-09-30 11:08 ` Laurent Pinchart
0 siblings, 0 replies; 14+ messages in thread
From: Laurent Pinchart @ 2016-09-30 11:08 UTC (permalink / raw)
To: Ulrich Hecht
Cc: horms, geert, hans.verkuil, niklas.soderlund, linux-media,
linux-renesas-soc, magnus.damm
Hi Ulrich,
On Friday 30 Sep 2016 13:55:50 Laurent Pinchart wrote:
> On Friday 16 Sep 2016 15:09:33 Ulrich Hecht wrote:
> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> > ---
> >
> > arch/arm/boot/dts/r8a7793.dtsi | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/r8a7793.dtsi
> > b/arch/arm/boot/dts/r8a7793.dtsi index 8d02aac..0898668 100644
> > --- a/arch/arm/boot/dts/r8a7793.dtsi
> > +++ b/arch/arm/boot/dts/r8a7793.dtsi
> > @@ -30,6 +30,8 @@
> > i2c7 = &i2c7;
> > i2c8 = &i2c8;
> > spi0 = &qspi;
> > + vin0 = &vin0;
> > + vin1 = &vin1;
>
> Why is this needed ?
>
> > };
> >
> > cpus {
> > @@ -852,6 +854,24 @@
> > status = "disabled";
> > };
> >
> > + vin0: video@e6ef0000 {
> > + compatible = "renesas,vin-r8a7793";
Additionally, should this be
compatiable = "renesas,vin-r8a7793", "renesas,rcar-gen2-vin";
?
> > + reg = <0 0xe6ef0000 0 0x1000>;
> > + interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&mstp8_clks R8A7793_CLK_VIN0>;
> > + power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
> > + status = "disabled";
> > + };
> > +
> > + vin1: video@e6ef1000 {
> > + compatible = "renesas,vin-r8a7793";
> > + reg = <0 0xe6ef1000 0 0x1000>;
> > + interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&mstp8_clks R8A7793_CLK_VIN1>;
> > + power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
> > + status = "disabled";
> > + };
> > +
>
> As Geert mentioned, you should add vin2 here.
>
> > qspi: spi@e6b10000 {
> >
> > compatible = "renesas,qspi-r8a7793", "renesas,qspi";
> > reg = <0 0xe6b10000 0 0x2c>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] ARM: dts: gose: add HDMI input
2016-09-16 13:09 ` [PATCH 2/3] ARM: dts: gose: add HDMI input Ulrich Hecht
@ 2016-09-30 12:40 ` Laurent Pinchart
2016-09-30 13:00 ` Geert Uytterhoeven
0 siblings, 1 reply; 14+ messages in thread
From: Laurent Pinchart @ 2016-09-30 12:40 UTC (permalink / raw)
To: Ulrich Hecht
Cc: horms, geert, hans.verkuil, niklas.soderlund, linux-media,
linux-renesas-soc, magnus.damm
Hi Ulrich,
Thank you for the patch.
On Friday 16 Sep 2016 15:09:34 Ulrich Hecht wrote:
> Identical to the setup on Lager.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
> arch/arm/boot/dts/r8a7793-gose.dts | 41 +++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7793-gose.dts
> b/arch/arm/boot/dts/r8a7793-gose.dts index 90af186..e22d63c 100644
> --- a/arch/arm/boot/dts/r8a7793-gose.dts
> +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> @@ -374,6 +374,11 @@
> groups = "audio_clk_a";
> function = "audio_clk";
> };
> +
> + vin0_pins: vin0 {
> + groups = "vin0_data24", "vin0_sync", "vin0_clkenb",
"vin0_clk";
> + function = "vin0";
> + };
> };
>
> ðer {
> @@ -531,6 +536,21 @@
> };
> };
>
> + hdmi-in@4c {
> + compatible = "adi,adv7612";
> + reg = <0x4c>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
Isn't the interrupt signal connected to GP4_2 ?
> + remote = <&vin0>;
What is this for ?
> + default-input = <0>;
> +
> + port {
> + adv7612: endpoint {
> + remote-endpoint = <&vin0ep>;
> + };
> + };
The ADV7612 has three ports. Ports 0 and 1 correspond to the HDMI inputs, and
port 2 to the digital output. You can leave port 1 out as it's not used on the
board, but you should specify both ports 0 and 2, and add an HDMI connector DT
node connected to port 0 of the ADV7612.
> + };
> +
> eeprom@50 {
> compatible = "renesas,r1ex24002", "atmel,24c02";
> reg = <0x50>;
> @@ -558,3 +578,24 @@
> &ssi1 {
> shared-pin;
> };
> +
> +/* HDMI video input */
> +&vin0 {
> + status = "okay";
> + pinctrl-0 = <&vin0_pins>;
> + pinctrl-names = "default";
> +
> + port {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + vin0ep: endpoint {
> + remote-endpoint = <&adv7612>;
> + bus-width = <24>;
> + hsync-active = <0>;
> + vsync-active = <0>;
> + pclk-sample = <1>;
> + data-active = <1>;
> + };
> + };
> +};
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] ARM: dts: gose: add composite video input
2016-09-16 13:09 ` [PATCH 3/3] ARM: dts: gose: add composite video input Ulrich Hecht
@ 2016-09-30 12:42 ` Laurent Pinchart
0 siblings, 0 replies; 14+ messages in thread
From: Laurent Pinchart @ 2016-09-30 12:42 UTC (permalink / raw)
To: Ulrich Hecht
Cc: horms, geert, hans.verkuil, niklas.soderlund, linux-media,
linux-renesas-soc, magnus.damm
Hi Ulrich,
Thank you for the patch.
On Friday 16 Sep 2016 15:09:35 Ulrich Hecht wrote:
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
> arch/arm/boot/dts/r8a7793-gose.dts | 36 ++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7793-gose.dts
> b/arch/arm/boot/dts/r8a7793-gose.dts index e22d63c..981f0fe 100644
> --- a/arch/arm/boot/dts/r8a7793-gose.dts
> +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> @@ -379,6 +379,11 @@
> groups = "vin0_data24", "vin0_sync", "vin0_clkenb",
"vin0_clk";
> function = "vin0";
> };
> +
> + vin1_pins: vin1 {
> + groups = "vin1_data8", "vin1_clk";
> + function = "vin1";
> + };
> };
>
> ðer {
> @@ -504,6 +509,19 @@
> reg = <0x12>;
> };
>
> + composite-in@20 {
> + compatible = "adi,adv7180";
> + reg = <0x20>;
> + remote = <&vin1>;
> +
> + port {
> + adv7180: endpoint {
> + bus-width = <8>;
Is this needed ?
> + remote-endpoint = <&vin1ep>;
> + };
> + };
The ADV7180 DT bindings need to be updated with port nodes (that will be quite
a challenge).
> + };
> +
> hdmi@39 {
> compatible = "adi,adv7511w";
> reg = <0x39>;
> @@ -599,3 +617,21 @@
> };
> };
> };
> +
> +/* composite video input */
> +&vin1 {
> + pinctrl-0 = <&vin1_pins>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +
> + port {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + vin1ep: endpoint {
> + remote-endpoint = <&adv7180>;
> + bus-width = <8>;
> + };
> + };
> +};
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] ARM: dts: gose: add HDMI input
2016-09-30 12:40 ` Laurent Pinchart
@ 2016-09-30 13:00 ` Geert Uytterhoeven
2016-09-30 13:32 ` Laurent Pinchart
0 siblings, 1 reply; 14+ messages in thread
From: Geert Uytterhoeven @ 2016-09-30 13:00 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Ulrich Hecht, Simon Horman, Hans Verkuil, Niklas Söderlund,
Linux Media Mailing List, Linux-Renesas, Magnus Damm
On Fri, Sep 30, 2016 at 2:40 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>> --- a/arch/arm/boot/dts/r8a7793-gose.dts
>> +++ b/arch/arm/boot/dts/r8a7793-gose.dts
>> @@ -374,6 +374,11 @@
>> groups = "audio_clk_a";
>> function = "audio_clk";
>> };
>> +
>> + vin0_pins: vin0 {
>> + groups = "vin0_data24", "vin0_sync", "vin0_clkenb",
> "vin0_clk";
>> + function = "vin0";
>> + };
>> };
>>
>> ðer {
>> @@ -531,6 +536,21 @@
>> };
>> };
>>
>> + hdmi-in@4c {
>> + compatible = "adi,adv7612";
>> + reg = <0x4c>;
>> + interrupt-parent = <&gpio1>;
>> + interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
>
> Isn't the interrupt signal connected to GP4_2 ?
No idea about Gose, but on Koelsch it is (hence koelsch DTS is wrong??)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] ARM: dts: gose: add HDMI input
2016-09-30 13:00 ` Geert Uytterhoeven
@ 2016-09-30 13:32 ` Laurent Pinchart
2016-10-01 9:19 ` Niklas Söderlund
0 siblings, 1 reply; 14+ messages in thread
From: Laurent Pinchart @ 2016-09-30 13:32 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Ulrich Hecht, Simon Horman, Hans Verkuil, Niklas Söderlund,
Linux Media Mailing List, Linux-Renesas, Magnus Damm
On Friday 30 Sep 2016 15:00:59 Geert Uytterhoeven wrote:
> On Fri, Sep 30, 2016 at 2:40 PM, Laurent Pinchart wrote:
> >> --- a/arch/arm/boot/dts/r8a7793-gose.dts
> >> +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> >> @@ -374,6 +374,11 @@
> >> groups = "audio_clk_a";
> >> function = "audio_clk";
> >> };
> >> +
> >> + vin0_pins: vin0 {
> >> + groups = "vin0_data24", "vin0_sync", "vin0_clkenb",
> >> "vin0_clk";
> >> + function = "vin0";
> >> + };
> >> };
> >>
> >> ðer {
> >> @@ -531,6 +536,21 @@
> >> };
> >> };
> >>
> >> + hdmi-in@4c {
> >> + compatible = "adi,adv7612";
> >> + reg = <0x4c>;
> >> + interrupt-parent = <&gpio1>;
> >> + interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
> >
> > Isn't the interrupt signal connected to GP4_2 ?
>
> No idea about Gose, but on Koelsch it is (hence koelsch DTS is wrong??)
I believe so. I don't have a Koelsch board anymore so I can't test that.
Niklas, do you have a Koelsch on which you could confirm the IRQ number ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] ARM: dts: gose: add HDMI input
2016-09-30 13:32 ` Laurent Pinchart
@ 2016-10-01 9:19 ` Niklas Söderlund
0 siblings, 0 replies; 14+ messages in thread
From: Niklas Söderlund @ 2016-10-01 9:19 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Geert Uytterhoeven, Ulrich Hecht, Simon Horman, Hans Verkuil,
Linux Media Mailing List, Linux-Renesas, Magnus Damm
On 2016-09-30 16:32:52 +0300, Laurent Pinchart wrote:
> On Friday 30 Sep 2016 15:00:59 Geert Uytterhoeven wrote:
> > On Fri, Sep 30, 2016 at 2:40 PM, Laurent Pinchart wrote:
> > >> --- a/arch/arm/boot/dts/r8a7793-gose.dts
> > >> +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> > >> @@ -374,6 +374,11 @@
> > >> groups = "audio_clk_a";
> > >> function = "audio_clk";
> > >> };
> > >> +
> > >> + vin0_pins: vin0 {
> > >> + groups = "vin0_data24", "vin0_sync", "vin0_clkenb",
> > >> "vin0_clk";
> > >> + function = "vin0";
> > >> + };
> > >> };
> > >>
> > >> ðer {
> > >> @@ -531,6 +536,21 @@
> > >> };
> > >> };
> > >>
> > >> + hdmi-in@4c {
> > >> + compatible = "adi,adv7612";
> > >> + reg = <0x4c>;
> > >> + interrupt-parent = <&gpio1>;
> > >> + interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
> > >
> > > Isn't the interrupt signal connected to GP4_2 ?
> >
> > No idea about Gose, but on Koelsch it is (hence koelsch DTS is wrong??)
>
> I believe so. I don't have a Koelsch board anymore so I can't test that.
> Niklas, do you have a Koelsch on which you could confirm the IRQ number ?
I have done the best I can to prove the IRQ, it proved to be a bit
tricky or maybe I'm doing it the wrong way.
I hooked up my oscilloscope to EXIO Connector D pin 7, which according
to the schematics should be GP4_2 and attached to a pull-up at 3.3v. I
can observe the pull-up and if I control the pin using the
/sys/class/gpio interface I do indeed control GP4_2, So the schematic is
correct at least this far.
The trouble I have is that the adv7612 driver do not currently consume
the interrupt so I can't see multiple field interrupts by observing the
pin. I do however see what I believe is the first field interrupt, if I
observe the pin just as I turn on my HDMI video source the pin go from 1
-> 0 but is never reset and a reset of the entire board is needed if you
wish to see it again.
If I on the other hand observe pin GP1_20 on EXIO Connector A pin 66 I
notice nothing on the oscilloscope from that it's set to 3.3V at power
on, no mater how much HDMI input i run.
In conclusion, yes I do believe the DTS is wrong and that GP4_2 is the
correct interrupt signal on Koelsch. This adds up with the schematics
and my rudimentary measurements.
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] ARM: dts: gose: add HDMI input
@ 2016-10-01 9:19 ` Niklas Söderlund
0 siblings, 0 replies; 14+ messages in thread
From: Niklas Söderlund @ 2016-10-01 9:19 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Geert Uytterhoeven, Ulrich Hecht, Simon Horman, Hans Verkuil,
Linux Media Mailing List, Linux-Renesas, Magnus Damm
On 2016-09-30 16:32:52 +0300, Laurent Pinchart wrote:
> On Friday 30 Sep 2016 15:00:59 Geert Uytterhoeven wrote:
> > On Fri, Sep 30, 2016 at 2:40 PM, Laurent Pinchart wrote:
> > >> --- a/arch/arm/boot/dts/r8a7793-gose.dts
> > >> +++ b/arch/arm/boot/dts/r8a7793-gose.dts
> > >> @@ -374,6 +374,11 @@
> > >> groups = "audio_clk_a";
> > >> function = "audio_clk";
> > >> };
> > >> +
> > >> + vin0_pins: vin0 {
> > >> + groups = "vin0_data24", "vin0_sync", "vin0_clkenb",
> > >> "vin0_clk";
> > >> + function = "vin0";
> > >> + };
> > >> };
> > >>
> > >> ðer {
> > >> @@ -531,6 +536,21 @@
> > >> };
> > >> };
> > >>
> > >> + hdmi-in@4c {
> > >> + compatible = "adi,adv7612";
> > >> + reg = <0x4c>;
> > >> + interrupt-parent = <&gpio1>;
> > >> + interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
> > >
> > > Isn't the interrupt signal connected to GP4_2 ?
> >
> > No idea about Gose, but on Koelsch it is (hence koelsch DTS is wrong??)
>
> I believe so. I don't have a Koelsch board anymore so I can't test that.
> Niklas, do you have a Koelsch on which you could confirm the IRQ number ?
I have done the best I can to prove the IRQ, it proved to be a bit
tricky or maybe I'm doing it the wrong way.
I hooked up my oscilloscope to EXIO Connector D pin 7, which according
to the schematics should be GP4_2 and attached to a pull-up at 3.3v. I
can observe the pull-up and if I control the pin using the
/sys/class/gpio interface I do indeed control GP4_2, So the schematic is
correct at least this far.
The trouble I have is that the adv7612 driver do not currently consume
the interrupt so I can't see multiple field interrupts by observing the
pin. I do however see what I believe is the first field interrupt, if I
observe the pin just as I turn on my HDMI video source the pin go from 1
-> 0 but is never reset and a reset of the entire board is needed if you
wish to see it again.
If I on the other hand observe pin GP1_20 on EXIO Connector A pin 66 I
notice nothing on the oscilloscope from that it's set to 3.3V at power
on, no mater how much HDMI input i run.
In conclusion, yes I do believe the DTS is wrong and that GP4_2 is the
correct interrupt signal on Koelsch. This adds up with the schematics
and my rudimentary measurements.
--
Regards,
Niklas S�derlund
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] ARM: dts: gose: add HDMI input
2016-10-01 9:19 ` Niklas Söderlund
(?)
@ 2016-10-03 10:16 ` Laurent Pinchart
-1 siblings, 0 replies; 14+ messages in thread
From: Laurent Pinchart @ 2016-10-03 10:16 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Geert Uytterhoeven, Ulrich Hecht, Simon Horman, Hans Verkuil,
Linux Media Mailing List, Linux-Renesas, Magnus Damm
Hi Niklas,
On Saturday 01 Oct 2016 11:19:31 Niklas Söderlund wrote:
> On 2016-09-30 16:32:52 +0300, Laurent Pinchart wrote:
> > On Friday 30 Sep 2016 15:00:59 Geert Uytterhoeven wrote:
> >> On Fri, Sep 30, 2016 at 2:40 PM, Laurent Pinchart wrote:
> >>>> --- a/arch/arm/boot/dts/r8a7793-gose.dts
> >>>> +++ b/arch/arm/boot/dts/r8a7793-gose.dts
[snip]
> >>>> @@ -531,6 +536,21 @@
> >>>> };
> >>>> };
> >>>>
> >>>> + hdmi-in@4c {
> >>>> + compatible = "adi,adv7612";
> >>>> + reg = <0x4c>;
> >>>> + interrupt-parent = <&gpio1>;
> >>>> + interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
> >>>
> >>> Isn't the interrupt signal connected to GP4_2 ?
> >>
> >> No idea about Gose, but on Koelsch it is (hence koelsch DTS is wrong??)
> >
> > I believe so. I don't have a Koelsch board anymore so I can't test that.
> > Niklas, do you have a Koelsch on which you could confirm the IRQ number ?
>
> I have done the best I can to prove the IRQ, it proved to be a bit
> tricky or maybe I'm doing it the wrong way.
>
> I hooked up my oscilloscope to EXIO Connector D pin 7, which according
> to the schematics should be GP4_2 and attached to a pull-up at 3.3v. I
> can observe the pull-up and if I control the pin using the
> /sys/class/gpio interface I do indeed control GP4_2, So the schematic is
> correct at least this far.
>
> The trouble I have is that the adv7612 driver do not currently consume
> the interrupt so I can't see multiple field interrupts by observing the
> pin. I do however see what I believe is the first field interrupt, if I
> observe the pin just as I turn on my HDMI video source the pin go from 1
> -> 0 but is never reset and a reset of the entire board is needed if you
> wish to see it again.
>
> If I on the other hand observe pin GP1_20 on EXIO Connector A pin 66 I
> notice nothing on the oscilloscope from that it's set to 3.3V at power
> on, no mater how much HDMI input i run.
>
> In conclusion, yes I do believe the DTS is wrong and that GP4_2 is the
> correct interrupt signal on Koelsch. This adds up with the schematics
> and my rudimentary measurements.
Thanks a lot for testing. Ulrich, could you please fix this patch accordingly
?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2016-10-03 10:16 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-16 13:09 [PATCH 0/3] r8a7793 Gose video input support Ulrich Hecht
2016-09-16 13:09 ` [PATCH 1/3] ARM: dts: r8a7793: Enable VIN0, VIN1 Ulrich Hecht
2016-09-19 7:17 ` Geert Uytterhoeven
2016-09-30 10:55 ` Laurent Pinchart
2016-09-30 11:08 ` Laurent Pinchart
2016-09-16 13:09 ` [PATCH 2/3] ARM: dts: gose: add HDMI input Ulrich Hecht
2016-09-30 12:40 ` Laurent Pinchart
2016-09-30 13:00 ` Geert Uytterhoeven
2016-09-30 13:32 ` Laurent Pinchart
2016-10-01 9:19 ` Niklas Söderlund
2016-10-01 9:19 ` Niklas Söderlund
2016-10-03 10:16 ` Laurent Pinchart
2016-09-16 13:09 ` [PATCH 3/3] ARM: dts: gose: add composite video input Ulrich Hecht
2016-09-30 12:42 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.