* Re: [PATCH v2] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe()
2021-04-08 13:27 [PATCH v2] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe() ErKun Yang
@ 2021-04-08 13:21 ` ErKun Yang
2021-05-27 13:33 ` yangerkun
2021-08-05 11:12 ` Lorenzo Pieralisi
2 siblings, 0 replies; 4+ messages in thread
From: ErKun Yang @ 2021-04-08 13:21 UTC (permalink / raw)
To: toan, lorenzo.pieralisi, robh, bhelgaas, kw; +Cc: linux-pci, yukuai3
+ Krzysztof Wilczyński
Sorry for missing mail-to...
在 2021/4/8 21:27, ErKun Yang 写道:
> devm_ioremap_resource() internally calls __devm_ioremap_resource() which
> is where error checking and handling is actually having place. So the
> dev_err in xgene_msi_probe() seems redundant and remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
> Signed-off-by: ErKun Yang <yangerkun@huawei.com>
> ---
> drivers/pci/controller/pci-xgene-msi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c
> index 1c34c897a7e2..369b50f626fd 100644
> --- a/drivers/pci/controller/pci-xgene-msi.c
> +++ b/drivers/pci/controller/pci-xgene-msi.c
> @@ -451,7 +451,6 @@ static int xgene_msi_probe(struct platform_device *pdev)
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> xgene_msi->msi_regs = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(xgene_msi->msi_regs)) {
> - dev_err(&pdev->dev, "no reg space\n");
> rc = PTR_ERR(xgene_msi->msi_regs);
> goto error;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe()
@ 2021-04-08 13:27 ErKun Yang
2021-04-08 13:21 ` ErKun Yang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: ErKun Yang @ 2021-04-08 13:27 UTC (permalink / raw)
To: toan, lorenzo.pieralisi, robh, bhelgaas; +Cc: linux-pci, yangerkun, yukuai3
devm_ioremap_resource() internally calls __devm_ioremap_resource() which
is where error checking and handling is actually having place. So the
dev_err in xgene_msi_probe() seems redundant and remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Signed-off-by: ErKun Yang <yangerkun@huawei.com>
---
drivers/pci/controller/pci-xgene-msi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c
index 1c34c897a7e2..369b50f626fd 100644
--- a/drivers/pci/controller/pci-xgene-msi.c
+++ b/drivers/pci/controller/pci-xgene-msi.c
@@ -451,7 +451,6 @@ static int xgene_msi_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
xgene_msi->msi_regs = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(xgene_msi->msi_regs)) {
- dev_err(&pdev->dev, "no reg space\n");
rc = PTR_ERR(xgene_msi->msi_regs);
goto error;
}
--
2.25.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe()
2021-04-08 13:27 [PATCH v2] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe() ErKun Yang
2021-04-08 13:21 ` ErKun Yang
@ 2021-05-27 13:33 ` yangerkun
2021-08-05 11:12 ` Lorenzo Pieralisi
2 siblings, 0 replies; 4+ messages in thread
From: yangerkun @ 2021-05-27 13:33 UTC (permalink / raw)
To: toan, lorenzo.pieralisi, robh, bhelgaas; +Cc: linux-pci, yukuai3
Ping...
在 2021/4/8 21:27, ErKun Yang 写道:
> devm_ioremap_resource() internally calls __devm_ioremap_resource() which
> is where error checking and handling is actually having place. So the
> dev_err in xgene_msi_probe() seems redundant and remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
> Signed-off-by: ErKun Yang <yangerkun@huawei.com>
> ---
> drivers/pci/controller/pci-xgene-msi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c
> index 1c34c897a7e2..369b50f626fd 100644
> --- a/drivers/pci/controller/pci-xgene-msi.c
> +++ b/drivers/pci/controller/pci-xgene-msi.c
> @@ -451,7 +451,6 @@ static int xgene_msi_probe(struct platform_device *pdev)
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> xgene_msi->msi_regs = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(xgene_msi->msi_regs)) {
> - dev_err(&pdev->dev, "no reg space\n");
> rc = PTR_ERR(xgene_msi->msi_regs);
> goto error;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe()
2021-04-08 13:27 [PATCH v2] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe() ErKun Yang
2021-04-08 13:21 ` ErKun Yang
2021-05-27 13:33 ` yangerkun
@ 2021-08-05 11:12 ` Lorenzo Pieralisi
2 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Pieralisi @ 2021-08-05 11:12 UTC (permalink / raw)
To: bhelgaas, toan, robh, ErKun Yang; +Cc: Lorenzo Pieralisi, yukuai3, linux-pci
On Thu, 8 Apr 2021 21:27:51 +0800, ErKun Yang wrote:
> devm_ioremap_resource() internally calls __devm_ioremap_resource() which
> is where error checking and handling is actually having place. So the
> dev_err in xgene_msi_probe() seems redundant and remove it.
Applied to pci/xgene, thanks!
[1/1] PCI: xgene-msi: Remove redundant dev_err() call in xgene_msi_probe()
https://git.kernel.org/lpieralisi/pci/c/9e4ae52cab
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-05 11:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 13:27 [PATCH v2] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe() ErKun Yang
2021-04-08 13:21 ` ErKun Yang
2021-05-27 13:33 ` yangerkun
2021-08-05 11:12 ` Lorenzo Pieralisi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.